On 12/23/20 7:45 AM, David Arcari wrote:
Hi,
On 12/16/20 8:35 AM, GitLab Bridge on behalf of redhat-patchlab wrote:
> From: Fedora Kernel Team <kernel-team(a)fedoraproject.org>
>
> Hi,
>
> As part of the ongoing rebase effort, the following configuration
> options need to be reviewed.
>
> As a reminder, the ARK configuration flow involves moving unreviewed
> configuration options from the pending directory to the ark directory.
> In the diff below, options are removed from the pending directory and
> added to the ark hierarchy. The final options that need to be ACKed
> are the files that are being added to the ark hierarchy.
>
> If the value for a file that is added should be changed, please reply
> with a better option.
>
> CONFIG_AMD_PMC:
>
> The driver provides support for AMD Power Management Controller
> primarily responsible for S2Idle transactions that are driven from
> a platform firmware running on SMU. This driver also provides a debug
> mechanism to investigate the S2Idle transactions and failures.
>
> Say Y or M here if you have a notebook powered by AMD RYZEN CPU/APU.
>
> If you choose to compile this driver as a module the module will be
> called amd-pmc.
>
> Symbol: AMD_PMC [=n]
> Type : tristate
> Defined at drivers/platform/x86/Kconfig:194
> Prompt: AMD SoC PMC driver
> Depends on: X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y]
&& PCI [=y]
> Location:
> -> Device Drivers
> -> X86 Platform Specific Device Drivers (X86_PLATFORM_DEVICES [=y])
>
> ---
>
> CONFIG_DELL_WMI_SYSMAN:
>
> This driver allows changing BIOS settings on many Dell machines from
> 2018 and newer without the use of any additional software.
>
> To compile this driver as a module, choose M here: the module will
> be called dell-wmi-sysman.
>
> Symbol: DELL_WMI_SYSMAN [=n]
> Type : tristate
> Defined at drivers/platform/x86/Kconfig:458
> Prompt: Dell WMI-based Systems management driver
> Depends on: X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI_WMI
[=m] && DMI [=y]
> Location:
> -> Device Drivers
> -> X86 Platform Specific Device Drivers (X86_PLATFORM_DEVICES [=y])
> Selects: NLS [=y]
>
> ---
>
> CONFIG_INTEL_PMT_CLASS:
>
> The Intel Platform Monitoring Technology (PMT) class driver provides
> the basic sysfs interface and file hierarchy uses by PMT devices.
>
> For more information, see:
> <file:Documentation/ABI/testing/sysfs-class-intel_pmt>
>
> To compile this driver as a module, choose M here: the module
> will be called intel_pmt_class.
>
> Symbol: INTEL_PMT_CLASS [=n]
> Type : tristate
> Defined at drivers/platform/x86/Kconfig:1371
> Prompt: Intel Platform Monitoring Technology (PMT) Class driver
> Depends on: X86 [=y] && X86_PLATFORM_DEVICES [=y]
> Location:
> -> Device Drivers
> -> X86 Platform Specific Device Drivers (X86_PLATFORM_DEVICES [=y])
> Selected by [n]:
> - INTEL_PMT_TELEMETRY [=n] && X86 [=y] && X86_PLATFORM_DEVICES
[=y]
> - INTEL_PMT_CRASHLOG [=n] && X86 [=y] && X86_PLATFORM_DEVICES
[=y]
>
> ---
>
> CONFIG_INTEL_PMT_CRASHLOG:
>
> The Intel Platform Monitoring Technology (PMT) crashlog driver provides
> access to hardware crashlog capabilities on devices that support the
> feature.
>
> To compile this driver as a module, choose M here: the module
> will be called intel_pmt_crashlog.
>
> Symbol: INTEL_PMT_CRASHLOG [=n]
> Type : tristate
> Defined at drivers/platform/x86/Kconfig:1394
> Prompt: Intel Platform Monitoring Technology (PMT) Crashlog driver
> Depends on: X86 [=y] && X86_PLATFORM_DEVICES [=y]
> Location:
> -> Device Drivers
> -> X86 Platform Specific Device Drivers (X86_PLATFORM_DEVICES [=y])
> Selects: INTEL_PMT_CLASS [=n]
>
> ---
>
> CONFIG_INTEL_PMT_TELEMETRY:
>
> The Intel Platform Monitory Technology (PMT) Telemetry driver provides
> access to hardware telemetry metrics on devices that support the
> feature.
>
> To compile this driver as a module, choose M here: the module
> will be called intel_pmt_telemetry.
>
> Symbol: INTEL_PMT_TELEMETRY [=n]
> Type : tristate
> Defined at drivers/platform/x86/Kconfig:1383
> Prompt: Intel Platform Monitoring Technology (PMT) Telemetry driver
> Depends on: X86 [=y] && X86_PLATFORM_DEVICES [=y]
> Location:
> -> Device Drivers
> -> X86 Platform Specific Device Drivers (X86_PLATFORM_DEVICES [=y])
> Selects: INTEL_PMT_CLASS [=n]
>
> ---
>
> CONFIG_MLXBF_PMC:
>
> Say y here to enable PMC support. The PMC driver provides access
> to performance monitoring counters within various blocks in the
> Mellanox BlueField SoC via a sysfs interface.
>
> Symbol: MLXBF_PMC [=n]
> Type : tristate
> Defined at drivers/platform/mellanox/Kconfig:59
> Prompt: Mellanox BlueField Performance Monitoring Counters driver
> Depends on: MELLANOX_PLATFORM [=y] && ARM64 [=y] && HWMON [=y]
&& ACPI [=y]
> Location:
> -> Device Drivers
> -> Platform support for Mellanox hardware (MELLANOX_PLATFORM [=y])
>
> ---
>
> CONFIG_SURFACE_GPE:
>
> This driver marks the GPEs related to the ACPI lid device found on
> Microsoft Surface devices as wakeup sources and prepares them
> accordingly. It is required on those devices to allow wake-ups from
> suspend by opening the lid.
>
> Symbol: SURFACE_GPE [=n]
> Type : tristate
> Defined at drivers/platform/surface/Kconfig:43
> Prompt: Surface GPE/Lid Support Driver
> Depends on: SURFACE_PLATFORMS [=y] && ACPI [=y] && DMI [=y]
> Location:
> -> Device Drivers
> -> Microsoft Surface Platform-Specific Device Drivers (SURFACE_PLATFORMS
[=y])
>
> ---
>
> CONFIG_SURFACE_PLATFORMS:
>
> Say Y here to get to see options for platform-specific device drivers
> for Microsoft Surface devices. This option alone does not add any
> kernel code.
>
> If you say N, all options in this submenu will be skipped and disabled.
>
> Symbol: SURFACE_PLATFORMS [=y]
> Type : bool
> Defined at drivers/platform/surface/Kconfig:6
> Prompt: Microsoft Surface Platform-Specific Device Drivers
> Location:
> -> Device Drivers
>
> ---
>
> Cc: David Arcari <darcari(a)redhat.com>
> Cc: Mark Langsdorf <mlangsdo(a)redhat.com>
> Signed-off-by: Fedora Kernel Team <kernel-team(a)fedoraproject.org>
> ---
> redhat/configs/common/generic/CONFIG_AMD_PMC | 1 +
> .../common/generic/CONFIG_DELL_WMI_SYSMAN | 1 +
> .../common/generic/CONFIG_INTEL_PMT_CLASS | 1 +
> .../common/generic/CONFIG_INTEL_PMT_CRASHLOG | 1 +
> .../common/generic/CONFIG_INTEL_PMT_TELEMETRY | 1 +
> .../configs/common/generic/CONFIG_MLXBF_PMC | 1 +
> .../configs/common/generic/CONFIG_SURFACE_GPE | 1 +
> .../common/generic/CONFIG_SURFACE_PLATFORMS | 1 +
> .../pending-common/generic/CONFIG_AMD_PMC | 24 -----------------
> .../generic/CONFIG_DELL_WMI_SYSMAN | 21 ---------------
> .../generic/CONFIG_INTEL_PMT_CLASS | 26 -------------------
> .../generic/CONFIG_INTEL_PMT_CRASHLOG | 22 ----------------
> .../generic/CONFIG_INTEL_PMT_TELEMETRY | 22 ----------------
> .../pending-common/generic/CONFIG_MLXBF_PMC | 18 -------------
> .../pending-common/generic/CONFIG_SURFACE_GPE | 19 --------------
> .../generic/CONFIG_SURFACE_PLATFORMS | 18 -------------
> 16 files changed, 8 insertions(+), 170 deletions(-)
> create mode 100644 redhat/configs/common/generic/CONFIG_AMD_PMC
> create mode 100644 redhat/configs/common/generic/CONFIG_DELL_WMI_SYSMAN
> create mode 100644 redhat/configs/common/generic/CONFIG_INTEL_PMT_CLASS
> create mode 100644 redhat/configs/common/generic/CONFIG_INTEL_PMT_CRASHLOG
> create mode 100644 redhat/configs/common/generic/CONFIG_INTEL_PMT_TELEMETRY
> create mode 100644 redhat/configs/common/generic/CONFIG_MLXBF_PMC
> create mode 100644 redhat/configs/common/generic/CONFIG_SURFACE_GPE
> create mode 100644 redhat/configs/common/generic/CONFIG_SURFACE_PLATFORMS
> delete mode 100644 redhat/configs/pending-common/generic/CONFIG_AMD_PMC
> delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DELL_WMI_SYSMAN
> delete mode 100644 redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_CLASS
> delete mode 100644
redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_CRASHLOG
> delete mode 100644
redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_TELEMETRY
> delete mode 100644 redhat/configs/pending-common/generic/CONFIG_MLXBF_PMC
> delete mode 100644 redhat/configs/pending-common/generic/CONFIG_SURFACE_GPE
> delete mode 100644 redhat/configs/pending-common/generic/CONFIG_SURFACE_PLATFORMS
>
> diff --git a/redhat/configs/common/generic/CONFIG_AMD_PMC
b/redhat/configs/common/generic/CONFIG_AMD_PMC
> new file mode 100644
> index 000000000000..1ad2137c611f
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_AMD_PMC
> @@ -0,0 +1 @@
> +# CONFIG_AMD_PMC is not set
Also, I think this should probably be changed as well:
CONFIG_AMD_PMC=m
Thanks,
-DA
> diff --git a/redhat/configs/common/generic/CONFIG_DELL_WMI_SYSMAN
b/redhat/configs/common/generic/CONFIG_DELL_WMI_SYSMAN
> new file mode 100644
> index 000000000000..78afec9296de
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_DELL_WMI_SYSMAN
> @@ -0,0 +1 @@
> +# CONFIG_DELL_WMI_SYSMAN is not set
This needs to be changed to:
CONFIG_DELL_WMI_SYSMAN=m
I need to follow-up on the INTEL configs. Also, someone from the ARM team needs
to review the CONFIG_MLXBF_PM setting.
Thanks,
-DA
> diff --git a/redhat/configs/common/generic/CONFIG_INTEL_PMT_CLASS
b/redhat/configs/common/generic/CONFIG_INTEL_PMT_CLASS
> new file mode 100644
> index 000000000000..01c64e9357f7
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_INTEL_PMT_CLASS
> @@ -0,0 +1 @@
> +# CONFIG_INTEL_PMT_CLASS is not set
> diff --git a/redhat/configs/common/generic/CONFIG_INTEL_PMT_CRASHLOG
b/redhat/configs/common/generic/CONFIG_INTEL_PMT_CRASHLOG
> new file mode 100644
> index 000000000000..ab5099de078d
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_INTEL_PMT_CRASHLOG
> @@ -0,0 +1 @@
> +# CONFIG_INTEL_PMT_CRASHLOG is not set
> diff --git a/redhat/configs/common/generic/CONFIG_INTEL_PMT_TELEMETRY
b/redhat/configs/common/generic/CONFIG_INTEL_PMT_TELEMETRY
> new file mode 100644
> index 000000000000..161cc85d1659
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_INTEL_PMT_TELEMETRY
> @@ -0,0 +1 @@
> +# CONFIG_INTEL_PMT_TELEMETRY is not set
> diff --git a/redhat/configs/common/generic/CONFIG_MLXBF_PMC
b/redhat/configs/common/generic/CONFIG_MLXBF_PMC
> new file mode 100644
> index 000000000000..9867f83d0a38
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_MLXBF_PMC
> @@ -0,0 +1 @@
> +# CONFIG_MLXBF_PMC is not set
> diff --git a/redhat/configs/common/generic/CONFIG_SURFACE_GPE
b/redhat/configs/common/generic/CONFIG_SURFACE_GPE
> new file mode 100644
> index 000000000000..160153290de5
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_SURFACE_GPE
> @@ -0,0 +1 @@
> +# CONFIG_SURFACE_GPE is not set
> diff --git a/redhat/configs/common/generic/CONFIG_SURFACE_PLATFORMS
b/redhat/configs/common/generic/CONFIG_SURFACE_PLATFORMS
> new file mode 100644
> index 000000000000..4cc37929c7e5
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_SURFACE_PLATFORMS
> @@ -0,0 +1 @@
> +CONFIG_SURFACE_PLATFORMS=y
> diff --git a/redhat/configs/pending-common/generic/CONFIG_AMD_PMC
b/redhat/configs/pending-common/generic/CONFIG_AMD_PMC
> deleted file mode 100644
> index 5cb8adeceee1..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_AMD_PMC
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -# CONFIG_AMD_PMC:
> -#
> -# The driver provides support for AMD Power Management Controller
> -# primarily responsible for S2Idle transactions that are driven from
> -# a platform firmware running on SMU. This driver also provides a debug
> -# mechanism to investigate the S2Idle transactions and failures.
> -#
> -# Say Y or M here if you have a notebook powered by AMD RYZEN CPU/APU.
> -#
> -# If you choose to compile this driver as a module the module will be
> -# called amd-pmc.
> -#
> -# Symbol: AMD_PMC [=n]
> -# Type : tristate
> -# Defined at drivers/platform/x86/Kconfig:194
> -# Prompt: AMD SoC PMC driver
> -# Depends on: X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y]
&& PCI [=y]
> -# Location:
> -# -> Device Drivers
> -# -> X86 Platform Specific Device Drivers (X86_PLATFORM_DEVICES [=y])
> -#
> -#
> -#
> -# CONFIG_AMD_PMC is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_DELL_WMI_SYSMAN
b/redhat/configs/pending-common/generic/CONFIG_DELL_WMI_SYSMAN
> deleted file mode 100644
> index acb862441036..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_DELL_WMI_SYSMAN
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -# CONFIG_DELL_WMI_SYSMAN:
> -#
> -# This driver allows changing BIOS settings on many Dell machines from
> -# 2018 and newer without the use of any additional software.
> -#
> -# To compile this driver as a module, choose M here: the module will
> -# be called dell-wmi-sysman.
> -#
> -# Symbol: DELL_WMI_SYSMAN [=n]
> -# Type : tristate
> -# Defined at drivers/platform/x86/Kconfig:458
> -# Prompt: Dell WMI-based Systems management driver
> -# Depends on: X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI_WMI
[=m] && DMI [=y]
> -# Location:
> -# -> Device Drivers
> -# -> X86 Platform Specific Device Drivers (X86_PLATFORM_DEVICES [=y])
> -# Selects: NLS [=y]
> -#
> -#
> -#
> -# CONFIG_DELL_WMI_SYSMAN is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_CLASS
b/redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_CLASS
> deleted file mode 100644
> index a28076d3bfea..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_CLASS
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -# CONFIG_INTEL_PMT_CLASS:
> -#
> -# The Intel Platform Monitoring Technology (PMT) class driver provides
> -# the basic sysfs interface and file hierarchy uses by PMT devices.
> -#
> -# For more information, see:
> -# <file:Documentation/ABI/testing/sysfs-class-intel_pmt>
> -#
> -# To compile this driver as a module, choose M here: the module
> -# will be called intel_pmt_class.
> -#
> -# Symbol: INTEL_PMT_CLASS [=n]
> -# Type : tristate
> -# Defined at drivers/platform/x86/Kconfig:1371
> -# Prompt: Intel Platform Monitoring Technology (PMT) Class driver
> -# Depends on: X86 [=y] && X86_PLATFORM_DEVICES [=y]
> -# Location:
> -# -> Device Drivers
> -# -> X86 Platform Specific Device Drivers (X86_PLATFORM_DEVICES [=y])
> -# Selected by [n]:
> -# - INTEL_PMT_TELEMETRY [=n] && X86 [=y] && X86_PLATFORM_DEVICES
[=y]
> -# - INTEL_PMT_CRASHLOG [=n] && X86 [=y] && X86_PLATFORM_DEVICES
[=y]
> -#
> -#
> -#
> -# CONFIG_INTEL_PMT_CLASS is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_CRASHLOG
b/redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_CRASHLOG
> deleted file mode 100644
> index 5c68a9c8d25e..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_CRASHLOG
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -# CONFIG_INTEL_PMT_CRASHLOG:
> -#
> -# The Intel Platform Monitoring Technology (PMT) crashlog driver provides
> -# access to hardware crashlog capabilities on devices that support the
> -# feature.
> -#
> -# To compile this driver as a module, choose M here: the module
> -# will be called intel_pmt_crashlog.
> -#
> -# Symbol: INTEL_PMT_CRASHLOG [=n]
> -# Type : tristate
> -# Defined at drivers/platform/x86/Kconfig:1394
> -# Prompt: Intel Platform Monitoring Technology (PMT) Crashlog driver
> -# Depends on: X86 [=y] && X86_PLATFORM_DEVICES [=y]
> -# Location:
> -# -> Device Drivers
> -# -> X86 Platform Specific Device Drivers (X86_PLATFORM_DEVICES [=y])
> -# Selects: INTEL_PMT_CLASS [=n]
> -#
> -#
> -#
> -# CONFIG_INTEL_PMT_CRASHLOG is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_TELEMETRY
b/redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_TELEMETRY
> deleted file mode 100644
> index a215b2914774..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_INTEL_PMT_TELEMETRY
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -# CONFIG_INTEL_PMT_TELEMETRY:
> -#
> -# The Intel Platform Monitory Technology (PMT) Telemetry driver provides
> -# access to hardware telemetry metrics on devices that support the
> -# feature.
> -#
> -# To compile this driver as a module, choose M here: the module
> -# will be called intel_pmt_telemetry.
> -#
> -# Symbol: INTEL_PMT_TELEMETRY [=n]
> -# Type : tristate
> -# Defined at drivers/platform/x86/Kconfig:1383
> -# Prompt: Intel Platform Monitoring Technology (PMT) Telemetry driver
> -# Depends on: X86 [=y] && X86_PLATFORM_DEVICES [=y]
> -# Location:
> -# -> Device Drivers
> -# -> X86 Platform Specific Device Drivers (X86_PLATFORM_DEVICES [=y])
> -# Selects: INTEL_PMT_CLASS [=n]
> -#
> -#
> -#
> -# CONFIG_INTEL_PMT_TELEMETRY is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_MLXBF_PMC
b/redhat/configs/pending-common/generic/CONFIG_MLXBF_PMC
> deleted file mode 100644
> index 26e293f5fec0..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_MLXBF_PMC
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -# CONFIG_MLXBF_PMC:
> -#
> -# Say y here to enable PMC support. The PMC driver provides access
> -# to performance monitoring counters within various blocks in the
> -# Mellanox BlueField SoC via a sysfs interface.
> -#
> -# Symbol: MLXBF_PMC [=n]
> -# Type : tristate
> -# Defined at drivers/platform/mellanox/Kconfig:59
> -# Prompt: Mellanox BlueField Performance Monitoring Counters driver
> -# Depends on: MELLANOX_PLATFORM [=y] && ARM64 [=y] && HWMON [=y]
&& ACPI [=y]
> -# Location:
> -# -> Device Drivers
> -# -> Platform support for Mellanox hardware (MELLANOX_PLATFORM [=y])
> -#
> -#
> -#
> -# CONFIG_MLXBF_PMC is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_SURFACE_GPE
b/redhat/configs/pending-common/generic/CONFIG_SURFACE_GPE
> deleted file mode 100644
> index a4c070efd2c2..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_SURFACE_GPE
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -# CONFIG_SURFACE_GPE:
> -#
> -# This driver marks the GPEs related to the ACPI lid device found on
> -# Microsoft Surface devices as wakeup sources and prepares them
> -# accordingly. It is required on those devices to allow wake-ups from
> -# suspend by opening the lid.
> -#
> -# Symbol: SURFACE_GPE [=n]
> -# Type : tristate
> -# Defined at drivers/platform/surface/Kconfig:43
> -# Prompt: Surface GPE/Lid Support Driver
> -# Depends on: SURFACE_PLATFORMS [=y] && ACPI [=y] && DMI [=y]
> -# Location:
> -# -> Device Drivers
> -# -> Microsoft Surface Platform-Specific Device Drivers (SURFACE_PLATFORMS
[=y])
> -#
> -#
> -#
> -# CONFIG_SURFACE_GPE is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_SURFACE_PLATFORMS
b/redhat/configs/pending-common/generic/CONFIG_SURFACE_PLATFORMS
> deleted file mode 100644
> index d2823d1aac40..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_SURFACE_PLATFORMS
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -# CONFIG_SURFACE_PLATFORMS:
> -#
> -# Say Y here to get to see options for platform-specific device drivers
> -# for Microsoft Surface devices. This option alone does not add any
> -# kernel code.
> -#
> -# If you say N, all options in this submenu will be skipped and disabled.
> -#
> -# Symbol: SURFACE_PLATFORMS [=y]
> -# Type : bool
> -# Defined at drivers/platform/surface/Kconfig:6
> -# Prompt: Microsoft Surface Platform-Specific Device Drivers
> -# Location:
> -# -> Device Drivers
> -#
> -#
> -#
> -CONFIG_SURFACE_PLATFORMS=y
>