On Tue, May 12, 2020 at 1:50 AM Thorsten Leemhuis <fedora(a)leemhuis.info> wrote:
Am 11.05.20 um 20:20 schrieb Don Zickus:
> On Mon, May 11, 2020 at 09:52:43AM -0700, stan wrote:
>> On Mon, 11 May 2020 09:44:54 -0700
>> stan <upaitag(a)zoho.com> wrote:
>> arch/x86/kernel/setup.c:820:13: warning: 'rh_check_supported' defined
but not used [-Wunused-function]
>> 820 | static void rh_check_supported(void)
>> | ^~~~~~~~~~~~~~~~~~
> Odd, the ELN build didn't fail for that reason.
> In theory, an ELN build should have failed, someone noticed it was related
> to a specific RH patch, we revert it temporarily until it is fixed and then
> re-apply. Still some kinks.
While at it: I noticed the number of patches that are applied to the
kernel sources went up from nearly 40 to about 75 with the kernel-ark
transition. Among those 35 additional patches are afaics quite a few
that are really specific to RHEL (like the one that caused this) and not
needed for Fedora apart from the ELN. The one that caused this afaics is
one of them.
Is that intentional or just something that will get cleaned up?
Actually, the number of patches has not changed so much as the number
of files containing those patches has. A number of patch files
included a series, but because we are plucking the patches
individually from git, they got broken out. For instance, the current
efi-secureboot patch on F32 contains 3 different patches. In total,
Fedora 32 carries 84 actual patches right now in 41 patch files.
Breaking them out individually also makes it much easier when say 1
patch from a series got pulled in, or needs to be rebased.
Side note: What's up with the "Upstream Status: RHEL only" in the commit
messages? They could help differentiating Fedora and ELN/RHEL specific
patches, but that tag is present in some patches that afaics are needed
for Fedora (like
I have complained about the name, and it will hopefully change at some
point. RHEL only as an upstream status is actually Red Hat only,
meaning we are unsure as to when it will make it upstream. Fedora
patches get tagged with that as well.