From: Scott Weaver scweaver@redhat.com
kernel.spec: add llvm-devel build requirement
The bpftool and the llvm system feature check requires the llvm-devel package. The bpftool package is only created if selftests is defined and when selftests is enabled, then samples/bpf will be built which will use the llvm feature check. Therefore the llvm-devel package is added as a build requirement of selftests to keep it consistent with the llvm package already specified there.
A dependency of the llvm-devel package is llvm so we no longer need to specify this package explicitly.
This change came in eb9d1acf634ba ('bpftool: Add LLVM as default library for disassembling JIT-ed programs').
Signed-off-by: Scott Weaver scweaver@redhat.com
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -635,7 +635,7 @@ BuildRequires: python3-docutils BuildRequires: zlib-devel binutils-devel %endif %if %{with_selftests} -BuildRequires: clang llvm fuse-devel +BuildRequires: clang llvm-devel fuse-devel %ifnarch %{arm} BuildRequires: numactl-devel %endif
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2264
On 1/31/23 09:13, Scott Weaver (via Email Bridge) wrote:
From: Scott Weaver scweaver@redhat.com
kernel.spec: add llvm-devel build requirement
The bpftool and the llvm system feature check requires the llvm-devel package. The bpftool package is only created if selftests is defined and when selftests is enabled, then samples/bpf will be built which will use the llvm feature check. Therefore the llvm-devel package is added as a build requirement of selftests to keep it consistent with the llvm package already specified there.
Would you be able to point me to the code for the LLVM feature check that requires llvm-devel? I just want to understand what it's doing, so we don't break it accidentally.
-Tom
A dependency of the llvm-devel package is llvm so we no longer need to specify this package explicitly.
This change came in eb9d1acf634ba ('bpftool: Add LLVM as default library for disassembling JIT-ed programs').
Signed-off-by: Scott Weaver scweaver@redhat.com
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -635,7 +635,7 @@ BuildRequires: python3-docutils BuildRequires: zlib-devel binutils-devel %endif %if %{with_selftests} -BuildRequires: clang llvm fuse-devel +BuildRequires: clang llvm-devel fuse-devel %ifnarch %{arm} BuildRequires: numactl-devel %endif
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2264 _______________________________________________ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
From: Scott Weaver on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2264#note_1263931...
Hi Tom,
When the feature check fails to build the file `tools/build/feature/test- llvm.make.output` will be generated which will show the error.
``` test-llvm.cpp:2:10: fatal error: llvm/Support/ManagedStatic.h: No such file or directory 2 | #include "llvm/Support/ManagedStatic.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. ```
On 2/2/23 13:32, Scott Weaver (via Email Bridge) wrote:
From: Scott Weaver on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2264#note_1263931...
Hi Tom,
When the feature check fails to build the file `tools/build/feature/test- llvm.make.output` will be generated which will show the error.
test-llvm.cpp:2:10: fatal error: llvm/Support/ManagedStatic.h: No such file or directory 2 | #include "llvm/Support/ManagedStatic.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.
OK, thank you. This was helpful.
kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
kernel@lists.fedoraproject.org
-
Scott Weaver (via Email Bridge) -
Tom Stellard