From: Jiri Olsa on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155 NOTE: Truncated patchset since committer email 'jolsa@kernel.org' does not match the submitter's GitLab public email address 'jolsa@redhat.com'. Adding missing commits from rhel8 and enable bpf selftests (from @jbencrh)
BPF selftest will at the moment fail to build (need clang 13), but rpm build will still try to build and install them.
--- redhat/configs/ark/debug/CONFIG_PAGE_EXTENSION | 1 - redhat/configs/common/generic/s390x/zfcpdump/CONFIG_PAGE_EXTENSION | 1 + redhat/configs/common/generic/s390x/zfcpdump/CONFIG_PAGE_OWNER | 1 + redhat/configs/common/generic/CONFIG_PAGE_EXTENSION | 2 +- redhat/configs/common/generic/CONFIG_PAGE_OWNER | 2 +- redhat/Makefile | 3 +- redhat/kernel.spec.template | 124 ++++++++- redhat/kvm_stat.logrotate | 11 + 8 files changed, 117 insertions(+), 28 deletions(-)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155#note_5858456...
@jolsa1 - hmm how to move this forward? I am going to request feedback below???
@jmflinuxtx - can we apply a 'Include in Releases' tag for a build or two? I am curious to see if this even compiles and installs with all the changes in the subpackages.
@jbencrh - I assume you are ok with these changes because half the commits are yours? @raquini - are you ok with the CONFIG_PAGE_OWNER change? @herton - any concerns here?
I am ok with most of this as it comes from RHEL-8. It is just a bunch of little fixes.
Any other reviewer that should verify this?
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155#note_5858712...
I added the tag, so it should be in tomorrow's build. Not really happy with an additional 76 lines to the spec, but I don't see another way.
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155#note_5859073...
I see RHEL8 has the same change. But this is missing "-n" argument to %package. So the package generated will be: kernel-kernel-kabidw-base-internal
Doesn't seem this is intended.
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155#note_5859215...
Took a look and looks good. Just commented below on something I noticed. Not sure if we want to fix that here or with a followup MR, since rhel8 already has the same issue.
From: Jiri Olsa on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155#note_5865479...
@dzickusrh I wasn't exactly sure how to handle this ;-) I'll check and include more reviewers
From: Jiri Olsa on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155#note_5865482...
did not notice that in the build, will check, thanks
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155#note_5952062...
How is it going?
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155#note_5954885...
We have been building with it here since rc4.
From: Jiri Olsa on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155#note_5969567...
I might have another fix for selftests that I'm testing now, will push shortly
From: Rafael Aquini on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155#note_6007922...
Acked-by: Rafael Aquini aquini@redhat.com (via approve button)
From: Rafael Aquini on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1155#note_6007929...
@raquini - are you ok with the CONFIG_PAGE_OWNER change? ACK
kernel@lists.fedoraproject.org