From: Scott Weaver scweaver@redhat.com
kernel.spec: add llvm-devel build requirement
The bpftool and selftests feature check requires the llvm-devel package as well as the bpftool itself (if llvm is available). The bpftool package is only created if selftests is defined, therefore the llvm-devel package is added as a build requirement of selftests to keep it consistent with the llvm package already specified.
This change came in eb9d1acf634ba ('bpftool: Add LLVM as default library for disassembling JIT-ed programs').
Signed-off-by: Scott Weaver scweaver@redhat.com
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -635,7 +635,7 @@ BuildRequires: python3-docutils BuildRequires: zlib-devel binutils-devel %endif %if %{with_selftests} -BuildRequires: clang llvm fuse-devel +BuildRequires: clang llvm llvm-devel fuse-devel %ifnarch %{arm} BuildRequires: numactl-devel %endif
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2264
On 1/24/23 08:28, Scott Weaver (via Email Bridge) wrote:
From: Scott Weaver scweaver@redhat.com
kernel.spec: add llvm-devel build requirement
The bpftool and selftests feature check requires the llvm-devel package as well as the bpftool itself (if llvm is available). The bpftool package is only created if selftests is defined, therefore the llvm-devel package is added as a build requirement of selftests to keep it consistent with the llvm package already specified.
This change came in eb9d1acf634ba ('bpftool: Add LLVM as default library for disassembling JIT-ed programs').
So does this mean that the selftest is now building code that links against libLLVM.so ?
-Tom
Signed-off-by: Scott Weaver scweaver@redhat.com
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -635,7 +635,7 @@ BuildRequires: python3-docutils BuildRequires: zlib-devel binutils-devel %endif %if %{with_selftests} -BuildRequires: clang llvm fuse-devel +BuildRequires: clang llvm llvm-devel fuse-devel %ifnarch %{arm} BuildRequires: numactl-devel %endif
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2264 _______________________________________________ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
From: Scott Weaver on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2264#note_1251412...
Hi Tom. I don't believe selftests is linking. The reason I included it in the BuildRequires for selftests is that I thought that selftests was running the systems feature check that included llvm. (The feature check for llvm (`tools/build/feature/test-llvm.cpp`) requires headers from the llvm-devel package.) But after taking a another look, I was wrong, I don't believe selftests is running the system feature check. I'll make the change and include this package only for bpftool.
kernel@lists.fedoraproject.org
-
Scott Weaver (via Email Bridge) -
Tom Stellard