From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
---
Cc: Al Stone ahs3@redhat.com Cc: Lenny Szubowicz lszubowi@redhat.com Cc: Prarit Bhargava prarit@redhat.com Cc: David Arcari darcari@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- redhat/configs/common/generic/CONFIG_ACPI_TABLE_UPGRADE | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_ACPI_TABLE_UPGRADE
diff --git a/redhat/configs/common/generic/CONFIG_ACPI_TABLE_UPGRADE b/redhat/configs/common/generic/CONFIG_ACPI_TABLE_UPGRADE new file mode 100644 index 000000000000..e69de29bb2d1
On 11/19/20 7:56 AM, GitLab Bridge on behalf of jeremycline wrote:
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
jforbes, did something mis-fire here? The patch is empty.
P.
Cc: Al Stone ahs3@redhat.com Cc: Lenny Szubowicz lszubowi@redhat.com Cc: Prarit Bhargava prarit@redhat.com Cc: David Arcari darcari@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
redhat/configs/common/generic/CONFIG_ACPI_TABLE_UPGRADE | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_ACPI_TABLE_UPGRADE
diff --git a/redhat/configs/common/generic/CONFIG_ACPI_TABLE_UPGRADE b/redhat/configs/common/generic/CONFIG_ACPI_TABLE_UPGRADE new file mode 100644 index 000000000000..e69de29bb2d1
On Thu, Nov 19, 2020 at 8:00 AM Prarit Bhargava prarit@redhat.com wrote:
On 11/19/20 7:56 AM, GitLab Bridge on behalf of jeremycline wrote:
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
jforbes, did something mis-fire here? The patch is empty.
This is already set in configs/ark/generic. It was not in Fedora because a dependent option was turned off. When I turned it on yesterday, it added the Fedora pending last night, but it should not have created an MR. So yes, it is a misfire, but I am guessing it is a script bug. If I had to guess, the script checks configs/common, but not configs/ark. The empty is created because there is no default to change it to as the option is already set.
Justin
On 19 Nov 2020 09:44, Justin Forbes wrote:
On Thu, Nov 19, 2020 at 8:00 AM Prarit Bhargava prarit@redhat.com wrote:
On 11/19/20 7:56 AM, GitLab Bridge on behalf of jeremycline wrote:
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
jforbes, did something mis-fire here? The patch is empty.
This is already set in configs/ark/generic. It was not in Fedora because a dependent option was turned off. When I turned it on yesterday, it added the Fedora pending last night, but it should not have created an MR. So yes, it is a misfire, but I am guessing it is a script bug. If I had to guess, the script checks configs/common, but not configs/ark. The empty is created because there is no default to change it to as the option is already set.
Justin
Whew. I was confused, too. I thought this was implying that just having a file present in configs/ meant the same as an =y. Clever, but a bit ambiguous.
Thanks for the explanation. This should indeed be =y, just the same, per the conversation with Hans et al.
kernel@lists.fedoraproject.org
-
Al Stone -
GitLab Bridge on behalf of jeremycline -
Justin Forbes -
Prarit Bhargava