From: Desnes Nunes desnesn@redhat.com
usb: enable Design Ware Drivers on x86
Upstream Status: RHEL-only
RHEL only: driver is used and updated by Intel.
Signed-off-by: Desnes Nunes desnesn@redhat.com
diff --git a/redhat/configs/rhel/generic/x86/CONFIG_PHY_SAMSUNG_USB2 b/redhat/configs/rhel/generic/x86/CONFIG_PHY_SAMSUNG_USB2 new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/x86/CONFIG_PHY_SAMSUNG_USB2 @@ -0,0 +1 @@ +# CONFIG_PHY_SAMSUNG_USB2 is not set diff --git a/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2 b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2 new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2 @@ -0,0 +1 @@ +CONFIG_USB_DWC2=m diff --git a/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_DEBUG b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_DEBUG new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_DEBUG @@ -0,0 +1 @@ +# CONFIG_USB_DWC2_DEBUG is not set diff --git a/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_HOST b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_HOST new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_HOST @@ -0,0 +1 @@ +CONFIG_USB_DWC2_HOST=y diff --git a/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_PCI b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_PCI new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_PCI @@ -0,0 +1 @@ +# CONFIG_USB_DWC2_PCI is not set diff --git a/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_TRACK_MISSED_SOFS b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_TRACK_MISSED_SOFS new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC2_TRACK_MISSED_SOFS @@ -0,0 +1 @@ +# CONFIG_USB_DWC2_TRACK_MISSED_SOFS is not set diff --git a/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3 b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3 new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3 @@ -0,0 +1 @@ +CONFIG_USB_DWC3=m diff --git a/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3_HAPS b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3_HAPS new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3_HAPS @@ -0,0 +1 @@ +CONFIG_USB_DWC3_HAPS=m diff --git a/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3_HOST b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3_HOST new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3_HOST @@ -0,0 +1 @@ +CONFIG_USB_DWC3_HOST=y diff --git a/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3_PCI b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3_PCI new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/x86/CONFIG_USB_DWC3_PCI @@ -0,0 +1 @@ +CONFIG_USB_DWC3_PCI=m diff --git a/redhat/configs/rhel/generic/x86/CONFIG_USB_XHCI_PLATFORM b/redhat/configs/rhel/generic/x86/CONFIG_USB_XHCI_PLATFORM new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/x86/CONFIG_USB_XHCI_PLATFORM @@ -0,0 +1 @@ +CONFIG_USB_XHCI_PLATFORM=m
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2334
From: Hans de Goede on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2334#note_1296748...
Interesting I actually have enabling dwc3 gadget mode support in Fedora:
CONFIG_USB_DWC3=m CONFIG_USB_DWC3_ULPI=y # CONFIG_USB_DWC3_HOST is not set CONFIG_USB_DWC3_GADGET=y
On my personal to do list, because a lot of the Bay Trail / Cherry Trail x86 tablets which I work on supporting as a side project can be used in USB gadget / device-mode with this enabled; and in some exotic cases require CONFIG_USB_DWC3_GADGET for charger-type detection to allow charging with 5V/2A from USB chargers.
I am a bit surprised to see DWC2 also being enabled here though. And also I find it a bit weird this is being used in host-modes. AFAIK only quite old Intel tablet/phone SoCs relied on the DWC3 to do host modes. Typically there is a dedicated xHCI controller for host mode + a mux. And using the xHCI controller is much much better. But I guess this may be for some SoC which I'm unfamiliar with ?
I don't see any details or rationale why this is needed in: https://bugzilla.redhat.com/show_bug.cgi?id=2110796
I would really expect some more motivation for a request like this, independent of my specific interest in this change. It would be nice if e.g. the commit message could contain more details about *why* this is actually being done / for which use-cases. Or if that is confidential at least at that to the bugzilla and add the link to the bugzilla the commit message ?
From: Desnes Nunes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2334#note_1297387...
Hello Hans,
Thanks for the heads up and just replied at: https://bugzilla.redhat.com/show_bug.cgi?id=2110796#c6
Please let me know if you have furthers questions
Best Regards,
From: Hans de Goede on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2334#note_1297542...
As discussed in bugzilla I'm fine with moving forward with this as is.
From: Desnes Nunes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2334#note_1299624...
Thanks for all observations Hans!
From: Desnes Nunes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2334#note_1300671...
As per discussion on https://bugzilla.redhat.com/show_bug.cgi?id=2110796#c11 , closing the MR.
Thanks for all observations @jwrdegoede
kernel@lists.fedoraproject.org
-
Desnes Nunes (via Email Bridge) -
Hans de Goede (via Email Bridge)