From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_USB_RTL8153_ECM:
This option supports ECM mode for RTL8153 ethernet adapter, when CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not supported by r8152 driver.
Symbol: USB_RTL8153_ECM [=m] Type : tristate Defined at drivers/net/usb/Kconfig:631 Prompt: RTL8153 ECM support Depends on: NETDEVICES [=y] && USB_NET_DRIVERS [=y] && USB_NET_CDCETHER [=m] && (USB_RTL8152 [=m] || USB_RTL8152 [=m]=n) Location: -> Device Drivers -> Network device support (NETDEVICES [=y]) -> USB Network Adapters (USB_NET_DRIVERS [=y])
---
Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- .../common/generic/CONFIG_USB_RTL8153_ECM | 1 + .../generic/CONFIG_USB_RTL8153_ECM | 19 ------------------- 2 files changed, 1 insertion(+), 19 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_USB_RTL8153_ECM delete mode 100644 redhat/configs/pending-common/generic/CONFIG_USB_RTL8153_ECM
diff --git a/redhat/configs/common/generic/CONFIG_USB_RTL8153_ECM b/redhat/configs/common/generic/CONFIG_USB_RTL8153_ECM new file mode 100644 index 000000000000..3ec37682be5c --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_USB_RTL8153_ECM @@ -0,0 +1 @@ +CONFIG_USB_RTL8153_ECM=m diff --git a/redhat/configs/pending-common/generic/CONFIG_USB_RTL8153_ECM b/redhat/configs/pending-common/generic/CONFIG_USB_RTL8153_ECM deleted file mode 100644 index 2aac1c66d354..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_USB_RTL8153_ECM +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_USB_RTL8153_ECM: -# -# This option supports ECM mode for RTL8153 ethernet adapter, when -# CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not -# supported by r8152 driver. -# -# Symbol: USB_RTL8153_ECM [=m] -# Type : tristate -# Defined at drivers/net/usb/Kconfig:631 -# Prompt: RTL8153 ECM support -# Depends on: NETDEVICES [=y] && USB_NET_DRIVERS [=y] && USB_NET_CDCETHER [=m] && (USB_RTL8152 [=m] || USB_RTL8152 [=m]=n) -# Location: -# -> Device Drivers -# -> Network device support (NETDEVICES [=y]) -# -> USB Network Adapters (USB_NET_DRIVERS [=y]) -# -# -# -CONFIG_USB_RTL8153_ECM=m
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/805#note_60555598...
@jmflinuxtx @prarit - this config is 'unreviewed' and we are at -rc7. I would like to take the default and move on. However, in this case the default is '=m' and not 'is not set'. It seems this should be disabled? Thoughts?
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/805#note_60557329...
@dzickusrh It defaults that way because it depends on similar drivers. We have CONFIG_USB_RTL8152 as 'm' and USB_NET_DRIVERS on, so I believe the default is correct here. This just supports some additional 8153 devices that are not covered under the 8152 driver.
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/805#note_60557335...
Acked-by: Justin M. Forbes jforbes@fedoraproject.org (via approve button)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/805#note_60578077...
Acked-by: Patrick Talbert ptalbert@redhat.com (via approve button)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/805#note_60591979...
Acked-by: Patrick Talbert ptalbert@redhat.com (via approve button)
kernel@lists.fedoraproject.org