From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_WATCH_QUEUE:
This is a general notification queue for the kernel to pass events to userspace by splicing them into pipes. It can be used in conjunction with watches for key/keyring change notifications and device notifications.
See Documentation/watch_queue.rst
Symbol: WATCH_QUEUE [=n] Type : bool Defined at init/Kconfig:370 Prompt: General notification queue Location: -> General setup
---
Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- .../configs/common/generic/CONFIG_WATCH_QUEUE | 1 + .../pending-common/generic/CONFIG_WATCH_QUEUE | 20 ------------------- 2 files changed, 1 insertion(+), 20 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_WATCH_QUEUE delete mode 100644 redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE
diff --git a/redhat/configs/common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE new file mode 100644 index 000000000000..4e2060b85ff3 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE @@ -0,0 +1 @@ +# CONFIG_WATCH_QUEUE is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE deleted file mode 100644 index 11707e6429cb..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_WATCH_QUEUE: -# -# -# This is a general notification queue for the kernel to pass events to -# userspace by splicing them into pipes. It can be used in conjunction -# with watches for key/keyring change notifications and device -# notifications. -# -# See Documentation/watch_queue.rst -# -# Symbol: WATCH_QUEUE [=n] -# Type : bool -# Defined at init/Kconfig:370 -# Prompt: General notification queue -# Location: -# -> General setup -# -# -# -# CONFIG_WATCH_QUEUE is not set
On 6/14/20 12:42 AM, GitLab Bridge on behalf of jeremycline wrote:
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_WATCH_QUEUE:
This is a general notification queue for the kernel to pass events to userspace by splicing them into pipes. It can be used in conjunction with watches for key/keyring change notifications and device notifications.
See Documentation/watch_queue.rst
Symbol: WATCH_QUEUE [=n] Type : bool Defined at init/Kconfig:370 Prompt: General notification queue Location: -> General setup
We want this =y.
Nacked-by: Prarit Bhargava prarit@redhat.com
Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
.../configs/common/generic/CONFIG_WATCH_QUEUE | 1 + .../pending-common/generic/CONFIG_WATCH_QUEUE | 20 ------------------- 2 files changed, 1 insertion(+), 20 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_WATCH_QUEUE delete mode 100644 redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE
diff --git a/redhat/configs/common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE new file mode 100644 index 000000000000..4e2060b85ff3 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE @@ -0,0 +1 @@ +# CONFIG_WATCH_QUEUE is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE deleted file mode 100644 index 11707e6429cb..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_WATCH_QUEUE: -# -# -# This is a general notification queue for the kernel to pass events to -# userspace by splicing them into pipes. It can be used in conjunction -# with watches for key/keyring change notifications and device -# notifications. -# -# See Documentation/watch_queue.rst -# -# Symbol: WATCH_QUEUE [=n] -# Type : bool -# Defined at init/Kconfig:370 -# Prompt: General notification queue -# Location: -# -> General setup -# -# -# -# CONFIG_WATCH_QUEUE is not set
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_WATCH_QUEUE:
This is a general notification queue for the kernel to pass events to userspace by splicing them into pipes. It can be used in conjunction with watches for key/keyring change notifications and device notifications.
See Documentation/watch_queue.rst
Symbol: WATCH_QUEUE [=n] Type : bool Defined at init/Kconfig:370 Prompt: General notification queue Location: -> General setup
Cc: Prarit Bhargava prarit@redhat.com --- .../configs/common/generic/CONFIG_WATCH_QUEUE | 1 + .../pending-common/generic/CONFIG_WATCH_QUEUE | 20 ------------------- 2 files changed, 1 insertion(+), 20 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_WATCH_QUEUE delete mode 100644 redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE
diff --git a/redhat/configs/common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE new file mode 100644 index 000000000000..4e2060b85ff3 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE @@ -0,0 +1 @@ +# CONFIG_WATCH_QUEUE is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE deleted file mode 100644 index 11707e6429cb..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_WATCH_QUEUE: -# -# -# This is a general notification queue for the kernel to pass events to -# userspace by splicing them into pipes. It can be used in conjunction -# with watches for key/keyring change notifications and device -# notifications. -# -# See Documentation/watch_queue.rst -# -# Symbol: WATCH_QUEUE [=n] -# Type : bool -# Defined at init/Kconfig:370 -# Prompt: General notification queue -# Location: -# -> General setup -# -# -# -# CONFIG_WATCH_QUEUE is not set
From: Jeremy Cline on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/462
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_WATCH_QUEUE:
This is a general notification queue for the kernel to pass events to userspace by splicing them into pipes. It can be used in conjunction with watches for key/keyring change notifications and device notifications.
See Documentation/watch_queue.rst
Symbol: WATCH_QUEUE [=n] Type : bool Defined at init/Kconfig:370 Prompt: General notification queue Location: -> General setup
---
Cc: Prarit Bhargava prarit@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
From: Fedora Kernel Team kernel-team@fedoraproject.org
New configs in init/Kconfig
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_WATCH_QUEUE:
This is a general notification queue for the kernel to pass events to userspace by splicing them into pipes. It can be used in conjunction with watches for key/keyring change notifications and device notifications.
See Documentation/watch_queue.rst
Symbol: WATCH_QUEUE [=n] Type : bool Defined at init/Kconfig:370 Prompt: General notification queue Location: -> General setup
Cc: Prarit Bhargava prarit@redhat.com
diff a/redhat/configs/common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE @@ -0,0 +1 @@ +# CONFIG_WATCH_QUEUE is not set diff a/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE --- a/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_WATCH_QUEUE: -# -# -# This is a general notification queue for the kernel to pass events to -# userspace by splicing them into pipes. It can be used in conjunction -# with watches for key/keyring change notifications and device -# notifications. -# -# See Documentation/watch_queue.rst -# -# Symbol: WATCH_QUEUE [=n] -# Type : bool -# Defined at init/Kconfig:370 -# Prompt: General notification queue -# Location: -# -> General setup -# -# -# -# CONFIG_WATCH_QUEUE is not set
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/462
From: Patrick Talbert ptalbert@redhat.com
Update CONFIG_WATCH_QUEUE diff a/redhat/configs/common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE --- a/redhat/configs/common/generic/CONFIG_WATCH_QUEUE +++ b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE @@ -1 +1 @@ -# CONFIG_WATCH_QUEUE is not set +CONFIG_WATCH_QUEUE=y
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/462
From: CKI Admin Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/462#note_49414438...
Hi! This is the friendly CKI test bot.
It appears that you are not a member of redhat/red-hat-ci- tools/kernel/cki-runs/trusted-pipelines. This means that the CI pipeline on your MR will fail. As getting testing is important, I'll be responsible for testing your changes. After every MR change, I'll start a small testing pipeline and link it here so you can follow the results. I'll also create and link a pipeline for hardware testing that the reviewers can start to get extra test coverage.
From: CKI Admin Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/462#note_49414450...
Testing pipeline status: Basic testing pipeline:
https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki- runs/external-pipelines/-/pipelines/246972903 - created :hourglass_flowing_sand:
From: Jeremy Cline on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/462
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_WATCH_QUEUE:
This is a general notification queue for the kernel to pass events to userspace by splicing them into pipes. It can be used in conjunction with watches for key/keyring change notifications and device notifications.
See Documentation/watch_queue.rst
Symbol: WATCH_QUEUE [=n] Type : bool Defined at init/Kconfig:370 Prompt: General notification queue Location: -> General setup
---
Cc: Prarit Bhargava prarit@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
From: Fedora Kernel Team kernel-team@fedoraproject.org
New configs in init/Kconfig
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_WATCH_QUEUE:
This is a general notification queue for the kernel to pass events to userspace by splicing them into pipes. It can be used in conjunction with watches for key/keyring change notifications and device notifications.
See Documentation/watch_queue.rst
Symbol: WATCH_QUEUE [=n] Type : bool Defined at init/Kconfig:370 Prompt: General notification queue Location: -> General setup
Cc: Prarit Bhargava prarit@redhat.com
diff a/redhat/configs/common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE @@ -0,0 +1 @@ +# CONFIG_WATCH_QUEUE is not set diff a/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE --- a/redhat/configs/pending-common/generic/CONFIG_WATCH_QUEUE +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_WATCH_QUEUE: -# -# -# This is a general notification queue for the kernel to pass events to -# userspace by splicing them into pipes. It can be used in conjunction -# with watches for key/keyring change notifications and device -# notifications. -# -# See Documentation/watch_queue.rst -# -# Symbol: WATCH_QUEUE [=n] -# Type : bool -# Defined at init/Kconfig:370 -# Prompt: General notification queue -# Location: -# -> General setup -# -# -# -# CONFIG_WATCH_QUEUE is not set
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/462
From: Patrick Talbert ptalbert@redhat.com
Update CONFIG_WATCH_QUEUE
diff a/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS b/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS @@ -0,0 +1 @@ +CONFIG_KEY_NOTIFICATIONS=y diff a/redhat/configs/common/generic/CONFIG_WATCH_QUEUE b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE --- a/redhat/configs/common/generic/CONFIG_WATCH_QUEUE +++ b/redhat/configs/common/generic/CONFIG_WATCH_QUEUE @@ -1 +1 @@ -# CONFIG_WATCH_QUEUE is not set +CONFIG_WATCH_QUEUE=y diff a/redhat/configs/fedora/generic/CONFIG_KEY_NOTIFICATIONS b/redhat/configs/fedora/generic/CONFIG_KEY_NOTIFICATIONS --- a/redhat/configs/fedora/generic/CONFIG_KEY_NOTIFICATIONS +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_KEY_NOTIFICATIONS: -# -# This option provides support for getting change notifications on keys -# and keyrings on which the caller has View permission. This makes use -# of the /dev/watch_queue misc device to handle the notification -# buffer and provides KEYCTL_WATCH_KEY to enable/disable watches. -# -# Symbol: KEY_NOTIFICATIONS [=n] -# Type : bool -# Defined at security/keys/Kconfig:118 -# Prompt: Provide key/keyring change notifications -# Depends on: KEYS [=y] && WATCH_QUEUE [=y] -# Location: -# -> Security options -# -> Enable access key retention support (KEYS [=y]) -# -# -# -CONFIG_KEY_NOTIFICATIONS=y
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/462
From: CKI Admin Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/462#note_49416966...
Testing pipeline status: Basic testing pipeline:
https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki- runs/external-pipelines/-/pipelines/246988591 - created :hourglass_flowing_sand:
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/462#note_49419129...
Hey Prarit,
I've updated the MR to reflect your input.
Note I also enabled CONFIG_KEY_NOTIFICATIONS as it must be set now that CONFIG_WATCH_QUEUE is enabled. Let me know if we'd rather CONFIG_KEY_NOTIFICATIONS be off.
Thank you,
Patrick
From: Ondrej Mosnáček on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/462#note_53517973...
We have a test in the selinux-testsuite that is failing on this and I believe it's reasonable to enable this, so...
Acked-by: Ondrej Mosnacek omosnace@redhat.com
kernel@lists.fedoraproject.org