Hi,
On 3/3/20 4:23 PM, Jeremy Cline wrote:
On Tue, 2020-03-03 at 16:09 +0100, Hans de Goede wrote:
> Hi,
>
> On 3/3/20 3:29 PM, Peter Robinson wrote:
>>>>>> Yes you are right, it should probably be something like the
>>>>>> following:
>>>>>>
>>>>>> %ifarch x86_64
>>>>>> Requires: alsa-sof-firmware
>>>>>> %endif
>>>>>>
>>>>>> (untested)
>>>>>
>>>>> Does anyone know, how the iwl*-firmware files are installed?
>>>>> I cannot find any
>>>>> dependency in kernel nor linux-firmware rpms. It's similar.
>>>>
>>>> It's done via comps.
>>>
>>> Hmm that does not really help here as the mean case we are trying
>>> to
>>> fix is F31 users upgrading from kernel 5.4 to 5.5.
>
> So thinking more about this, I guess we should only add the explicit
> requires to the kernel package for F31 (and F30) and add it to comps
> for F32+, this way F30 / F31 users will get the package through
> the requires (and keep it on upgrade to F32+) and fresh F32 installs
> will also get it this way.
>
> And this way we do not have to live forever with a Requires which
> will
> cause issues for efforts to make minimal installs as small as
> possible.
I think if we use Recommends dnf will install it by default, but it's
not a dependency error if it's not installed[0].
[0]
https://rpm.org/user_doc/dependencies.html
Right, that will work too and indeed is a better idea, at least for F30 + F31.
The question is what do we want to do for F32+ ?
1. Add alsa-sof-firmware to comps, similar to how iwlwifi is handled
2. Use the same Recommends as we are doing for F30 + F31 ?
I would personally prefer 2, but then we should probably consider
doing the same for iwlwifi for consistency.
Regards,
Hans