On Mon, Nov 2, 2020 at 10:46 AM Justin Forbes <jforbes(a)fedoraproject.org> wrote:
On Mon, Nov 2, 2020 at 3:04 AM Jiri Benc <jbenc(a)redhat.com> wrote:
>
> On Thu, 29 Oct 2020 15:26:53 -0000, GitLab Bridge on behalf of jmflinuxtx wrote:
> > From: Justin Forbes <jforbes(a)fedoraproject.org>
>
> Justin, formatting the commits this way is really making our future
> life harder. Could you please:
>
> 1. Submit a single patch instead of this mess of first setting the
> config option to no, only to flip it to yes right after?
The reason I agreed to make the changes was because it could be done
in a matter of seconds in the web UI as opposed to checking out the
branch, making the change, and doing a force change. I really have
enough on my plate without adding that.
Gitlab allows me to "squash commits on merge" which will change these
to a single commit in git history, and should address your concern.
> > 2. Include a reason on why the config option is set in the way it is?
> > Something like: "As requested by Jiri Benc
<jbenc(a)redhat.com>" would
> > be totally enough.
>
> That, I am happy to do.
>
> > I'm very sure both of these points can be easily automated.
> >
>
> If someone would like to automate it, that's great. At the moment I am
> managing every Fedora release, and a good bit of ARK. hopefully some
> help is coming that will take some of the ARK specific work off of my
> plate, but until then, it is actually a lot to ask. The reason I
> agreed to do it was because a) it could be done this way in a matter
> of seconds in the web ui, and b) otherwise, any config option that was
> reviewed and wanting a change was just sitting there, not actually
> being changed.
>
> Justin