Hi,
On 21-06-17 17:26, Justin Forbes wrote:
On Wed, Jun 21, 2017 at 3:45 AM, Hans de Goede <hdegoede(a)redhat.com
<mailto:hdegoede@redhat.com>> wrote:
Hi,
On 19-06-17 20:13, Laura Abbott wrote:
On 06/16/2017 09:13 AM, Hans de Goede wrote:
Hi All,
For the last couple of months I've been working on improving Linux
support for Intel Bay and Cherry Trail devices as a spare-time project.
A lot of my changes for this have landed in the 4.12 kernel, see:
http://hansdegoede.livejournal.com/
<
http://hansdegoede.livejournal.com/>
The proposed config changes enable various drivers to make these
improvements available for Fedora users.
Most of these changes just enable modules, but there is one change
which also impacts non Bay and Cherry Trail x86_64 users, the proposed
changes also change the I2C_DESIGNWARE controller options from module
to built-in. This is necessary because Bay and Cherry Trail devices use
an i2c attached PMIC which provides an ACPI OpRegion and this OpRegion
must be available before any devices with _PS0 or _PS3 methods which
use this OpRegion get their drivers bound to them.
I'm not expecting any side-effects from this change, but I wanted
to point this out just in case.
I thought there had previously been discussion about why we can't
have it built in but I have been unable to produce any evidence that
such a conversation ever existed. I might be confusing it with another
subsystem (GPIO?).
AFAIK having this builtin is fine, for 4.13 some patches of mine will land
which will make the Crystal Cove PMIC MFD driver Kconfig option (which is
a boolean) do a select CONFIG_I2C_DESIGNWARE_PLATFORM, forcing it to be
builtin too, so by landing this config change for 4.12 we are doing something
which will happen for 4.13 anyways.
Rawhide seems a good place to get it tested anyway. You are welcome to commit this, or
I can do it if you like.
Ok, I've gone ahead and just pushed this change + as already mentioned some
small Bay and Cherry Trail related fixes (which should not impact other hardware).
In total I've added 16 patches to improve the user experience for Bay and Cherry
Trail
devices, of those 10 are in -next and can be dropped when moving to 4.13-rc#, I've
good
hope to get most of the 6 others upstream too, some might miss 4.13 though
I've done a local x86_64 build to check I didn't break things from building, my
changes
should not impact other archs, but I've started a scratch-build on koji to double
check
all archs still build, if I somehow broke things I'll make sure to fix that soon.
Regards,
Hans