On Fri, 2007-09-14 at 18:42 -0400, Dave Jones wrote:
On Sat, Sep 15, 2007 at 01:34:24AM +0300, Gilboa Davara wrote:
> > In light of this, I'd like to propose that we turn off
> > DEBUG_STACKOVERFLOW in Fedora, at least on x86/4KSTACKS. I think it
> > does more harm than good; the warning is going to turn deadly most of
> > the time.
> >
> Sorry for butting in... but isn't disabling STACKOVERFLOW the wrong
> answer to this problem?
> Does anyone see any reason why both sprint_symbol and __print_symbol
> shouldn't use dynamically allocated buffers instead of wasting stack
> space? *
I think the reason is that kmalloc can sleep, and those functions
may be called from code that can't sleep.
Dave
kmalloc(GFP_ATOMIC) should not sleep.
... I wonder if there's a way, with no local_irq_disable/enable to use
some pre-allocated per_cpu buffer.
.. Either way, if such a patch is required, I should really propose and
push it upstream.
- Gilboa