From: Alice Mitchell on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1603
NOTE: Truncated patchset due to missing public @redhat.com email
address on your GitLab profile at https://gitlab.com/-/profile.
Once that is fixed, close and reopen the merge request to
retrigger sending the emails.
This is to add a new kernel taint flag that indicates that this
is a Partner Supported GPL module and not directly Supported
by Red Hat, as per the policy document for partner Supported
upstream kernel modules as linked from the bugzilla.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2038999
Upstream Status: RHEL only
Signed-off-by: Alice Mitchell <ajmitchell(a)redhat.com>
---
fs/afs/main.c | 1 +
include/linux/panic.h | 2 +-
kernel/panic.c | 2 +-
kernel/rh_messages.c | 30 ++++++++++++++++++++++++++++++
4 files changed, 33 insertions(+), 2 deletions(-)
Hello,
We ran automated tests on the following kernel build:
Kernel package: kernel-5.16.6-200.fc35
Task URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=82420958
The results of these automated tests are provided below.
Overall result: FAILED (see details below)
Tests: PANICKED
One or more kernel tests failed:
aarch64:
π₯ stress: stress-ng - os
π₯ Boot test
All kernel binaries, config files, and logs are available for download here:
https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefiβ¦
Please reply to this email if you have any questions about the tests that we
ran or if you have any suggestions on how to make future tests more effective.
For the full detail on our testing procedures, please scroll to the bottom of
this message.
,-. ,-.
( C ) ( K ) Continuous
`-',-.`-' Kernel
( I ) Integration
`-'
______________________________________________________________________________
Hardware testing
----------------
We booted each kernel and ran the following tests:
aarch64:
Host 1:
π§ β SELinux Custom Module Setup
β Boot test
β Reboot test
β ACPI table test
β LTP - cve
β LTP - sched
β LTP - syscalls
β LTP - can
β LTP - commands
β LTP - containers
β LTP - dio
β LTP - fs
β LTP - fsx
β LTP - math
β LTP - hugetlb
β LTP - mm
β LTP - nptl
β LTP - pty
β LTP - ipc
β LTP - tracing
β LTP: openposix test suite
β CIFS Connectathon
β Loopdev Sanity
β Memory: fork_mem
β Memory function: memfd_create
β AMTU (Abstract Machine Test Utility)
β Ethernet drivers sanity
π§ β NFS Connectathon
Host 2:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
β‘β‘β‘ Ethernet drivers sanity - mlx5
Host 3:
π§ β SELinux Custom Module Setup
β Boot test
β Reboot test
π§ β Storage blktests - nvmeof-mp
Host 4:
π§ β SELinux Custom Module Setup
β Boot test
β Reboot test
β xfstests - ext4
β xfstests - xfs
β Storage: swraid mdadm raid_module test
π§ β xfstests - btrfs
π§ β Storage blktests - blk
π§ β Storage blktests - nvme-tcp
π§ β Storage block - filesystem fio test
π§ β Storage block - queue scheduler test
π§ β Storage block - storage fio numa
π§ β storage: software RAID testing
π§ β stress: stress-ng - interrupt
π§ β stress: stress-ng - cpu
π§ β stress: stress-ng - cpu-cache
π§ β stress: stress-ng - memory
π§ π₯ stress: stress-ng - os
Host 5:
π§ β SELinux Custom Module Setup
π₯ Boot test
β Reboot test
π§ β Storage blktests - srp
Host 6:
π§ β SELinux Custom Module Setup
β Boot test
β Reboot test
β Ethernet drivers sanity - mlx5
ppc64le:
Host 1:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
β‘β‘β‘ xfstests - ext4
β‘β‘β‘ xfstests - xfs
β‘β‘β‘ Storage: swraid mdadm raid_module test
π§ β‘β‘β‘ xfstests - btrfs
π§ β‘β‘β‘ Storage blktests - blk
π§ β‘β‘β‘ Storage blktests - nvme-tcp
π§ β‘β‘β‘ Storage block - filesystem fio test
π§ β‘β‘β‘ Storage block - queue scheduler test
π§ β‘β‘β‘ Storage block - storage fio numa
π§ β‘β‘β‘ Storage: lvm device-mapper test - upstream
π§ β‘β‘β‘ storage: software RAID testing
Host 2:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
π§ β‘β‘β‘ Storage blktests - srp
Host 3:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
β‘β‘β‘ LTP - cve
β‘β‘β‘ LTP - sched
β‘β‘β‘ LTP - syscalls
β‘β‘β‘ LTP - can
β‘β‘β‘ LTP - commands
β‘β‘β‘ LTP - containers
β‘β‘β‘ LTP - dio
β‘β‘β‘ LTP - fs
β‘β‘β‘ LTP - fsx
β‘β‘β‘ LTP - math
β‘β‘β‘ LTP - hugetlb
β‘β‘β‘ LTP - mm
β‘β‘β‘ LTP - nptl
β‘β‘β‘ LTP - pty
β‘β‘β‘ LTP - ipc
β‘β‘β‘ LTP - tracing
β‘β‘β‘ LTP: openposix test suite
β‘β‘β‘ CIFS Connectathon
β‘β‘β‘ Loopdev Sanity
β‘β‘β‘ Memory: fork_mem
β‘β‘β‘ Memory function: memfd_create
β‘β‘β‘ AMTU (Abstract Machine Test Utility)
β‘β‘β‘ Ethernet drivers sanity
π§ β‘β‘β‘ xarray-idr-radixtree-test
π§ β‘β‘β‘ NFS Connectathon
s390x:
Host 1:
π§ β SELinux Custom Module Setup
β Boot test
β Reboot test
β LTP - cve
β LTP - sched
β LTP - syscalls
β LTP - can
β LTP - commands
β LTP - containers
β LTP - dio
β LTP - fs
β LTP - fsx
β LTP - math
β LTP - hugetlb
β LTP - mm
β LTP - nptl
β LTP - pty
β LTP - ipc
β LTP - tracing
β LTP: openposix test suite
β CIFS Connectathon
β Loopdev Sanity
β Memory: fork_mem
β Memory function: memfd_create
β AMTU (Abstract Machine Test Utility)
β Ethernet drivers sanity
π§ β NFS Connectathon
Host 2:
π§ β SELinux Custom Module Setup
β Boot test
β Reboot test
β Storage: swraid mdadm raid_module test
π§ β Storage blktests - blk
π§ β Storage blktests - nvme-tcp
π§ β stress: stress-ng - interrupt
π§ β stress: stress-ng - cpu
π§ β stress: stress-ng - cpu-cache
π§ β stress: stress-ng - memory
π§ β stress: stress-ng - os
Host 3:
π§ β SELinux Custom Module Setup
β Boot test
β Reboot test
π§ β Storage blktests - nvmeof-mp
x86_64:
Host 1:
π§ β SELinux Custom Module Setup
β Boot test
β Reboot test
β ACPI table test
β LTP - cve
β LTP - sched
β LTP - syscalls
β LTP - can
β LTP - commands
β LTP - containers
β LTP - dio
β LTP - fs
β LTP - fsx
β LTP - math
β LTP - hugetlb
β LTP - mm
β LTP - nptl
β LTP - pty
β LTP - ipc
β LTP - tracing
β LTP: openposix test suite
β CIFS Connectathon
β Loopdev Sanity
β Memory: fork_mem
β Memory function: memfd_create
β AMTU (Abstract Machine Test Utility)
β Ethernet drivers sanity
π§ β xarray-idr-radixtree-test
π§ β NFS Connectathon
Host 2:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
π§ β‘β‘β‘ Storage blktests - srp
Host 3:
π§ β SELinux Custom Module Setup
β Boot test
β Reboot test
π§ β Storage blktests - nvmeof-mp
Host 4:
π§ β SELinux Custom Module Setup
β Boot test
β Reboot test
β xfstests - ext4
β xfstests - xfs
β xfstests - nfsv4.2
β Storage: swraid mdadm raid_module test
π§ β xfstests - btrfs
π§ β xfstests - cifsv3.11
π§ β Storage blktests - blk
π§ β Storage blktests - nvme-tcp
π§ β Storage block - filesystem fio test
π§ β Storage block - queue scheduler test
π§ β Storage block - storage fio numa
π§ β Storage: lvm device-mapper test - upstream
π§ β storage: software RAID testing
π§ β stress: stress-ng - interrupt
π§ β stress: stress-ng - cpu
π§ β stress: stress-ng - cpu-cache
π§ β stress: stress-ng - memory
π§ β stress: stress-ng - os
Host 5:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
π§ β‘β‘β‘ Storage blktests - srp
Host 6:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
π§ β‘β‘β‘ Storage blktests - srp
Test sources: https://gitlab.com/cki-project/kernel-tests
π Pull requests are welcome for new tests or improvements to existing tests!
Aborted tests
-------------
Tests that didn't complete running successfully are marked with β‘β‘β‘.
If this was caused by an infrastructure issue, we try to mark that
explicitly in the report.
Waived tests
------------
If the test run included waived tests, they are marked with π§. Such tests are
executed but their results are not taken into account. Tests are waived when
their results are not reliable enough, e.g. when they're just introduced or are
being fixed.
Testing timeout
---------------
We aim to provide a report within reasonable timeframe. Tests that haven't
finished running yet are marked with β±.
From: Stefan Schulze Frielinghaus <sfrielin(a)redhat.com>
Enable iSER on s390x
Since the required hardware is available to our users, having iSER
available as an option for our users seems appropriate.
Tested: by IBM
Upstream Status: RHEL only
Signed-off-by: Stefan Schulze Frielinghaus <sfrielin(a)redhat.com>
diff --git a/redhat/configs/ark/generic/s390x/CONFIG_INFINIBAND_ISER b/redhat/configs/ark/generic/s390x/CONFIG_INFINIBAND_ISER
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/ark/generic/s390x/CONFIG_INFINIBAND_ISER
+++ /dev/null
@@ -1 +0,0 @@
-# CONFIG_INFINIBAND_ISER is not set
diff --git a/redhat/configs/ark/generic/s390x/CONFIG_INFINIBAND_ISERT b/redhat/configs/ark/generic/s390x/CONFIG_INFINIBAND_ISERT
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/ark/generic/s390x/CONFIG_INFINIBAND_ISERT
+++ /dev/null
@@ -1 +0,0 @@
-# CONFIG_INFINIBAND_ISERT is not set
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1536
From: Prarit Bhargava <prarit(a)redhat.com>
Makefile: Check PKGRELEASE size on dist-brew targets
The Red Hat brew system is a build system used internally within Red Hat
which is similar to the externally available koji build system. One of
the architectures of a brew build is 's390x+zfcpdump'. This arch using
the default of localversion 'test' always causes the rpm build error:
"5.17.0-0.rc0.20220114gitfb3b0673b7d5.65.test.el9_b.s390x+zfcpdump" exceeds 64 characters
make: *** [Makefile:1257: include/generated/utsrelease.h] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.tMkhuG (%build)
The 64 character limit is a size limit on UTSRELEASE and cannot be dynamically
changed so the only other option is to reduce the package release
(PKGRELEASE) string in length. Removing the date field and the string
'git' results in a string that is shorter by 11 characters, with a minimal
loss in information.
This option should not be set for the dist-git target so explicitly set
PREBUILD_GIT_ONLY to zero on the dist-git and dist-git-test targets.
Add an option, PREBUILD_GIT_ONLY, to shorten the PREBUILD variable which
is used in the PKGRELEASE string. Add a check for the size of PKGRELEASE
and return a pre-build error if PKGRELEASE is greater than 35 characters.
Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>
diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -390,10 +390,19 @@ dist-koji : BUILD_FLAGS ?= $(KOJI_FLAGS) $(TEST_FLAGS)
distg-brew: BUILD_FLAGS ?= $(BREW_FLAGS) $(TEST_FLAGS)
distg-koji: BUILD_FLAGS ?= $(KOJI_FLAGS) $(TEST_FLAGS)
-dist-brew dist-koji: dist-%: dist-srpm
+dist-vr-check:
+ @# builds may include a s390x+zfcpdump arch build. UTS_RELEASE can only have a
+ @# version-release string with max 64 chars. The version-release for s390x+zfcpdump
+ @# is 29 characters, leaving a maximum of 35 characters for PKGRELEASE.
+ @if [ $$(echo -n $(PKGRELEASE) | wc -c) -gt 35 ]; then \
+ echo "PKGRELEASE ($(PKGRELEASE)) is too long. Use a shorter localversion (currently $(BUILDID))"; \
+ exit 1; \
+ fi
+
+dist-brew dist-koji: dist-%: dist-vr-check dist-srpm
$* $(BUILD_PROFILE) build $(BUILD_FLAGS) $(BUILD_TARGET) $(SRPMS)/$(PACKAGE_NAME)-$(KVERSION)-$(PKGRELEASE)$(DIST).src.rpm $(OUTPUT_FILE)
-distg-brew distg-koji: distg-%:
+distg-brew distg-koji: distg-%: dist-vr-check
$* $(BUILD_PROFILE) build $(BUILD_FLAGS) $(BUILD_TARGET) "$(RHGITURL)?redhat/koji#$(RHGITCOMMIT)"
.PHONY: $(REDHAT)/rpm/SOURCES/$(PACKAGE_NAME).spec
diff --git a/redhat/Makefile.common b/redhat/Makefile.common
index blahblah..blahblah 100644
--- a/redhat/Makefile.common
+++ b/redhat/Makefile.common
@@ -75,9 +75,18 @@ ifeq ($(SNAPSHOT),1)
PREBUILD:=0$(KEXTRAVERSION).
RPMKPATCHLEVEL:=$(shell expr $(RPMKPATCHLEVEL) + 1)
endif
- # Obtain the date that HEAD was committed (not the snapshot commit).
- HEAD_DATE:=$(shell $(GIT) show -s --format=%cd --date=format:%Y%m%d $(HEAD))
- PREBUILD:=$(PREBUILD)$(HEAD_DATE)git$(MARKER).
+ ifneq ($(filter $(MAKECMDGOALS),dist-git-test dist-git),)
+ PREBUILD_GIT_ONLY ?= 0
+ else
+ PREBUILD_GIT_ONLY ?= 1
+ endif
+ ifeq ($(PREBUILD_GIT_ONLY),1)
+ PREBUILD:=$(PREBUILD)$(MARKER).
+ else
+ # Obtain the date that HEAD was committed (not the snapshot commit).
+ HEAD_DATE:=$(shell $(GIT) show -s --format=%cd --date=format:%Y%m%d $(HEAD))
+ PREBUILD:=$(PREBUILD)$(HEAD_DATE)git$(MARKER).
+ endif
UPSTREAM_TARBALL_NAME:=$(patsubst v%,%,$(_TAG))
endif
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1579
From: Prarit Bhargava <prarit(a)redhat.com>
kernel.spec: Add glibc-static build requirement
CKI and brew builds resulted in two different values for
CONFIG_CC_CAN_LINK_STATIC. In CKI CONFIG_CC_CAN_LINK_STATIC=y while in
brew CONFIG_CC_CAN_LINK_STATIC was not defined. This occurs because
glibc-static is installed on the CKI build containers and was not
installed in brew.
In order to guarantee consistency across build environments add a build
requirement for the glibc-static package.
Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template
index blahblah..blahblah 100755
--- a/redhat/kernel.spec.template
+++ b/redhat/kernel.spec.template
@@ -585,6 +585,9 @@ BuildRequires: net-tools, hostname, bc, elfutils-devel
BuildRequires: dwarves
BuildRequires: python3-devel
BuildRequires: gcc-plugin-devel
+# glibc-static is required for a consistent build environment (specifically
+# CONFIG_CC_CAN_LINK_STATIC=y).
+BuildRequires: glibc-static
%ifnarch %{nobuildarches} noarch
BuildRequires: bpftool
%endif
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1538
From: Prarit Bhargava <prarit(a)redhat.com>
kernel.spec: Add glibc-static build requirement
CKI and brew builds resulted in two different values for
CONFIG_CC_CAN_LINK_STATIC. In CKI CONFIG_CC_CAN_LINK_STATIC=y while in
brew CONFIG_CC_CAN_LINK_STATIC was not defined. This occurs because
glibc-static is installed on the CKI build containers and was not
installed in brew.
In order to guarantee consistency across build systems add a build
requirement for the glibc-static package.
Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template
index blahblah..blahblah 100755
--- a/redhat/kernel.spec.template
+++ b/redhat/kernel.spec.template
@@ -585,6 +585,8 @@ BuildRequires: net-tools, hostname, bc, elfutils-devel
BuildRequires: dwarves
BuildRequires: python3-devel
BuildRequires: gcc-plugin-devel
+# required for CONFIG_CC_CAN_LINK_STATIC=y
+BuildRequires: glibc-static
%ifnarch %{nobuildarches} noarch
BuildRequires: bpftool
%endif
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1538
From: David Hildenbrand <david(a)redhat.com>
[redhat] virtio: enable virtio-mem on x86-64 as tech-preview
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2014492
Let's enable CONFIG_VIRTIO_MEM=m on x86-64 in RHEL 9. As it will be
tech-preview, properly taint the kernel as soon as we're initializing
the driver for an actual device in a !kdump environment where we might
actually hot(un)plug memory when instructed by the hypervisor.
We won't be tainting in a kdump kernel where the sole purpose is to check
if a given PFN is actually part of a plugged virtio-mem device and can
be dumped safely.
Signed-off-by: David Hildenbrand <david(a)redhat.com>
diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index blahblah..blahblah 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -2754,6 +2754,19 @@ static int virtio_mem_probe(struct virtio_device *vdev)
/* trigger a config update to start processing the requested_size */
if (!vm->in_kdump) {
+#ifdef CONFIG_RHEL_DIFFERENCES
+ static bool printed;
+
+ /*
+ * virtio-mem, and especially its memory hot(un)plug
+ * functionality, is tech-preview.
+ */
+ if (!printed) {
+ printed = true;
+ mark_tech_preview("virtio_mem", THIS_MODULE);
+ }
+#endif /* CONFIG_RHEL_DIFFERENCES */
+
atomic_set(&vm->config_changed, 1);
queue_work(system_freezable_wq, &vm->wq);
}
diff --git a/redhat/configs/common/generic/x86/x86_64/CONFIG_VIRTIO_MEM b/redhat/configs/common/generic/x86/x86_64/CONFIG_VIRTIO_MEM
index blahblah..blahblah 100644
--- a/redhat/configs/common/generic/x86/x86_64/CONFIG_VIRTIO_MEM
+++ b/redhat/configs/common/generic/x86/x86_64/CONFIG_VIRTIO_MEM
@@ -1 +1 @@
-# CONFIG_VIRTIO_MEM is not set
+CONFIG_VIRTIO_MEM=m
diff --git a/redhat/configs/fedora/generic/x86/x86_64/CONFIG_VIRTIO_MEM b/redhat/configs/fedora/generic/x86/x86_64/CONFIG_VIRTIO_MEM
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/fedora/generic/x86/x86_64/CONFIG_VIRTIO_MEM
+++ /dev/null
@@ -1 +0,0 @@
-CONFIG_VIRTIO_MEM=m
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1535