[OS-BUILD PATCH] [redhat] New configs in drivers/pinctrl
by GitLab Bridge on behalf of jeremycline
From: Fedora Kernel Team <kernel-team(a)fedoraproject.org>
Hi,
As part of the ongoing rebase effort, the following configuration
options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply
with a better option.
CONFIG_PINCTRL_JASPERLAKE:
This pinctrl driver provides an interface that allows configuring
of Intel Jasper Lake PCH pins and using them as GPIOs.
Symbol: PINCTRL_JASPERLAKE [=n]
Type : tristate
Defined at drivers/pinctrl/intel/Kconfig:114
Prompt: Intel Jasper Lake PCH pinctrl and GPIO driver
Depends on: PINCTRL [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
Location:
-> Device Drivers
-> Pin controllers (PINCTRL [=y])
Selects: PINCTRL_INTEL [=m]
---
CONFIG_PINCTRL_SM8250:
This is the pinctrl, pinmux, pinconf and gpiolib driver for the
Qualcomm Technologies Inc TLMM block found on the Qualcomm
Technologies Inc SM8250 platform.
Symbol: PINCTRL_SM8250 [=n]
Type : tristate
Defined at drivers/pinctrl/qcom/Kconfig:219
Prompt: Qualcomm Technologies Inc SM8250 pin controller driver
Depends on: PINCTRL [=y] && (ARCH_QCOM [=y] || COMPILE_TEST [=n]) && GPIOLIB [=y] && OF [=y]
Location:
-> Device Drivers
-> Pin controllers (PINCTRL [=y])
Selects: PINCTRL_MSM [=y]
---
Signed-off-by: Fedora Kernel Team <kernel-team(a)fedoraproject.org>
---
.../common/generic/CONFIG_PINCTRL_JASPERLAKE | 1 +
.../common/generic/CONFIG_PINCTRL_SM8250 | 1 +
.../generic/CONFIG_PINCTRL_JASPERLAKE | 18 ------------------
.../generic/CONFIG_PINCTRL_SM8250 | 19 -------------------
4 files changed, 2 insertions(+), 37 deletions(-)
create mode 100644 redhat/configs/common/generic/CONFIG_PINCTRL_JASPERLAKE
create mode 100644 redhat/configs/common/generic/CONFIG_PINCTRL_SM8250
delete mode 100644 redhat/configs/pending-common/generic/CONFIG_PINCTRL_JASPERLAKE
delete mode 100644 redhat/configs/pending-common/generic/CONFIG_PINCTRL_SM8250
diff --git a/redhat/configs/common/generic/CONFIG_PINCTRL_JASPERLAKE b/redhat/configs/common/generic/CONFIG_PINCTRL_JASPERLAKE
new file mode 100644
index 000000000000..09f84c415cfe
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_PINCTRL_JASPERLAKE
@@ -0,0 +1 @@
+# CONFIG_PINCTRL_JASPERLAKE is not set
diff --git a/redhat/configs/common/generic/CONFIG_PINCTRL_SM8250 b/redhat/configs/common/generic/CONFIG_PINCTRL_SM8250
new file mode 100644
index 000000000000..490872420c0e
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_PINCTRL_SM8250
@@ -0,0 +1 @@
+# CONFIG_PINCTRL_SM8250 is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_JASPERLAKE b/redhat/configs/pending-common/generic/CONFIG_PINCTRL_JASPERLAKE
deleted file mode 100644
index 59ec9a1e7484..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_JASPERLAKE
+++ /dev/null
@@ -1,18 +0,0 @@
-# CONFIG_PINCTRL_JASPERLAKE:
-#
-# This pinctrl driver provides an interface that allows configuring
-# of Intel Jasper Lake PCH pins and using them as GPIOs.
-#
-# Symbol: PINCTRL_JASPERLAKE [=n]
-# Type : tristate
-# Defined at drivers/pinctrl/intel/Kconfig:114
-# Prompt: Intel Jasper Lake PCH pinctrl and GPIO driver
-# Depends on: PINCTRL [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
-# Location:
-# -> Device Drivers
-# -> Pin controllers (PINCTRL [=y])
-# Selects: PINCTRL_INTEL [=m]
-#
-#
-#
-# CONFIG_PINCTRL_JASPERLAKE is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_SM8250 b/redhat/configs/pending-common/generic/CONFIG_PINCTRL_SM8250
deleted file mode 100644
index 383eb8bef202..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_SM8250
+++ /dev/null
@@ -1,19 +0,0 @@
-# CONFIG_PINCTRL_SM8250:
-#
-# This is the pinctrl, pinmux, pinconf and gpiolib driver for the
-# Qualcomm Technologies Inc TLMM block found on the Qualcomm
-# Technologies Inc SM8250 platform.
-#
-# Symbol: PINCTRL_SM8250 [=n]
-# Type : tristate
-# Defined at drivers/pinctrl/qcom/Kconfig:219
-# Prompt: Qualcomm Technologies Inc SM8250 pin controller driver
-# Depends on: PINCTRL [=y] && (ARCH_QCOM [=y] || COMPILE_TEST [=n]) && GPIOLIB [=y] && OF [=y]
-# Location:
-# -> Device Drivers
-# -> Pin controllers (PINCTRL [=y])
-# Selects: PINCTRL_MSM [=y]
-#
-#
-#
-# CONFIG_PINCTRL_SM8250 is not set
--
2.26.2
3 years, 6 months
[OS-BUILD PATCH] [redhat] New configs in drivers/thermal
by GitLab Bridge on behalf of jeremycline
From: Fedora Kernel Team <kernel-team(a)fedoraproject.org>
Hi,
As part of the ongoing rebase effort, the following configuration
options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply
with a better option.
CONFIG_THERMAL_NETLINK:
The thermal framework has a netlink interface to do thermal
zones discovery, temperature readings and events such as
trip point crossed, cooling device update or governor
change. It is recommended to enable the feature.
Symbol: THERMAL_NETLINK [=n]
Type : bool
Defined at drivers/thermal/Kconfig:20
Prompt: Thermal netlink management
Depends on: THERMAL [=y] && NET [=y]
Location:
-> Device Drivers
-> Thermal drivers (THERMAL [=y])
---
Signed-off-by: Fedora Kernel Team <kernel-team(a)fedoraproject.org>
---
.../common/generic/CONFIG_THERMAL_NETLINK | 1 +
.../generic/CONFIG_THERMAL_NETLINK | 19 -------------------
2 files changed, 1 insertion(+), 19 deletions(-)
create mode 100644 redhat/configs/common/generic/CONFIG_THERMAL_NETLINK
delete mode 100644 redhat/configs/pending-common/generic/CONFIG_THERMAL_NETLINK
diff --git a/redhat/configs/common/generic/CONFIG_THERMAL_NETLINK b/redhat/configs/common/generic/CONFIG_THERMAL_NETLINK
new file mode 100644
index 000000000000..8abdc692a524
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_THERMAL_NETLINK
@@ -0,0 +1 @@
+# CONFIG_THERMAL_NETLINK is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_THERMAL_NETLINK b/redhat/configs/pending-common/generic/CONFIG_THERMAL_NETLINK
deleted file mode 100644
index 72adf3600dd2..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_THERMAL_NETLINK
+++ /dev/null
@@ -1,19 +0,0 @@
-# CONFIG_THERMAL_NETLINK:
-#
-# The thermal framework has a netlink interface to do thermal
-# zones discovery, temperature readings and events such as
-# trip point crossed, cooling device update or governor
-# change. It is recommended to enable the feature.
-#
-# Symbol: THERMAL_NETLINK [=n]
-# Type : bool
-# Defined at drivers/thermal/Kconfig:20
-# Prompt: Thermal netlink management
-# Depends on: THERMAL [=y] && NET [=y]
-# Location:
-# -> Device Drivers
-# -> Thermal drivers (THERMAL [=y])
-#
-#
-#
-# CONFIG_THERMAL_NETLINK is not set
--
GitLab
3 years, 6 months
[OS-BUILD PATCH 0/2] redhat/Makefile and Makefile.common: add GIT
macro
by GitLab Bridge on behalf of bcrocker
From: bcrocker on gitlab.com
In redhat/Makefile and Makefile.common, add a GIT macro:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT).\
This change enables us to override 'git' with, e.g., some\
arbitrary shell script that prints additional information\
and/or does additional processing before and/or after (or\
even instead of) invoking /usr/bin/git.
3 years, 6 months
Re: [OS-BUILD PATCHv2] New configs in net/sched
by Jiri Benc
On Wed, 30 Sep 2020 16:29:47 +0200, Davide Caratti wrote:
> I remember we discussed this some time ago, and the outcome was act_gate
> can be useful for fedora users, not so much for RHEL users. So probably
> it can be 'n' in the common setting, and 'm' in fedora, correct?
Thanks for the clarification! I admit I got lost in the changes.
Changing my ack for the third time. Sorry for the mess.
Acked-by: Jiri Benc <jbenc(a)redhat.com>
Fedora enablement can be done in a separate follow up patch.
Jiri
3 years, 6 months
Re: [OS-BUILD PATCHv2] New configs in net/sched
by Marcelo Ricardo Leitner
On Wed, Sep 30, 2020 at 04:29:47PM +0200, Davide Caratti wrote:
> On Wed, 2020-09-30 at 16:23 +0200, Jiri Benc wrote:
> > On Wed, 30 Sep 2020 11:16:32 -0300, Marcelo Ricardo Leitner wrote:
> > > On Wed, Sep 30, 2020 at 01:46:53PM -0000, GitLab Bridge on behalf of jmflinuxtx wrote:
> > > > --- /dev/null
> > > > +++ b/redhat/configs/common/generic/CONFIG_NET_ACT_GATE
> > > > @@ -0,0 +1 @@
> > > > +# CONFIG_NET_ACT_GATE is not set
> > >
> > > Acked-by: Marcelo Ricardo Leitner <mleitner(a)redhat.com>
> >
> > Okay, Marcelo, but now you'll need to decide what is really wanted :-)
> >
> > https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject....
> >
> > Jiri
>
>
> I remember we discussed this some time ago, and the outcome was act_gate
> can be useful for fedora users, not so much for RHEL users. So probably
> it can be 'n' in the common setting, and 'm' in fedora, correct?
Fair point. In my previous email, I referred only to RHEL.
But then we need Fedora to do that change, right?
3 years, 6 months
❌ FAIL: Test report for kernel 5.9.0-0.rc7.22.cki.fc33 (ark)
by CKI Project
Hello,
We ran automated tests on a recent commit from this kernel tree:
Kernel repo: https://gitlab.com/cki-project/kernel-ark.git
Commit: 7fe574f04f45 - [redhat] kernel-5.9.0-0.rc7.20200930gitfb0155a09b02.21
The results of these automated tests are provided below.
Overall result: FAILED (see details below)
Merge: OK
Compile: FAILED
All kernel binaries, config files, and logs are available for download here:
https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?pre...
We attempted to compile the kernel for multiple architectures, but the compile
failed on one or more architectures:
aarch64: FAILED (see build-aarch64.log.xz attachment)
ppc64le: FAILED (see build-ppc64le.log.xz attachment)
s390x: FAILED (see build-s390x.log.xz attachment)
x86_64: FAILED (see build-x86_64.log.xz attachment)
We hope that these logs can help you find the problem quickly. For the full
detail on our testing procedures, please scroll to the bottom of this message.
Please reply to this email if you have any questions about the tests that we
ran or if you have any suggestions on how to make future tests more effective.
,-. ,-.
( C ) ( K ) Continuous
`-',-.`-' Kernel
( I ) Integration
`-'
______________________________________________________________________________
Compile testing
---------------
We compiled the kernel for 4 architectures:
aarch64:
rpmbuild arguments: rpmbuild --target aarch64 --with=cross --with=kabidw_base --without=bpftool --without=selftests --without=debug --without=ipaclones --without=perf --without=tools
ppc64le:
rpmbuild arguments: rpmbuild --target ppc64le --with=cross --with=kabidw_base --without=bpftool --without=selftests --without=debug --without=ipaclones --without=perf --without=tools
s390x:
rpmbuild arguments: rpmbuild --target s390x --with=cross --with=kabidw_base --without=bpftool --without=selftests --without=debug --without=ipaclones --without=perf --without=tools
x86_64:
rpmbuild arguments: rpmbuild --target x86_64 --with=kabidw_base --without=debug
3 years, 6 months
Problem building kernel 5.9 rc6 from src.rpm when perf enabled,
looks to be a script error, a typo
by stan
I sent part of this to the devel list by mistake, correcting and
sending to the kernel list.
Hi,
When building the kernel with perf enabled from the src.rpm
kernel-5.9.0-0.rc6.20200925git171d4ff79f96.17.fc34.src.rpm
I get an error. There seems to be an error in one of the build
scripts. This was not a problem in src.rpm for
kernel-5.9.0-0.rc4.20200911git581cb3a26baf.8.fc34.src.rpm
The error seems to be in a script, and looks like a typo,
+ +# perf
/var/tmp/rpm-tmp.bbuLwN: line 499: +#: command not found
error: Bad exit status from /var/tmp/rpm-tmp.bbuLwN (%build)
Bad exit status from /var/tmp/rpm-tmp.bbuLwN (%build)
When I look in that temporary file, I find this, with the error line
marked by <<<<<<---- error:
###
# DO it...
###
# prepare directories
rm -rf $RPM_BUILD_ROOT
mkdir -p $RPM_BUILD_ROOT/boot
mkdir -p $RPM_BUILD_ROOT/usr/libexec
cd linux-5.9.0-0.rc6.20200925git171d4ff79f96.17.20200927.fc31.x86_64
BuildKernel bzImage arch/x86/boot/bzImage 1
+# perf <<<<<<<<---- error
# make sure check-headers.sh is executable
chmod +x tools/perf/check-headers.sh
/usr/bin/make -s EXTRA_CFLAGS="${RPM_OPT_FLAGS}"
LDFLAGS="-Wl,-z,relro -Wl,--as-needed -Wl,-z,now
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld" -C tools/perf V=1
NO_PERF_READ_VDSO32=1 NO_PERF_READ_VDSOX32=1 WERROR=0 NO_LIBUNWIND=1
HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=/usr
PYTHON=/usr/bin/python3 DESTDIR=$RPM_BUILD_ROOT all
That is in the spec file, but the error isn't in the spec file.
It doesn't have the + in front of the # in the spec file.
###
# DO it...
###
# prepare directories
rm -rf $RPM_BUILD_ROOT
mkdir -p $RPM_BUILD_ROOT/boot
mkdir -p $RPM_BUILD_ROOT%{_libexecdir}
cd linux-%{KVERREL}
%if %{with_debug}
BuildKernel %make_target %kernel_image %{_use_vdso} debug
%endif
%if %{with_zfcpdump}
BuildKernel %make_target %kernel_image %{_use_vdso} zfcpdump
%endif
%if %{with_pae}
BuildKernel %make_target %kernel_image %{use_vdso} lpae
%endif
%if %{with_up}
BuildKernel %make_target %kernel_image %{_use_vdso}
%endif
%global perf_make \
%{__make} -s EXTRA_CFLAGS="${RPM_OPT_FLAGS}" LDFLAGS="%{__global_ldflags}" %{?cross_opts} -C tools/perf V=1 NO_PERF_READ_VDSO32=1 NO_PERF_READ_VDSOX32=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=%{_prefix} PYTHON=%{__python3}
%if %{with_perf}
+%global _lto_cflags %{nil}
# perf
# make sure check-headers.sh is executable
chmod +x tools/perf/check-headers.sh
%{perf_make} DESTDIR=$RPM_BUILD_ROOT all
%endif
%global tools_make \
%{make} CFLAGS="${RPM_OPT_FLAGS}" LDFLAGS="%{__global_ldflags}" V=1
Thanks for any insight.
3 years, 6 months
Changing kernel configuration options related to the SquashFS
decompression
by Bohdan Khomutskyi
Hello,
While working on the change proposal
https://fedoraproject.org/wiki/Changes/OptimizeSquashFS
I discovered that several kernel configuration options are set
sub-optimally in Fedora. In RHEL 8, the optimal configuration is used.
If we set those options to match RHEL 8, a performance improvement could
be achieved while reading the SquashFS filesystem.
Below you can see an excerpt from the configuration help:
Set in RHEL 8:
SQUASHFS_FILE_DIRECT
Directly decompress file data into the page cache.
Doing so can significantly improve performance because
it eliminates a memcpy and it also removes the lock contention
on the single buffer.
SQUASHFS_DECOMP_MULTI_PERCPU
By default Squashfs uses a single decompressor but it gives
poor performance on parallel I/O workloads when using multiple CPU
machines due to waiting on decompressor availability.
This decompressor implementation uses a maximum of one
decompressor per core. It uses percpu variables to ensure
decompression is load-balanced across the cores.
Set in Fedora:
SQUASHFS_DECOMP_SINGLE
Traditionally Squashfs has used single-threaded decompression.
Only one block (data or metadata) can be decompressed at any
one time. This limits CPU and memory usage to a minimum.
SQUASHFS_FILE_CACHE
Decompress file data into an intermediate buffer and then
memcopy it into the page cache.
The SquashFS filesystem is used on installation medium. So making the
change I propose should improve the user experience during installation.
It should also improve the user experience while booting from Fedora
Live image.
Kind regards,
--
Bohdan Khomutskyi
Software engineer
Red Hat
3 years, 6 months
[OS-BUILD PATCH] The serial IR driver is needed for Fedora
media-centers.
by GitLab Bridge on behalf of prarit
From: Prarit Bhargava <prarit(a)redhat.com>
Re-enable the serial IR module for Fedora.
Suggested-by: Craig Gelowitz <craig(a)gelowitz.org>
Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>
Cc: jbastian(a)redhat.com
---
redhat/configs/fedora/generic/CONFIG_IR_SERIAL | 1 +
1 file changed, 1 insertion(+)
create mode 100644 redhat/configs/fedora/generic/CONFIG_IR_SERIAL
diff --git a/redhat/configs/fedora/generic/CONFIG_IR_SERIAL b/redhat/configs/fedora/generic/CONFIG_IR_SERIAL
new file mode 100644
index 000000000000..53c7f1d81e8e
--- /dev/null
+++ b/redhat/configs/fedora/generic/CONFIG_IR_SERIAL
@@ -0,0 +1 @@
+CONFIG_IR_SERIAL=m
--
GitLab
3 years, 6 months
❌ FAIL: Test report for kernel 5.9.0-0.rc7.21.cki.fc33 (ark)
by CKI Project
Hello,
We ran automated tests on a recent commit from this kernel tree:
Kernel repo: https://gitlab.com/cki-project/kernel-ark.git
Commit: cca5dc27736a - [redhat] kernel-5.9.0-0.rc7.20
The results of these automated tests are provided below.
Overall result: FAILED (see details below)
Merge: OK
Compile: FAILED
All kernel binaries, config files, and logs are available for download here:
https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?pre...
We attempted to compile the kernel for multiple architectures, but the compile
failed on one or more architectures:
aarch64: FAILED (see build-aarch64.log.xz attachment)
ppc64le: FAILED (see build-ppc64le.log.xz attachment)
s390x: FAILED (see build-s390x.log.xz attachment)
x86_64: FAILED (see build-x86_64.log.xz attachment)
We hope that these logs can help you find the problem quickly. For the full
detail on our testing procedures, please scroll to the bottom of this message.
Please reply to this email if you have any questions about the tests that we
ran or if you have any suggestions on how to make future tests more effective.
,-. ,-.
( C ) ( K ) Continuous
`-',-.`-' Kernel
( I ) Integration
`-'
______________________________________________________________________________
Compile testing
---------------
We compiled the kernel for 4 architectures:
aarch64:
rpmbuild arguments: rpmbuild --target aarch64 --with=cross --with=kabidw_base --without=bpftool --without=selftests --without=debug --without=ipaclones --without=perf --without=tools
ppc64le:
rpmbuild arguments: rpmbuild --target ppc64le --with=cross --with=kabidw_base --without=bpftool --without=selftests --without=debug --without=ipaclones --without=perf --without=tools
s390x:
rpmbuild arguments: rpmbuild --target s390x --with=cross --with=kabidw_base --without=bpftool --without=selftests --without=debug --without=ipaclones --without=perf --without=tools
x86_64:
rpmbuild arguments: rpmbuild --target x86_64 --with=kabidw_base --without=debug
3 years, 6 months