https://bugzilla.redhat.com/show_bug.cgi?id=1217904
Bug ID: 1217904 Summary: pep8/pylint fixes Product: Fedora Version: rawhide Component: fedora-review-plugin-java Assignee: msimacek@redhat.com Reporter: leamas.alec@gmail.com QA Contact: extras-qa@fedoraproject.org CC: java-sig-commits@lists.fedoraproject.org, mizdebsk@redhat.com, msimacek@redhat.com, msrb@redhat.com
Created attachment 1021171 --> https://bugzilla.redhat.com/attachment.cgi?id=1021171&action=edit pep8 patch
Description of problem:
Last update introduced some pep8 errors.
The overall problem is how to handle the pylint.conf and pep8.conf which rare part of the main fedora-review package. Perhaps this package (the plugin) should use them as available ni fedora-review.
https://bugzilla.redhat.com/show_bug.cgi?id=1217904
Michael Simacek msimacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1217904
Michael Simacek msimacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #1 from Michael Simacek msimacek@redhat.com --- Applied as upstream commit 492b020
https://bugzilla.redhat.com/show_bug.cgi?id=1217904
--- Comment #2 from Alec Leamas leamas.alec@gmail.com --- Created attachment 1029798 --> https://bugzilla.redhat.com/attachment.cgi?id=1029798&action=edit pep8 config file
https://bugzilla.redhat.com/show_bug.cgi?id=1217904
--- Comment #3 from Alec Leamas leamas.alec@gmail.com --- Created attachment 1029799 --> https://bugzilla.redhat.com/attachment.cgi?id=1029799&action=edit pylint config file.
I have updates the fedora-review package (yet not released) to include pylint.conf and pep8.conf (attached). Could you update the release process for your plugin to include static checking with these tools as described in fedora-review's CONTRIBUTE?
https://bugzilla.redhat.com/show_bug.cgi?id=1217904
--- Comment #5 from Fedora End Of Life jkurik@fedoraproject.org --- This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'.
Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version.
Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above.
Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
https://bugzilla.redhat.com/show_bug.cgi?id=1217904
Fedora End Of Life jkurik@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |EOL Last Closed| |2016-12-20 08:38:38
--- Comment #6 from Fedora End Of Life jkurik@fedoraproject.org --- Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug.
If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug.
Thank you for reporting this bug and we are sorry it could not be fixed.
java-sig-commits@lists.fedoraproject.org
-
Red Hat Bugzilla