commit bd1c55721b9ccbffeaf535764fb6ff2b0b86ffcb
Author: Jim Meyering <meyering(a)redhat.com>
Date: Wed Apr 6 13:41:56 2011 +0200
maint: limit scope of backend.c globals
* backend.c (NFSGID): Declare as an enum, rather than via #define.
An enum is easier to reference via debugger.
(hstor, s3_success_pat, s3_failure_pat, regex_ok): Declare static.
backend.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/backend.c b/backend.c
index 7ca4db0..10f6bf9 100644
--- a/backend.c
+++ b/backend.c
@@ -46,9 +46,10 @@
#define ARRAY_CARDINALITY(Array) (sizeof (Array) / sizeof *(Array))
-#define NFSGID 36
+/* FIXME: describe/justify */
+enum { NFSGID = 36 };
-struct hstor_client *hstor;
+static struct hstor_client *hstor;
/***** Generic module stuff, not specific to one back end *****/
@@ -65,9 +66,9 @@ struct hstor_client *hstor;
#define S3_IMAGE_PATTERN "^IMAGE[[:blank:]]+([^[:space:]]+)"
#define S3_ERROR_PATTERN "^ERROR[[:blank:]]+([^[:space:]]+)"
-regex_t s3_success_pat;
-regex_t s3_failure_pat;
-int regex_ok = FALSE;
+static regex_t s3_success_pat;
+static regex_t s3_failure_pat;
+static int regex_ok = FALSE;
void
backend_init (void)
Show replies by date