New branch 'master' available with the following commits: commit 4cb41b49a2b69509658d4fb90c21efde29476d9d Author: Jim Meyering meyering@redhat.com Date: Mon Feb 14 14:14:05 2011 +0100
avoid file descriptor leak in replication
The "pipes[2]" member was set by calling pipe, but those two descriptors were never closed or even used. * replica.c (struct _repl_item) [pipes[2]]: Remove member. (repl_worker): Don't use ->pipes.
commit 25a832f79a7685cecad169206df7a235547b81f8 Author: Jim Meyering meyering@redhat.com Date: Mon Feb 14 13:44:23 2011 +0100
tweak diagnostics
commit 9e39dc2a1855c7c313e39f643c1681f1bd32f141 Author: Jim Meyering meyering@redhat.com Date: Thu Feb 10 15:31:35 2011 +0100
maint: also create xz-compressed tarballs
* configure.ac (AM_INIT_AUTOMAKE): Also make xz-compressed tarballs. They are more than 30% smaller.
commit 684918a88245adbbb80cd3b317d80877d1f9a861 Author: Jim Meyering meyering@redhat.com Date: Thu Feb 10 14:58:50 2011 +0100
post-release administrivia
* NEWS: Add header line for next release. * .prev-version: Record previous version. * cfg.mk (old_NEWS_hash): Auto-update.
commit 8f68e88ae81db999209f0cf16bba47bd9df9cd14 Author: Jim Meyering meyering@redhat.com Date: Thu Feb 10 14:56:52 2011 +0100
version 0.91
* NEWS: Record release date.
commit 600ca43a8cd39dae9aa1256a670da9a243678207 Author: Jim Meyering meyering@redhat.com Date: Thu Feb 10 14:52:35 2011 +0100
maint: record previous release tag name
* .prev-version: Record tag name of previous release. This is used (and automatically advanced) when making a release via e.g., "build-aux/do-release-commit-and-tag 0.91 stable".
commit 8c22e73ad9f889f528a0acb7d761bf15d3d91c95 Author: Jim Meyering meyering@redhat.com Date: Thu Feb 10 14:45:48 2011 +0100
doc: add to NEWS
* NEWS: Update
commit fa248d5fdb71e0c52b0257c59e2c28a9dd82e451 Author: Jim Meyering meyering@redhat.com Date: Tue Feb 8 16:00:37 2011 +0100
maint: speed up configure
* configure.ac (gl_ASSERT_NO_GNULIB_POSIXCHECK): Speed up normal configure runs.
commit e41b7a771670ffdd08bcfe0550810632c6a466de Author: Jim Meyering meyering@redhat.com Date: Tue Feb 8 15:56:11 2011 +0100
maint: build via make CFLAGS='-DGNULIB_POSIXCHECK=1'; address warnings
* bootstrap.conf: Add most of the recommended modules: calloc-posix close dup2 mkstemp pipe-posix strstr strtok_r unlink
commit f47eb186d1fb2d2fc6b7698427295f437a39c83b Author: Jim Meyering meyering@redhat.com Date: Tue Jan 25 11:12:05 2011 +0100
tests: reenable excluded gnulib test; run gnulib-tests first
* bootstrap.conf: Don't disable malloca-test. It has been fixed so it is no longer so slow. * gnulib: Update to latest. * Makefile.am (SUBDIRS): Run gnulib-tests before ours, so the results of ours aren't displaced as gnulib's scroll by.
commit e598b6675690fb79fc9c74ffb11be97f8f258421 Author: Jim Meyering meyering@redhat.com Date: Fri Jan 21 16:05:22 2011 +0100
don't pass NULL buffer to formatter in provider list generation
* rest.c (prov_list_generator): Pre-allocate a reasonably-large buffer, rather than starting with a 0-length buffer and relying on the ~doubling/realloc loop to make the buffer large enough.
commit 80a978acd30fc420ce4d4139caa955d43ec04ac7 Author: Jim Meyering meyering@redhat.com Date: Thu Jan 20 14:30:31 2011 +0100
protect remaining uses of prov_hash against concurrent access
* setup.c (hash_get_prov_list): New function. * setup.h: Declare it. * replica.c (replicate, replicate_namespace_action): Use hash_get_prov_list to get all provider pointers at once, and which locks the hash table before accessing it. With hash_get_first_prov and hash_get_next_prov that was not possible. * setup.c (hash_get_first_prov, hash_get_next_prov): Remove functions. * setup.h: Remove declarations.
commit e73b7221f26dc46b07575a18e207836eaed6d7e7 Author: Jim Meyering meyering@redhat.com Date: Thu Jan 20 14:29:04 2011 +0100
remove dead code
* rest.c (prov_list_generator): Don't store into unused member, ms->prov_iter. * state_defs.h (_my_state) [prov_iter]: Remove now-unused member.
commit 1f415f5dfaa403b3ef86945806fb93f24335bc20 Author: Jim Meyering meyering@redhat.com Date: Wed Jan 19 18:16:19 2011 +0100
use symbolic names in place of more hard-coded constants
* rest.c (POST_BUF_SIZE, CB_BLOCK_SIZE): Define constants. (proxy_get_data): Use them in place of hard-coded constants. (proxy_query, proxy_list_objs, proxy_api_root): Likewise. (control_api_root, proxy_bucket_post, show_parts): Likewise. (proxy_object_post, proxy_list_provs, proxy_add_prov): Likewise.
Reported by Jeff Darcy.
commit 9b8036c2cdae166c532a6c510017f2de485e489c Author: Jim Meyering meyering@redhat.com Date: Wed Jan 19 17:41:18 2011 +0100
use SMALL_PRIME in place of literal 13 (initial hash table size)
* setup.h (SMALL_PRIME): Define. * setup.c: s/13/SMALL_PRIME/ * rest.c: Likewise. Reported by Jeff Darcy.
commit 0a5ec6af13b82ad1dd4b1314f98f209660820d06 Author: Jim Meyering meyering@redhat.com Date: Wed Jan 19 17:15:38 2011 +0100
build: make configure fail if gc-devel (aka libgc-dev) is not installed
* configure.ac: Check for <gc.h>. Reported by Jeff Darcy.
commit facb15d171c3d99112291511137d92e300698950 Author: Jim Meyering meyering@redhat.com Date: Wed Jan 19 17:08:42 2011 +0100
plug a potential leak
This tells GC that when finalizing an "ma" pointer, it must also release a few more members of that structure. * rest.c (destroy_state_postprocessor): Also free ms->query and ms->aquery. (gc_register_finalizer_ms): Update comment to reflect reality.
commit 0b0c8f73f794cf6c9b5427013aacda31e6ed4a54 Author: Jim Meyering meyering@redhat.com Date: Mon Jan 17 21:58:38 2011 +0100
remove gnulib hash.c diff hack
Rather than compiling hash.c differently, treat it more like part of the library that it is, and instead arrange to free things via our GC finalize handler. Remove kv_free and all uses. * setup.h (kv_free): Remove definition. Now unused. * gl/lib/hash.c.diff: Remove file. Not needed. * rest.c (destroy_state_postprocessor): Also call hash_free. * setup.c: Remove uses of kv_free. No need.
commit 16dd48f463abbb2905afe5b74f4905932eb85ca4 Author: Jim Meyering meyering@redhat.com Date: Tue Jan 18 15:13:29 2011 +0100
tests: also check JSON provider lists
* t/init.cfg (emit_provider): Add parameter, is-last, so that we know whether to print the final comma for JSON output. * t/basic: Update emit_trivial_provider_list use. * t/provider: Check both XML and JSON formats.
commit fff9a6a6445c089b2a8f557176d89819aac2a3ec Author: Jim Meyering meyering@redhat.com Date: Tue Jan 18 19:16:16 2011 +0100
list providers: avoid syntax error in JSON output
Without this change, we would print "[,\n" at the beginning of the list of JSON-formatted providers. * template.c (tmpl_prov_entry): Don't emit the leading "," on the first entry. * template.h: Adjust prototype. * rest.c: Update sole caller. Spotted by Jeff Darcy.
commit ba44b876ad572f2861114a0ba01124c6611a9da8 Author: Jim Meyering meyering@redhat.com Date: Tue Jan 18 13:05:20 2011 +0100
sort provider list on "name"
* rest.c: Sort provider list output on name: (struct plist): Define. (prov_get, prov_name_compare): New functions. (prov_list_generator): Rather than emitting provider XML/JSON in arbitrary (hash-traversal) order, first gather an array of provider_t* pointers, sort them, and *then* emit listing. * t/init.cfg (emit_provider_list_prefix): New helper. (emit_provider_list_suffix): Likewise. (emit_trivial_provider_list): Renamed from emit_provider. (emit_provider): Emit output for a single provider. I.e., do not emit prefix and suffix. * t/basic: s/emit_provider/emit_trivial_provider_list/ * t/provider: Compare full output with expected output, rather than just grepping for a summary. This is feasible, now that the provider list is sorted.
commit 33dea68259d6ea08253163373f4c36400f6535ca Author: Jim Meyering meyering@redhat.com Date: Tue Jan 18 10:28:55 2011 +0100
tests: prepare for improved provider checks in t/provider
* t/basic (emit_provider, emit_bucket_list): Move helper functions... * t/init.cfg: ...to here.
commit 8eccf807a16213425c463630b9bdae0c6734ee52 Author: Jim Meyering meyering@redhat.com Date: Tue Jan 18 08:51:59 2011 +0100
microhttpd may also spawn threads to call prov_list_generator; tell GC
Just as done for access_handler (registered via MHD_start_daemon), we have to tell the garbage collector about the thread that runs MHD_connection_handle_idle and calls prov_list_generator. The symptom is an abort when the MHD_connection_handle_idle runs. To diagnose, invoke gdb on the resulting core file, then type "thread apply all bt" and note the functions at the base of the stack on the losing thread. That's the one that hasn't yet been registered for GC. * rest.c (gc_register_thread): New macro, factored out of... (access_handler): ...here. (prov_list_generator): Use it here, too.
commit f08ff1ceab77a8e2e06d1170b4a46fb47920d29b Author: Jim Meyering meyering@redhat.com Date: Fri Jan 14 22:13:27 2011 +0100
also mutex-protect the provider-iterator used in listing
* setup.c (prov_do_for_each): Guard with a mutex.
commit 549b989ddd8b189cb3b798d602ee30502aea473a Author: Jim Meyering meyering@redhat.com Date: Fri Jan 14 21:49:09 2011 +0100
rewrite provider-listing code so we can protect it with a mutex:
The above is the primary goal, but this change also avoids printing invalid output for pathologically-long provider records. When iterating through the provider hash, we must prevent insertion. Rather than getting/formatting a new provider for each callback (which would mean holding a mutex for way too long -- and hard to know if/when to release it), iterate over all providers the first time and save all output in an allocated buffer. Then serve up bite-sized pieces of that buffer until it's all output. * rest.c (a2nrealloc): New function, derived from gnulib's x2nrealloc. (prov_fmt): New function. (prov_list_generator): Rewrite, prov_do_for_each and the above. Assert that header fits in our buffer, rather than silently truncating it and thus producing invalid output. Do the same for the footer. * template.c (tmpl_prov_entry): Rewrite not to use a fixed-size buffer. Now, this is just a thin layer around snprintf. * template.h (tmpl_prov_entry): New prototype. * state_defs.h [struct _my_state] (buf, buf_n_alloc, size_t buf_n_used): New members. * setup.c (prov_do_for_each): New function. * setup.h: Declare it.
commit 9414f266a267f5e8a1860ef87ad2a59a3022ff24 Author: Jim Meyering meyering@redhat.com Date: Fri Jan 14 17:47:42 2011 +0100
avoid unnecessary MHD_lookup_connection_value calls
Move "accept_hdr" decl and definition into sole block where it's used This avoids the unnecessary call to MHD_lookup_connection_value on all but the first call to each of these event-handling functions. * rest.c (proxy_query_func, root_blob_generator, parts_callback): (prov_list_generator): As above.
commit ac3e583f5cf58a38f261d12abba558e40b1e7873 Author: Jim Meyering meyering@redhat.com Date: Fri Jan 14 17:11:10 2011 +0100
handle hash_initialize and MHD_create_post_processor failure
* rest.c (proxy_query, control_api_root, proxy_bucket_post): (proxy_object_post, proxy_add_prov): Return MHD_NO, rather than ignoring the failures.
commit b247691b9ea2f7dacbcf1edbedef28206eb2a722 Author: Jim Meyering meyering@redhat.com Date: Thu Jan 13 22:17:00 2011 +0100
avoid a leak via ms->post = MHD_create_post_processor(...
* rest.c (gc_register_finalizer_ms): New function. (proxy_query, control_api_root, proxy_bucket_post): Use it. (proxy_object_post, proxy_add_prov): Likewise. (destroy_state_postprocessor): New function.
commit d4de957c8a10b97952b18c705369f305393b6b16 Author: Jim Meyering meyering@redhat.com Date: Thu Jan 13 18:26:25 2011 +0100
t/provider: warn-then-sleep on failure -- eases debugging
commit a2eee0a0daabc99ff2b2db49948adfdead278c63 Author: Jim Meyering meyering@redhat.com Date: Wed Jan 12 18:36:27 2011 +0100
tell GC about the thread spawned by MHD_start_daemon
rest.c's main program calls MHD_start_daemon to register access_handler as a function that it will call from the thread it creates. Normally, the garbage collector learns of pthread_create calls because they're cpp-wrapped. However, when it's called from 3rd-party libraries as in this case, we can't very well recompile, so have to use a different approach: * rest.c (access_handler): Call GC_register_my_thread to inform the garbage collector of this new thread.
commit eb90a1c8aedc31c4c6587a9c9b79fc3ba6b4fc54 Author: Jim Meyering meyering@redhat.com Date: Wed Jan 12 18:29:17 2011 +0100
insinuate GC into gnulib's hash-related code
* bootstrap.conf: Disable the hash-test, which would otherwise get link failures due to unresolved GC_malloc, etc. * gl/lib/hash.c.diff: New file. This patch is automatically applied to gnulib's hash.c at bootstrap time.
commit f941f9f0fac64fcadb87dec827964e0ca3f28316 Author: Jim Meyering meyering@redhat.com Date: Mon Jan 10 20:00:45 2011 +0100
convert all remaining uses of g_hash_* functions
g_hash_table_insert g_hash_table_remove g_hash_table_foreach g_hash_table_find g_hash_table_iter_init g_hash_table_iter_next
commit ef8b8713dd64dce7c32a9b3a3eca2a2c1e1ff7ef Author: Jim Meyering meyering@redhat.com Date: Mon Jan 10 15:42:54 2011 +0100
convert remaining g_hash_table_lookup functions to kv_hash_lookup
commit d2ab5e735f780571599111bac2cf726c2f9ae62b Author: Jim Meyering meyering@redhat.com Date: Thu Jan 6 22:49:53 2011 +0100
begin converting hash tables from glib to gnulib
commit f5febefdfefc5ebff68388e4899d690d55d83a72 Author: Jim Meyering meyering@redhat.com Date: Thu Jan 6 23:13:38 2011 +0100
remove more tests of in-place provider changing
commit eb66edbe487f746d8bb6c244973bd86bb782a34a Author: Jim Meyering meyering@redhat.com Date: Thu Jan 6 23:03:25 2011 +0100
do not allow "updating" a provider in place -- now, you must remove and then re-add
commit a7de76399efe41f1040259ade74837d2eb8736c3 Author: Jim Meyering meyering@redhat.com Date: Thu Jan 6 20:16:24 2011 +0100
guard provider-addition with a mutex; tighten provider test
* rest.c: Remove some small, now-unnecessary free calls. * setup.c (add_provider): Guard with new file-global mutex. * t/provider: Remove ulimit on core size, so that if one is dumped, we get something that's usable. Sleep upon failure.
commit d1aa322fb7750dd52d893f73d499f4f0e27f0c06 Author: Jim Meyering meyering@redhat.com Date: Tue Jan 4 12:59:23 2011 +0100
tests: add dynamic-provider test
* t/provider: New file.
commit f0877f6496e4c7f1df2834bb01681161f379a4a0 Author: Jim Meyering meyering@redhat.com Date: Thu Dec 23 22:04:41 2010 +0100
remove functions and struct members that are no longer needed
* rest.c (free_ms): Remove function and all uses. * setup.c (delete_provider): Remove function and sole use. * setup.h (refcnt): Remove struct member and all uses. * state_defs.h (cleanup, refcnt): Remove struct members. Remove all uses. * replica.c: Remove uses of the above.
commit 7ec84dde8be9610f33c46b3fbd9dc5607f13510b Author: Jim Meyering meyering@redhat.com Date: Thu Dec 23 18:36:38 2010 +0100
garbage-collection fix-up
Do not instruct libraries to free things that they do not allocate, since they would use the system "free" function. * setup.c, rest.c: Do not tell g_hash_table_new_full to free anything. * rest.c (proxy_get_attr): Do not tell MHD to free anything.
commit b98c47711c707bdd25f3d8d08f725321e25924f2 Author: Jim Meyering meyering@redhat.com Date: Wed Dec 22 17:25:19 2010 +0100
use garbage collection
Add -lgc when linking. * gc-wrap.h: New file, to map malloc, realloc, free, etc. to GC'd equivalents. * iwh.h: Include it. * template.c: Include it. * Makefile.am (iwhd_LDADD): Add -lgc and -lpthread. * t/Makefile.am (parser_LDADD): Likewise. * Makefile.am (iwhd_SOURCES): Add gc-wrap.h. (TESTS): Move the simpler parser-test to precede all others. * iwhd.spec.in (BuildRequires): Require gc-devel. * qparser.y (free_value): Remove function. * meta.cpp, replica.c: Remove all uses. * query.h: Remove declaration. * rest.c (main): Call GC_INIT. * qparser.y (main) [PARSER_UNIT_TEST]: Likewise. * mpipe.c: Include unistd.h here, ... * mpipe.h: ...not here. Don't include the following, either: fcntl.h, stdlib.h, string.h, strings.h, sys/stat.h. They were not used, and got in the way of gc-wrap's redefinitions.
commit cee9beecc22c373814a7a8e56b2860eacd3a8acd Author: Jim Meyering meyering@redhat.com Date: Sat Dec 18 11:08:25 2010 +0100
maint: rename file-scoped global s/main_prov/g_main_prov/, and...
* setup.c (g_main_prov): Rename from main_prov, to avoid confusion between this file-scoped global and the locals of the same name in other compilation units. (g_master_prov): Rename from master_prov, for consistency. Though this one is truly global... * setup.h (g_master_prov): Update here,... * rest.c (g_master_prov): ...and here.
commit 9e059c3626429c46b6990bc1892605fc7f3a5740 Author: Jim Meyering meyering@redhat.com Date: Sat Dec 18 10:47:58 2010 +0100
rename s/_set_primary/_primary/: more RESTful
commit 44ee9894f3b04e3d8baa65b2579d5ca938af6e7e Author: Jim Meyering meyering@redhat.com Date: Fri Dec 17 17:07:47 2010 +0100
new interface: curl -X PUT http://_providers/PROVIDER/_set_primary
* rest.c: Include <errno.h>. (proxy_set_primary): New function. (parse_url): Handle new type: URL_PROVIDER_SET_PRIMARY. * setup.c (set_main_provider): New function. * setup.h (set_main_provider): Declare it. * t/basic: Exercise the new functionality.
commit 2e9196c2628eade109cc2bcffb695f3575c7c067 Author: Jim Meyering meyering@redhat.com Date: Fri Dec 17 15:37:14 2010 +0100
get primary provider name via http://host:$port/_providers/_primary
Get a URL of the form http://.../_providers/_primary to obtain the name of the primary provider. * rest.c (proxy_primary_prov): Implement it. (proxy_add_prov): Prohibit addition of a provider with the reserved name, "_primary". * t/basic: Exercise the new functionality.
commit a04b76ca821f27765659fa52a96be620fb8fc431 Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 18:27:10 2010 +0100
tests: clean up provider-deletion test
commit 8187979f677652a5c617dd435cb6644ad360a9e5 Author: Jim Meyering meyering@redhat.com Date: Wed Dec 15 12:45:28 2010 +0100
use new function, get_main_provider, rather than global "main_prov"
* setup.c (get_main_provider): New function. (main_prov): Declare static. * setup.h (main_prov): Remove global decl. (get_main_provider): Declare. * rest.c, replica.c: Update all uses of "main_prov".
commit d209a1391ecf2737693f061b8401513599806515 Author: Jim Meyering meyering@redhat.com Date: Sat Dec 11 15:58:18 2010 +0100
reject an attempt to add a provider with "name" parameter
The "name" is specified as part of the URL, not via a parameter. * rest.c (proxy_add_prov): Handle undesired "name" parameter properly. * t/basic: Exercise the above.
commit 65df8ac6ad67633bbf42171dd40bfc132368459f Author: Jim Meyering meyering@redhat.com Date: Fri Dec 10 21:11:27 2010 +0100
add provider ref-counting; FIXME: partial impl. (i.e., no incr)
delete_provider: New function.
commit e2ecc0a75108543bcde4e3509202a5ac511ef1fe Author: Jim Meyering meyering@redhat.com Date: Thu Dec 23 18:17:23 2010 +0100
don't use xstrndup via base_name
* rest.c (url_to_provider_name): Rewrite not to use base_name, since that function uses xstrndup, which exits on OOM.
commit 530db87554e7c801813dce2f4cbb0108334c21de Author: Jim Meyering meyering@redhat.com Date: Mon Nov 15 17:50:53 2010 +0100
allow dynamic addition/deletion of providers
* setup.h (struct _provider) [deleted]: New member. * setup.c (validate_provider): New function. (json_validate_server): Renamed from validate_server. (convert_provider): Initialize new "deleted" member. (add_provider, find_provider): New functions. Declare new functions. * rest.c (prov_list_generator): Don't list a provider that is marked as deleted. (url_to_provider_name): New function. (proxy_delete_prov, proxy_add_prov): New functions. (my_rules): Add corresponding entries in this table. * t/basic: Add minimal tests of new functionality.
commit 5685b973f295453871778372a6d1bad9f1b75750 Author: Jim Meyering meyering@redhat.com Date: Mon Jan 10 18:51:20 2011 +0100
fix an unchecked strdup
commit 186b8eca47f80c8cb97c429bcdb7594028880fa2 Author: Jim Meyering meyering@redhat.com Date: Mon Feb 7 19:34:57 2011 +0100
build: update gnulib submodule to latest
commit 114b3cb856c58f24af540c6e9153f42e833c67d2 Author: Pete Zaitcev zaitcev@redhat.com Date: Fri Feb 4 16:53:26 2011 -0700
avoid hang when creating an object in non-existing bucket
This hang occurs when doing something like the following, without creating "templates" first: echo hello | curl -T - http://lembas:9090/templates/my_file
This bug appears to have been introduced due to an incomplete change during the cons_error/cons_init_error split.
* mpipe.c (pipe_cons_siginit): Use cons_init_done, not cons_init. (pipe_prod_wait_init): Use cons_init_error, not cons_init. * t/basic: add test for hang-no-parent bug
commit f22452b530a85b36a50cc8f7dc9fb9ea8387389b Author: Jeff Darcy jdarcy@redhat.com Date: Fri Feb 4 17:33:30 2011 +0100
don't segfault on a simple query
* qparser.y (free_value): Don't free v->resolved. (string_value): Disable caching of v->resolved. * rest.c (proxy_query): Don't free ms here. It's still in use. * t/basic: Add test case to trigger crash reported by Steve Loranz.
commit 6d0ab2da3a3fb3c92dde97a4072a317a8a63bba3 Author: Jim Meyering meyering@redhat.com Date: Tue Jan 25 11:12:05 2011 +0100
tests: reenable excluded gnulib test; run gnulib-tests first
* bootstrap.conf: Don't disable malloca-test. It has been fixed so it is no longer so slow. * Makefile.am (SUBDIRS): Run gnulib-tests before ours, so the results of ours aren't displaced as gnulib's scroll by.
commit ad4a71c5af22dd71c159181b37e63fc9ff16a31b Author: Jim Meyering meyering@redhat.com Date: Fri Feb 4 09:17:17 2011 +0100
build: update gnulib submodule to latest
commit 1bd814bab002ff719896c7ce6717f5758a73791d Author: Jim Meyering meyering@redhat.com Date: Fri Feb 4 09:17:01 2011 +0100
maint: update files copied from gnulib
* t/init.sh: Update from gnulib. * bootstrap: Likewise.
commit 923ba16951c01909de4ef456baf9bc410844f055 Author: Jim Meyering meyering@redhat.com Date: Tue Jan 11 16:03:04 2011 +0100
build: update gnulib submodule to latest
commit 27463b0ae9a121f196035a016e81039b2fd6d66e Author: Jim Meyering meyering@redhat.com Date: Thu Jan 6 20:20:33 2011 +0100
maint: update copyright year ranges to include 2011
Run "make update-copyright", so "make syntax-check" works in 2011. Also run this to handle the Red Hat ones: git ls-files |UPDATE_COPYRIGHT_HOLDER='Red Hat, Inc.' \ UPDATE_COPYRIGHT_USE_INTERVALS=1 \ UPDATE_COPYRIGHT_MAX_LINE_LENGTH=79 xargs gnulib/build-aux/update-copyright
commit e61482884574cd72831bbfd2935657ef34893b6e Author: Chris Lalancette clalance@redhat.com Date: Tue Jan 4 17:50:57 2011 +0100
maint: add a comment: BuildRequires vs. mongodb-server
* iwhd.spec.in: Add a comment about why iwhd "BuildRequires" mongodb-server.
commit b1cf0514518d23e2c347a63eae971b31f567bed7 Author: Jim Meyering meyering@redhat.com Date: Tue Jan 4 17:02:05 2011 +0100
revert "build: iwhd "Requires" mongodb-server (rather than BuildRequires)"
This reverts commit 1912f449225f380f82968780ccffadfab156ef66. The use of mongodb-server in "make check" counts as a build requirement. Pointed out by Pete Zaitcev.
commit 1912f449225f380f82968780ccffadfab156ef66 Author: Jim Meyering meyering@redhat.com Date: Tue Jan 4 11:45:29 2011 +0100
build: iwhd "Requires" mongodb-server (rather than BuildRequires)
* iwhd.spec.in (Requires): mongodb-server is a run-time requirement, not a build requirement.
commit 4d64b213464a20f4c28921b3ed68c0240d9c99dd Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 16:55:54 2010 +0100
build: make the "rpm" rule work once again
* Makefile.am (rpm): Accommodate a version number string like "0.0.273-1621", that contains a hyphen: s/-/./ (iwhd.spec): Depend on Makefile, not Makefile.am, so that a version number change provokes an update.
commit 162167233c1f92809060154dbed4be3146c5f504 Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 13:41:29 2010 +0100
maint: make autogen.sh invoke bootstrap
* autogen.sh: Invoke bootstrap.
commit 7ffa21ac39d711bfab5da7b847445c1b5db3e9e8 Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 12:23:25 2010 +0100
maint: avoid const-related warnings
* auto.c: Impossible to avoid without casts. Add const attributes and then add two casts. * setup.c (dup_json_string): Add const attribute to each parameter.
commit c4597f7fc4990f0dc4dc0ae6c5be116e9ea1dd8b Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 12:20:55 2010 +0100
maint: avoid warning about "noreturn" function
* iwh.h (ATTRIBUTE_NORETURN): Define * rest.c (usage): Use it here, to avoid a warning.
commit 8dfe3f897c05855f3d39fd30e7e047ce952b5531 Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 12:18:10 2010 +0100
maint: avoid theoretical risk of signed overflow
* rest.c (main): Declare "autostart" as bool and set to true or false rather than incrementing or setting to 0.
commit c059c0e95df17316d60bd70974f3b029602738bd Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 12:13:23 2010 +0100
maint: accommodate new, stricter warnings
* rest.c (struct): Avoid const-related warnings.
commit 1fbd0757294489f70137770e44ab20fdb4f467c4 Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 11:58:46 2010 +0100
maint: declare follow_link in replica.h
* replica.h (follow_link): Declare.
commit 371b2b03a156deb7c0190b4a463eaf164f609bbb Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 11:56:46 2010 +0100
maint: declare cf_put_child to be static
* backend.c (cf_put_child): Make "static" to avoid a warning.
commit 90fdaa34458e2ae186ff5f2820c6fa087fb10951 Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 11:54:16 2010 +0100
maint: remove unused definitions
* replica.c (ADDR_SIZE): Remove unused definition. (SVC_ACC_SIZE, HEADER_SIZE): Likewise. * setup.c (NEED_NONE): Likewise.
commit 83aef2f0bce333bff50105af9fd86562ef112275 Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 11:52:30 2010 +0100
do not perform arithmetic on void* pointers
* backend.c (http_put_cons, fs_put_child): Cast to (char*) first. * rest.c (proxy_get_cons): Likewise.
commit 5876b06bee5a9412ba372f0d72b4bb629abacc6a Author: Jim Meyering meyering@redhat.com Date: Thu Dec 16 11:39:41 2010 +0100
build: support configure-time --enable-gcc-warnings option
* configure.ac: Handle new --enable-gcc-warnings option. * Makefile.am (AM_CFLAGS): Use configure-determined $(WARN_CFLAGS) $(WERROR_CFLAGS), rather than hard-coded ones.
commit b25dcd02204c034521a47bd0678a591004638868 Author: Jim Meyering meyering@redhat.com Date: Wed Dec 15 16:01:07 2010 +0100
clean-up: don't define xmalloc, xstrdup, etc. -- use gnulib's definitions
* qparser.y [PARSER_UNIT_TEST]: Include "xalloc.h". (xalloc_die, xmalloc, xmemdup, xstrdup): Remove definitions. * t/Makefile.am (parser_CPPFLAGS): Append for xalloc.h. (parser_LDADD): Link with gnulib.
commit 652d185244963c54f102c1b106fab3a5bb46259e Author: Jim Meyering meyering@redhat.com Date: Wed Dec 15 08:23:52 2010 +0100
bootstrap.conf: mention bison
With this, an attempt to build from cloned-sources without "bison" will evoke a nice error from bootstrap. Without this, you'd get a relatively cryptic diagnostic much further down the build road.
commit 25a002a745a999ea9a4e58def2bf1298737d8643 Author: Jim Meyering meyering@redhat.com Date: Mon Oct 25 16:35:03 2010 +0200
skip the malloca-tests module; too slow
commit 1c518138da2b987619c76eac0eb3020894e1becb Author: Jim Meyering meyering@redhat.com Date: Mon Oct 25 16:27:19 2010 +0200
avoid redundant const -- move it to the right of "*"
commit 2af22e15f0a95fb1e9b32557a4097688794fc532 Author: Jim Meyering meyering@redhat.com Date: Mon Oct 25 16:26:03 2010 +0200
disable sc_cast_of_argument_to_free check
commit 0d9cd613e081776874dabcf298b450dde95c093e Author: Jim Meyering meyering@redhat.com Date: Tue Oct 5 18:21:08 2010 +0200
remove GNUmakefile -- now it is pulled from gnulib
commit 75c31581176c3d405fb075e997f80a4f51f1b00a Author: Jim Meyering meyering@redhat.com Date: Mon Oct 25 15:47:43 2010 +0200
use gnulib's closeout module
commit 8cf7615fec61f889635255bf8158c22ba64dc392 Author: Jim Meyering meyering@redhat.com Date: Fri Oct 1 15:06:56 2010 +0200
use first gnulib module: progname
* cfg.mk: Enable program_name check. * Makefile.am (iwhd_CPPFLAGS): Use -I$(top_srcdir)/lib. (iwhd_LDADD): Link with gnulib, aka lib/libiwhd.a. * rest.c (main): Use set_program_name.
commit c615729c5fb2877fea6e0383fb2bda29db570f23 Author: Jim Meyering meyering@redhat.com Date: Fri Oct 1 14:59:28 2010 +0200
enable no-blank-lines-at-EOF rule
commit 693fc8a86fc54bd2f29c31ab2cefa1d86add8767 Author: Jim Meyering meyering@redhat.com Date: Fri Oct 1 14:57:45 2010 +0200
enable "test -a/-o" prohibition
commit 839172bc2f35f8ba37ab59bdd25ea482a6e86c15 Author: Jim Meyering meyering@redhat.com Date: Fri Oct 1 14:56:30 2010 +0200
enable "echo -n/-e" prohibition
commit 72b4c4ff6037f506c78b839a48aa88a73fad5a95 Author: Jim Meyering meyering@redhat.com Date: Fri Oct 1 14:54:56 2010 +0200
enable m4 quoting check
commit c8d0be9f4c70775fca231996d1420e717628cc6c Author: Jim Meyering meyering@redhat.com Date: Fri Oct 1 14:50:16 2010 +0200
maint: remove unused #include directives spotted by "make syntax-check"
commit 2bbe861de39bc6e0e3220fefcbbb40dbeaa84e1d Author: Jim Meyering meyering@redhat.com Date: Fri Oct 1 14:41:02 2010 +0200
maint: enable no-trailing blanks prohibition
commit 88b1d8ae3d489a1df5d687a3422627d8cfc31f7b Author: Jim Meyering meyering@redhat.com Date: Thu Sep 30 16:44:11 2010 +0200
Use gnulib
Add gnulib as a submodule. Move ax/*.m4 to m4/*. * bootstrap: New file. Copied from gnulib. Fill in blanks in bootstrap.conf template. New file, cfg.mk, is very similar to what's used in other projects. * configure.ac: use gl_INIT and gl_EARLY, per documentation. Generate a Makefile for each of the new lib/ and gnulib-tests/ directories. * Makefile.am (SUBDIRS): Update so we build in lib before "." and so that "make check" runs the tests in gnulib-tests. * rest.c: Do not hard-code 1.0 as version number. * .gitignore: Ignore gnulib-tests.
commit df00ac3954bf66d4f6026f6dc787514f6e76a96c Author: Jim Meyering meyering@redhat.com Date: Fri Dec 10 21:34:54 2010 +0100
tests: wait for up to 5 seconds for start-up, not just 3s
* t/replication: When running via valgrind wrappers, 3 seconds was not enough. * t/basic: Likewise.
commit 2f9bb3adf0e201fd00c1b1abbd95dee892a67995 Author: Jim Meyering meyering@redhat.com Date: Tue Dec 14 18:09:20 2010 +0100
use strchr and strrchr, not index or rindex
* backend.c (curl_cache_child): s/index/strchr/ * rest.c (validate_url, register_image): Likewise and s/rindex/strrchr/
commit d0ceff3457d861291f2139af3cad17fb423cddee Author: Jim Meyering meyering@redhat.com Date: Wed Dec 15 18:47:09 2010 +0100
fix trivial comment typo
commit 604fc112cbda1ab89d8c94554055e447ab225c6d Author: Jim Meyering meyering@redhat.com Date: Sat Dec 11 15:41:52 2010 +0100
plug a leak
rest.c (proxy_put_data): Plug a leak exposed by reserved-object-name testing. Without this, "make -C t check TESTS=basic" with valgrind- wrapped iwhd would leak one "ms" object per reserved word test here:
for obj_name in _default _new _policy _query; do echo reserved-obj-name | curl -f -T - $bucket/$obj_name \ 2> bad_oname.err ...
2,240 bytes in 4 blocks are definitely lost in loss record 311 of 316 at 0x4A04896: calloc (vg_replace_malloc.c:418) by 0x42EA18: access_handler (rest.c:1967) by 0x4E405F8: ??? (in /usr/lib64/libmicrohttpd.so.10.0.0) by 0x4E4105F: MHD_connection_handle_idle (in /usr/lib64/libmicrohttpd.so.10.0.0) by 0x4E43986: ??? (in /usr/lib64/libmicrohttpd.so.10.0.0) by 0x3F49806D5A: start_thread (pthread_create.c:301) by 0x3F48CE4AAC: clone (clone.S:115)
commit ddf6a9609e1663eb5444232b77446ae2c5b1da0a Author: Jim Meyering meyering@redhat.com Date: Sat Dec 11 17:43:35 2010 +0100
plug leaks-after-OOM-failure
* rest.c (proxy_object_post, proxy_update_prov): Call free_ms before returning.
commit 56bccd9c5ee7dfce955b38519f89b34b5a14e9ec Author: Jim Meyering meyering@redhat.com Date: Tue Dec 7 13:36:09 2010 +0100
avoid warnings from new/better microhttpd.h signature for...
MHD_ContentReaderCallback, e.g., /usr/include/microhttpd.h:1138:22: note: expected 'MHD_ContentReaderCallback' but argument is of type 'int (*)(void *, uint64_t, char *, int)' The new signature returns ssize_t (not int) and its last parameter is size_t, not int.
commit efe01cecf78c8e36f7f1fef6f45a1d3a2547454f Author: Jim Meyering meyering@redhat.com Date: Tue Nov 30 18:52:44 2010 +0100
build: don't check for or use -lcrypto; it was not used
* configure.ac: Don't check for -lcrypto; we weren't using it. * Makefile.am (iwhd_LDADD): Don't use $(CRYPTO_LIB).
commit e83f9b64c1cd304f50dfdd392963f7a18d78b577 Author: Pete Zaitcev zaitcev@yahoo.com Date: Thu Nov 25 15:29:23 2010 -0700
switch to using installed ec2 tools
Amazon and RPMfusion package perfectly useable ec2-ami-tools and ec2-api-tools, for Fedora 13 and 14 at least. Let's use them and drop account-specific environment variables. But be careful to permit going back, in case (e.g. running on Fedora 15 Rawhide).
Also, document the dc-register-image's paramenters.
commit d24b2ce226447b4191ea1fa6d0288b65adc496ff Author: Pete Zaitcev zaitcev@yahoo.com Date: Thu Nov 18 08:37:30 2010 -0700
error to stderr
This is useless in production, since backend.c dups the same pipe to both stderr and stdout. However it is marginally uselful in debugging if they are redirected by a developer.
OK, I admit it: this feels more "correct".
commit 464741d6589ad92dd4086ad04c43199ed8e1801c Author: Pete Zaitcev zaitcev@yahoo.com Date: Thu Nov 18 08:36:14 2010 -0700
exit if mkdir fails
One fine way to have this fail is to use a back-end other than fs. To be fixed for real later, just stub it out for now to prevent a bunch of apriori incorrect operations that follow.
commit 1478b5d5011e213aa1ecc2549a5bc52e333c8bbd Author: Jim Meyering meyering@redhat.com Date: Wed Nov 10 19:28:06 2010 +0100
GNUmakefile: replace leading spaces with TABs
commit cc80a83104880b098979a27d594734c916497c92 Author: Jim Meyering meyering@redhat.com Date: Fri Nov 5 18:33:54 2010 +0100
convert reserved attribute names to have a leading underscore prefix
Before, they were date, etag, loc, key, bucket, and now they are _date, _etag, _loc, _key, _bucket. Add the accidentally omitted "_size" to the new list.
commit a1e1c061a29a840288a7f072afea1a743c45ee7b Author: Jim Meyering meyering@redhat.com Date: Thu Nov 4 19:37:14 2010 +0100
prohibit creation of a bucket with one of the reserved names
commit 30cfcfe2d708e11f027b3d8f3303680ee15b8e65 Author: Jim Meyering meyering@redhat.com Date: Thu Nov 4 16:29:09 2010 +0100
_policy is a reserved object name; reject it, just like the others
* rest.c (reserved_name): Add "_policy" to the list of reserved object names. Alphabetize. (reserved_attr): Alphabetize. Mark each array and members as const and propagate that to the sole interface, ... (is_reserved): More const. * t/basic: Exercise the code that rejects reserved object names.
commit f0c9b98d7c02a01b44e550db62088acb23e5655e Author: Jim Meyering meyering@redhat.com Date: Mon Oct 25 20:16:00 2010 +0200
s3_register: correct a diagnostic: s/key/secret/
commit 2b25f2693c1cbc2f85be3fd7a152eabff6ae26bb Author: Jim Meyering meyering@redhat.com Date: Mon Oct 25 19:36:13 2010 +0200
add a reminder not to hard-code /tmp/iwtmp.XXXXXX
We should be able to specify some other directory. Also add a "const".
commit f74043a7e17d49b1f27e166d88ad8d09e9aafd2a Author: Pete Zaitcev zaitcev@yahoo.com Date: Fri Oct 22 15:32:56 2010 -0600
Bump testing timeouts
I have a slow laptop that needs this. Lots of disk activity when testing, looks like Mongo does not like ext3 much, at least on Fedora 15.
Note that it's preferable for the framework timeout to be greater than the autostart's own timeout. This way if autostart times out, it kills mongo that it started, and usually succeeds. But if we let framework kill things, mongo sometimes escapes.
Also it's weird, but basic usually succeeds quickly enough, so no bump there - only bump auto and replication tests.
commit b992b5231f12c76a9c33e9cd777a9e1863489d00 Author: Pete Zaitcev zaitcev@yahoo.com Date: Fri Oct 22 15:32:03 2010 -0600
Lock auto.c to IPv4
As it turned out Mongo manages to listen on IPv4 only even if the system supports IPv6. The autostart tries to connect over IPv6, depending which address is returned first, and then fails.
The fix is simply to use IPv4 always, at least for loopback.
commit 39c17c133e63a5c9b339da577a09e0a77babcf9b Author: Jim Meyering meyering@redhat.com Date: Fri Oct 22 16:11:28 2010 +0200
parser: plug more leaks
* qparser.y (parse): Don't leak each expression tree. (free_value): Handle v == &invalid. Omit debug printf -- it would cause test failure, now that we're using free_value more. (main) [PARSER_UNIT_TEST]: Free "expr".
commit 0cbc1d76117be554a5d60f22bc1883fe9ee3de37 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Oct 21 12:41:46 2010 -0400
Change test-file names to be descriptive, avoid dups.
commit 2261a70baa183c94dde736e2636c8c00c8f171e8 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Oct 21 11:51:06 2010 -0400
Add test for truncation when overwriting an object.
Also added test-file-usage info in t/basic and t/replication.
commit 56c3693765e0cdedde5a52b13063470836fb7215 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Oct 21 11:33:44 2010 -0400
Add test for re-replication when an attribute changes.
commit 7520862b39704ab36ae8ff478a032c3398ef12f5 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Oct 21 11:24:20 2010 -0400
Fixed X-redhat-role check.
rest.c: validate_put fails if hdr present on master t/basic: new test for PUT rejected due to role t/replication: added missing -m to downstream iwhd
commit e2d933c6e5e1d39edc0664d4c21658148e437125 Author: Jim Meyering meyering@redhat.com Date: Thu Oct 21 08:41:59 2010 +0200
plug error path leak
commit f4d05852a6185b36660f5feee44cdb82ccba7b32 Author: Jim Meyering meyering@redhat.com Date: Thu Oct 21 09:08:39 2010 +0200
reduce scope of global to be file-only
* qparser.y (hacked_links): Declare to be "static const".
commit c98f5c1f712ca5b35cbaef83d2ea47015687e68c Author: Jim Meyering meyering@redhat.com Date: Wed Oct 20 21:36:37 2010 +0200
parser: move x*alloc functions into #if-unit-test block where used
* qparser.y (xalloc_die, xmalloc, xmemdup, xstrdup): Move functions... [#if PARSER_UNIT_TEST]: ... into this #if-block, since now they're used only there.
commit e6a29d3e5890a27c8f3afae96b8d5a2cf6cbaed6 Author: Jim Meyering meyering@redhat.com Date: Wed Oct 20 21:34:08 2010 +0200
parser: remove dead code
* qparser.y (xrealloc): Remove if-0'd function.
commit 064e3f485714996a9a4c85acd32dd514f4481fd6 Author: Jim Meyering meyering@redhat.com Date: Wed Oct 20 21:33:29 2010 +0200
parser: handle OOM gracefully
Before, a failed malloc or strdup would lead to a NULL dereference. * qparser.y (invalid): New file-scoped global. (make_number): Never return NULL. Instead, return &invalid. (make_string): Likewise. (make_tree): If an input has type T_INVALID, return it right away. Upon allocation failure, return &invalid. (make_comp, make_link): Likewise. (make_link, make_string): Avoid unnecessary strdup, now that lexed tokens are malloc'd. Also, add some per-function comments.
commit 2925ba08e51d0fb17df600da56c70e20627ab8e6 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Oct 21 10:35:51 2010 -0400
Add unlink/O_EXCL in case new file is shorter than what's there.
commit 70765c12c21e6f433d00bae5ea64f377f6f28f03 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Oct 21 10:33:02 2010 -0400
Add X-redhat-role header when replicating to ourselves.
commit 26af6493b707f493676f3151557a04c25dd69a8e Author: Jeff Darcy jdarcy@redhat.com Date: Thu Oct 21 10:23:33 2010 -0400
Sprintf/snprintf cleanup.
commit d30160123fa4665414c490461ac55493406c150e Author: Jeff Darcy jdarcy@redhat.com Date: Wed Oct 20 15:22:04 2010 -0400
Fix re-replication on attribute change.
Problem #1 was that the back-end code sometimes used ms->url instead of ms->bucket and ms->key, causing the other end to see the URL for the attribute that was changed instead of the URL for the file being re-replicated. Problem #2 was a memory leak when we re-use ms->pipe in the replica module.
backend.c: fix functional error #1 rest.c fix leak #2 by freeing ms->pipe.data_ptr in proxy_put_attr
commit 9f30bdb8086d10b45b27ee8d582e81615bf28b22 Author: Jim Meyering meyering@redhat.com Date: Wed Oct 20 12:03:30 2010 +0200
query parser: avoid 25 reduce/reduce conflicts
* qparser.y (T_SPACE): Remove token and all related rules. * qlexer.l: Ignore white space rather than returning T_SPACE. * t/parser-test: Adjust sole failing test: "$ a" was rejected before, due to ignored white space; now it's interpreted as "$a". Add one more: "$.a" that does still fail.
commit c7748e96024d9a845f8f7fbd0305a72a1f8bc077 Author: Jim Meyering meyering@redhat.com Date: Wed Oct 20 11:37:18 2010 +0200
simplify parser: <, >, >=, <=
commit b9c444677501e24e5aa1b2d10d58b8a99faf41fd Author: Jim Meyering meyering@redhat.com Date: Wed Oct 20 11:34:00 2010 +0200
simplify parser: T_EQ
commit cd22b27d3fc97df06f7e5917f958d3a5660627fe Author: Jim Meyering meyering@redhat.com Date: Wed Oct 20 11:32:59 2010 +0200
simplify parser: T_NE
commit 406cc793d1241acbc0c4dcb6bd070209b4289507 Author: Jim Meyering meyering@redhat.com Date: Wed Oct 20 11:14:53 2010 +0200
mark more unused parameters
commit ded3c1df9c18a30ce4794b12ab7d82297a9e6d2e Author: Jim Meyering meyering@redhat.com Date: Wed Oct 20 09:43:03 2010 +0200
remove final "static" state variable from the parser
* qparser.y: Remove "syntax_error" decl. (yyerror): Adjust. Make this function static, too. <policy>: Adjust the sole rule that used it.
commit 3c5b2840f6ef9d562ef12299f1cd6d7442a3f1a0 Author: Jim Meyering meyering@redhat.com Date: Wed Oct 20 10:20:33 2010 +0200
mark unused parameters as such
commit 0c4fa8c07b57aa79f89a371231d98b01162d3e12 Author: Jim Meyering meyering@redhat.com Date: Wed Oct 20 09:25:33 2010 +0200
remove decls of unused variables
commit 398c516c99ae513d259767af4b6e91701aeec2ad Author: Jim Meyering meyering@redhat.com Date: Tue Oct 19 18:27:52 2010 +0200
automatically generate man page
* configure.ac (AC_CONFIG_FILES): Add man/Makefile. Check for help2man. * Makefile.am (SUBDIRS): Add "." and man. * man/Makefile.am: New file. * .gitignore: Ignore new artifacts and anchor patterns. * iwhd.spec.in (%files): Add man page file name.
commit 3a8570e05e1e906435c97f456150ec8683b35c91 Author: Jeff Darcy jdarcy@redhat.com Date: Tue Oct 19 21:10:49 2010 -0400
Fix two pipe-initialization races that occur in replication.
Turns out there were two race conditions, either of which could lead to a replication task hanging. In the first, the consumer thread could potentially run before the pipe_shared structure was re-initialized in the producer. In the second, the producer could post the first chunk before the consumer initialized its pipe_private, so the sequence numbers would be off. That's kind of ironic, since the sequence number isn't strictly necessary and is only there to guard against a whole different class of synchronization problems (for which purpose I think it should remain). Here's a brief summary.
* replica.c: moved re-initialization of pipe_shared to be before thread start (race #1) * mpipe.c: changed initialization of pp->sequence in pipe_init_private (race #2) * iwh.h: added PID to DPRINTF to distinguish parent/child output * backend.c: fixed bytes==0 behavior in fs_put_child (unrelated) * rest.c: fixed pipe_prod_wait_init check in proxy_put_data (unrelated)
commit e8e1e84c9af5996630f65b9bf0b9dbe1108092e9 Author: Jeff Darcy jdarcy@redhat.com Date: Tue Oct 19 20:59:33 2010 -0400
Undo accidental reversal of wait_for_repl return values.
commit 8e27a1a5623d6fe674ebcaefa5ae43cae372873f Author: Jim Meyering meyering@redhat.com Date: Thu Oct 7 13:44:31 2010 +0200
add iwhd.spec.in and Makefile rules
With these, you can now run "make rpm" to invoke rpmbuild on a just-created tarball.
commit 0317fd51b2994b9c512122ce97092fd3d0252ffc Author: Jim Meyering meyering@redhat.com Date: Mon Oct 18 16:36:45 2010 +0200
avoid NULL deref on failed strdup
* qlexer.l: Don't dereference NULL on failed strdup.
commit d28494103e69b75ca5a242b09eb761570d15f930 Author: Jim Meyering meyering@redhat.com Date: Mon Oct 18 16:24:39 2010 +0200
xrealloc was not used; #if-0 it out
commit 2d0b629e6cf361f18e660df7419c66ae61c56355 Author: Jim Meyering meyering@redhat.com Date: Mon Oct 18 14:02:33 2010 +0200
now that lexer calls strdup, free those strings
commit 136c20fc5c20bc053f86c643d2863d8ceb116dac Author: Jim Meyering meyering@redhat.com Date: Mon Oct 18 12:37:57 2010 +0200
qlexer.l: rewrite not to need static var, at_eof.
commit 7a1642252d00263da1b36237661fb310f9d9cee7 Author: Jim Meyering meyering@redhat.com Date: Mon Oct 18 12:31:33 2010 +0200
handle yylex_init failure
commit 8da2bda33280f84f2a209be74f3cb4abd9798ef9 Author: Jim Meyering meyering@redhat.com Date: Mon Oct 18 12:20:45 2010 +0200
pure, almost
commit 61be1a9c7d0e2756613470fb82e285c980635950 Author: Jim Meyering meyering@redhat.com Date: Mon Oct 18 11:16:05 2010 +0200
add beginnings of %union support
commit 319d8c1f35ff61956c5c319976b81fed70b24267 Author: Jim Meyering meyering@redhat.com Date: Mon Oct 18 11:01:54 2010 +0200
query.h: use struct value_t (same name as typedef)
This is required to allow bison to parse the incoming %union decl.
commit cc926cc887f194d8ec7c97e7905baa669fff185e Author: Jim Meyering meyering@redhat.com Date: Mon Oct 18 10:55:19 2010 +0200
add missing #define part of double-inclusion guard
commit c366f6de5cb002e3306197e8ef2249b3120c635b Author: Jim Meyering meyering@redhat.com Date: Mon Oct 18 10:16:44 2010 +0200
lex && and || as tokens, not "&" and "|"
There is no point in allowing spaces between the bytes of these operators.
commit 8d267f6f44e8c64623f66dfbb73673297c2514d5 Author: Jeff Darcy jdarcy@redhat.com Date: Fri Oct 15 12:01:20 2010 -0400
Add query.h comments back in.
commit b3302bb0a5b82689d8c890cc703fd0efc55512b8 Author: Jim Meyering meyering@redhat.com Date: Fri Oct 15 15:07:19 2010 +0200
build: ensure we use only Flex
commit 43e90569e516a77ed71bc2d568e8a25e2e1bc15d Author: Jim Meyering meyering@redhat.com Date: Fri Oct 15 14:24:21 2010 +0200
qlexer.l: simplify
* qlexer.l: Include <config.h> first. Use a few %options. Use <<EOF>> rather than yywrap.
commit 172ce552307317456a644868ad02aba5b3528ba8 Author: Jim Meyering meyering@redhat.com Date: Fri Oct 15 13:05:44 2010 +0200
avoid undefined-yydecl warning
commit 66864937990bf7de81e6e5e2fba6ebf521f109c3 Author: Jim Meyering meyering@redhat.com Date: Thu Oct 14 18:00:11 2010 +0200
use literals in bison
commit e1f97c75f4afa180643691324fa0552877fd8454 Author: Jim Meyering meyering@redhat.com Date: Thu Oct 14 17:01:43 2010 +0200
static and const
commit cddd16da84f4beb975f9e96546ea7ad1a6557fb8 Author: Jim Meyering meyering@redhat.com Date: Thu Oct 14 16:43:06 2010 +0200
cast away "const" on free argument
commit 31e05f1f8045bd38d47eeacfd09a4c27895b10db Author: Jim Meyering meyering@redhat.com Date: Thu Oct 14 16:41:36 2010 +0200
qparser.y: Include <ctype.h> for use of isdigit
commit 90c6359047186d03e04a4e73e99d0c935e40be1a Author: Jim Meyering meyering@redhat.com Date: Thu Oct 14 16:16:24 2010 +0200
apply Jeff's link-following change
commit 41f6621794a607e2a8a5940d6fb2be22746d2cf1 Author: Jim Meyering meyering@redhat.com Date: Thu Oct 14 16:07:33 2010 +0200
apply jeffs leak-fixing patch from master (manually merge 3 failed hunks)
commit 9d0990a469ada32886e0c09e98da498a5106b2fd Author: Jim Meyering meyering@redhat.com Date: Thu Oct 14 16:02:08 2010 +0200
parse-test now passes
commit 19f9c826b6a2e6ad5dc51f1e1c4030f1eac82553 Author: Jim Meyering meyering@redhat.com Date: Fri Oct 15 14:50:59 2010 +0200
build: rearrange things to use Bison/Flex; adapt; clean up
commit 5ed3c7cb77b0d921759f9407dd17dbb9b2b54ba3 Author: Jim Meyering meyering@redhat.com Date: Thu Oct 14 16:54:58 2010 +0200
remove query.leg and query.c.diff
* query.c.diff: Remove file. * query.leg: Likewise.
commit fd0cbe4410ec2b1ad831e418b472cc46fd4cacaf Author: Jeff Darcy jdarcy@redhat.com Date: Tue Oct 12 17:18:16 2010 +0200
rewrite query parser using Bison, not peg/leg
* qparser.y: New file. * qparser.l: New file.
commit 9ca9c3d6bdd3d210b5c58fca4bc9c63aacbea78d Author: Jim Meyering meyering@redhat.com Date: Tue Oct 19 19:24:08 2010 +0200
tests: don't clutter regular output with expected diagnostics
* t/init.cfg (wait_for): Emit common diagnostic to log, not tty.
commit d003a5d273b985ea3135cbd34c139191d394d8ac Author: Jim Meyering meyering@redhat.com Date: Tue Oct 19 19:02:08 2010 +0200
clean-up: move file-scoped global into "main"
* rest.c (main): Move "autostart" into main.
commit 5a88451cf5e0e69635a9dc4eacbb7f2606256fcc Author: Jim Meyering meyering@redhat.com Date: Tue Oct 19 16:52:17 2010 +0200
tests: avoid using a temp file in wait_for_repl utility
* t/replication (wait_for_repl): Use a variable rather than a temporary file.
commit 32a041e25d2c1c9d6e4c353ce8db6649aed62954 Author: Jim Meyering meyering@redhat.com Date: Tue Oct 19 16:50:57 2010 +0200
tests: wait_for: report how long we waited, or that timeout expired
* t/init.cfg (wait_for): Tell how long we wait.
commit 5372c8c2f472846e480b44c498aae3177038949a Author: Jim Meyering meyering@redhat.com Date: Tue Oct 19 16:17:13 2010 +0200
fflush debugging output when writing to stdout
* iwh.h (DPRINTF): Call fflush.
commit a10711d0124f8130ea0339dbc34d0bfd06cbb815 Author: Jim Meyering meyering@redhat.com Date: Tue Oct 19 16:11:45 2010 +0200
replica: don't say we're "deleting" when creating a bucket
* replica.c: Include "replica.h". Correct a misleading debug print statement.
commit 5f3562c3efe50314a708094b19641ba282b35b6a Author: Jim Meyering meyering@redhat.com Date: Mon Oct 18 20:23:29 2010 +0200
init.sh: don't comment out cleanup-handling rm -rf
commit fc5ba187804f575cd4272d77ec54d0814c9fa6a9 Author: Jeff Darcy jdarcy@redhat.com Date: Mon Oct 18 13:45:48 2010 -0400
Unify backend/replica modules, support dynamic config.
Now rest.c and replica.c use only backend.c functions to get/put/delete files and create buckets, without knowledge of or regard for what types of back ends are involved. In addition:
unused fields/globals (e.g. s3mode, proxy_*) have been removed; headers have been tweaked a bit; reference counting on my_state structures; fixed a bug when re-replicating a file that already exists.
commit cfa0553caaeea30e5b542ca9f91b69244d07d709 Author: Pete Zaitcev zaitcev@yahoo.com Date: Sat Oct 16 17:17:44 2010 -0600
add static to parse_config_inner
This suppresses a warning about missing prototype.
commit 57bfee81c42c26eac3299404738bdd06bed5f4f8 Author: Pete Zaitcev zaitcev@yahoo.com Date: Sat Oct 16 16:42:12 2010 -0600
switch to atexit(auto_stop)
The main impetus for this change is that query.peg has an error() that can exit. However, we cannot add an explicit auto_stop in front of it, because the parser is also linked into tests, which do not have autostart code and thus throw a link error.
Secondarily, since atexit() is only called when the start of Mongo is assured, we do not really need checking for PID being valid or any other scheme to disable auto_stop in the child, etc. We're not changing this for now, but maybe later.
commit d82854a5c8cbc35897fe931376cff1e7f446c953 Author: Jim Meyering meyering@redhat.com Date: Thu Oct 7 14:02:08 2010 +0200
avoid warning about signed/unsigned comparison
commit c947ab61da94a8f85844bc85f061105aa1c6e1b4 Author: Jim Meyering meyering@redhat.com Date: Thu Oct 7 14:01:29 2010 +0200
build: avoid warning about unused parameter
commit 7fb8264a528a19fd999dc4626121c2d6427d437d Author: Jeff Darcy jdarcy@redhat.com Date: Wed Oct 13 16:08:39 2010 -0400
Add link-following implementation (not just syntax).
Also fixed parser main() so that mainline can pass tests modified to suit an unposted version.
commit 8f3bc25341e2a212e3497028d59ff6a5f3527445 Author: Jim Meyering meyering@redhat.com Date: Wed Oct 13 21:30:12 2010 +0200
tests: add missing "Exit $fail"
commit bb9ae00fcc2c84440108054ceb0ea33bafda5cf4 Author: Jim Meyering meyering@redhat.com Date: Wed Oct 13 21:22:49 2010 +0200
tests: parser-test: don't ignore "compare" failure
commit 436ce690c6dca730f9fdf6e3cd831d53c48ab474 Author: Jeff Darcy jdarcy@redhat.com Date: Wed Oct 13 14:06:00 2010 -0400
New tests for autostart and "headless operation"
t/Makefile.am: added new "auto" test t/auto: new t/basic: added headless test, fixed bug in waiting for mongod to start t/init.cfg: changed ports we use to avoid the mongo/auto defaults auto.c: added --pidfilepath so tests can get mongod PID
commit 1b561174b1eca8fe2fca2586313d324d19e08dd9 Author: Jeff Darcy jdarcy@redhat.com Date: Wed Oct 13 15:12:27 2010 -0400
Fix rollup which didn't include renamed/added files.
commit 0f82ac4e7c2cfbfe18a58f89b5543ca8e64290ba Author: Jeff Darcy jdarcy@redhat.com Date: Wed Oct 13 10:16:03 2010 -0400
Dynamic config, steps 1-3
(rollup of previous patches to keep commits buildable)
Generate provider_t structures at init instead of on demand Change non-setup code to use provider_t instead of JSON calls get_provider in rest.c (provider list/update) get_provider_value in backend.c (EC2 bundling) get_provider_value in query.leg (policy eval) many in proxy.c (replication) Split proxy.c into setup.c and replica.c Propagate const changes where needed Reconcile with autostart changes
commit c63dfdc7d21bc0bd221777621a7649552a8aa40f Author: Jeff Darcy jdarcy@redhat.com Date: Tue Oct 12 12:34:27 2010 -0400
Fix a memory leak in object-attribute evaluation (found by Jim).
commit 491344e55d77c754a8adb70a178bdbef4578675b Author: Pete Zaitcev zaitcev@yahoo.com Date: Tue Oct 12 13:14:51 2010 -0600
[patch repod] add autostart of Mongo
We would like to start the required database instance automatically, so that it does not need to be configured. Naturally doing is requires certain assumptions, in particular where the database is located (we assume that it is in a subdirectory _db/ of the current directory).
This version of the patch attempts to stop the database that we launched.
commit 982febea642d47a7286ce0dc4602df629c2d8626 Author: Jim Meyering meyering@redhat.com Date: Tue Oct 12 16:53:06 2010 +0200
tests: use -9 only when killing mongod, not iwhd
Otherwise, a valgrind wrapper around iwhd would not generate much of its results.
commit de1daf159adbe9475f350d6d0d7a3183864bced8 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Oct 7 17:29:18 2010 -0400
Improve behavior in no-metadata-access cases.
Stage 2: proxy_get_data actually does "the right thing" and we now have a producer/consumer handshake for the GET direction as well as PUT.
commit 39621d061ca5f31f0b2cfdf4acfa124119f4759d Author: Jeff Darcy jdarcy@redhat.com Date: Thu Oct 7 16:10:48 2010 -0400
Allow simple GETs without metadata access.
First stage: meta.cpp functions handle lack of connection better.
commit e085aab9a4664efad596e4177443c94125fd0aac Author: Jim Meyering meyering@redhat.com Date: Mon Oct 11 22:50:57 2010 +0200
template: const correctness
* template.c (xml_format, json_format): Declare const. (xml_obj_header, xml_obj_entry, xml_obj_footer): Likewise. Adjust all uses of ctx->format accordingly. * template.h [struct tmpl_format_t] (format): Declare const.
commit c9e88edd5d31c8b3465af9558d424b329d483812 Author: Jim Meyering meyering@redhat.com Date: Mon Oct 11 22:47:39 2010 +0200
query.c.diff: regenerate to avoid offsets
commit f1159957b064f94c07f7c7feca363172f2834e19 Author: Jeff Darcy jdarcy@redhat.com Date: Fri Oct 8 14:36:37 2010 -0400
Fix BsonObject invalid-ref in attribute-listing code.
commit 4d36d7cb21c43eab39f90ac1b949a84abf1a9cea Author: Jeff Darcy jdarcy@redhat.com Date: Thu Oct 7 13:43:02 2010 -0400
Add comments to parsing/evaluation code.
commit 10c20c718924cdc340cd77f8134a39c27c0027bd Author: Jeff Darcy jdarcy@redhat.com Date: Wed Oct 6 17:05:12 2010 -0400
Add op=parts API.
template.*: renamed _obj stuff to _list for bucket listings added new _obj stuff for listings of object parts state_defs.h: added aquery field for attribute queries meta.*: added attribute-query functions rest.c: added code and dispatch for new API
commit af9442a8cc25dd8b0c4df858a9d3543ce3b667e3 Author: Jim Meyering meyering@redhat.com Date: Wed Oct 6 10:15:54 2010 +0200
tests: remove seemingly unnecessary "sleep 3"
* t/replication (cleanup_): Don't sleep for 3 seconds. * t/replication (cleanup_): Kill with -9, to avoid diagnostics from init.sh's cleanup (rm -rf) process when it takes too long for mongod to handle the signal. * t/basic (cleanup_): Likewise.
commit 9d18678eedbf2fd1f95f16a4756654ae6dea86bd Author: Jim Meyering meyering@redhat.com Date: Wed Oct 6 10:14:31 2010 +0200
tests: factor out range of ports we'll use for mongod instances
* t/init.cfg (mongo_base_port): Define. * t/replication: Use $mongo_base_port. * t/basic (m_port): Define/use, as in t/replication. Remove "FIXME" comments, now that each test starts its own, independent mongod instance.
commit bcd8e34f8c259e7f32f85ad96cfbc147c1d0697e Author: Jeff Darcy jdarcy@redhat.com Date: Wed Oct 6 11:28:11 2010 -0400
Fix replication test when *not* running in parallel.
commit 764a77b949627d4466a762e307a2fbf8ff8b577c Author: Jeff Darcy jdarcy@redhat.com Date: Wed Oct 6 09:59:12 2010 +0200
tests: run 2nd test's mongod on a different port for parallel make check
With the addition of this second mongod-running test script, "make -j2 check" would often fail. * t/replication: Each test script must run mongod on a different port so that all may be run in parallel.
commit eca524a8875390971df31e8c6e695638d7feffe6 Author: Jeff Darcy jdarcy@redhat.com Date: Tue Oct 5 13:07:12 2010 -0400
Add replication tests.
commit ed1124e42e3767ea31fc06226ab526e7bf3f4cdc Author: Jeff Darcy jdarcy@redhat.com Date: Tue Oct 5 13:06:27 2010 -0400
Add rep_count control operation on API root.
commit 6b291d8aaeaac24bf4ac44ef9f83db173ed663fc Author: Jim Meyering meyering@redhat.com Date: Wed Oct 6 13:17:22 2010 +0200
tests: remove vestigial VERBOSE=yes
* t/Makefile.am: Don't set VERBOSE=yes here. It's not needed, now that it is set in GNUmakefile.
commit 688f1ee40a27f38bc410f23bfb9e3b2a1feed6a0 Author: Jim Meyering meyering@redhat.com Date: Tue Oct 5 17:07:25 2010 +0200
tests: exercise the parser
* t/Makefile.am: Add rules/code to generate parser.c and to run the new test. * t/parser-test: New file. I/O pairs from Jeff Darcy.
commit d64add4185ab48f67c70dff941e0143aa72fe0ae Author: Jeff Darcy jdarcy@redhat.com Date: Tue Oct 5 14:23:58 2010 -0400
tests: exercise attributes
commit e914cb511e8785deef50a3c711d674ac056a697e Author: Jim Meyering meyering@redhat.com Date: Tue Oct 5 19:21:46 2010 +0200
fix bug just introduced in repl_worker
* proxy.c (repl_worker): Don't omit "item" parameter in call to pthread_create. Introduced by me in commit aeb23797. Spotted by Jeff Darcy.
commit 2f781a55e1966f19e2d8a9ed7fd2958563e3b9d4 Author: Jeff Darcy jdarcy@redhat.com Date: Mon Oct 4 13:30:01 2010 -0400
More basic tests.
Added some through-the-API result checking to cover metadata. Added a duplicate-bucket test.
commit 5e4e136deec466074117525ba672618d2445dbe1 Author: Jeff Darcy jdarcy@redhat.com Date: Mon Oct 4 11:47:47 2010 -0400
Enhance tests.
Added failure check for "PUT to root" test. Added "-s -S" to curl commands to kill silly progress bars. Added rdbuf call in meta.cpp to silence C++ code.
commit 4866f4e6b9f3c966170f349eb6db74d2ff2d1692 Author: Jim Meyering meyering@redhat.com Date: Tue Oct 5 14:05:56 2010 +0200
build: GNUmakefile: new file, for better output from "make check"
This file is used only via GNU make. For now, its main purpose is to ensure that VERBOSE=yes is always set in the environment. That ensures more useful output from "make check" and that automake-generated code in Makefile prints more details upon failure.
A tiny bonus: you also get a diagnostic when running "make" without a configure file.
commit aeb23797cf2e1e8ce6d57ec341235d48abb05e2f Author: Jim Meyering meyering@redhat.com Date: Tue Oct 5 08:02:00 2010 +0200
don't ignore failed thread creation
* proxy.c (xpthread_create): New macro. (repl_worker): Use it to diagnose thread creation failure and to propagate any failure to caller.
commit 64c29da2559a084d3ba74dcdaa03cbd0f4189dee Author: Jim Meyering meyering@redhat.com Date: Tue Oct 5 07:44:29 2010 +0200
proxy.c: declare functions and file-scoped variables static
commit 6c2fe0153226238cdf342e13333cec65a2b769d0 Author: Jim Meyering meyering@redhat.com Date: Fri Oct 1 16:01:20 2010 +0200
don't ignore write failures
* proxy.c (junk_writer): Don't ignore fwrite failure. Warn upon fwrite or fflush failure. * rest.c (main): Don't ignore fflush failure. Exit upon fflush or preceding printf failure.
commit 9b68844bac11d8d0737c74986ca6add744acd223 Author: Jim Meyering meyering@redhat.com Date: Fri Oct 1 19:57:52 2010 +0200
declare file-scoped globals "static"; use const, too
commit dded28ea3564271e258d14014dd6089f2bfa7cda Author: Jeff Darcy jdarcy@redhat.com Date: Fri Oct 1 13:04:44 2010 -0400
Fix various issues in policy syntax.
Made AND/OR properly associative/recursive. Gave NOT lower precedence than comparisons. Simplified field/link_field parsing. Generally improved whitespace handling. Updated diff to match other changes.
commit b49e121de992338353ccb8427b3e557ef73603cc Author: Jeff Darcy jdarcy@redhat.com Date: Fri Oct 1 12:11:23 2010 -0400
Fix memory leak, uninit var, syntax
Another ms leak in proxy_get_attr Uninitialized variable in repl_oget Whitespace issues in policy syntax
commit 89c0b8cace3fe481792e1380e620ac68b060963a Author: Jeff Darcy jdarcy@redhat.com Date: Fri Oct 1 12:08:31 2010 -0400
New version reflecting current reality/terminology/etc.
commit 69e5866ad141e535969075fccabcd73f2598a721 Author: Jim Meyering meyering@redhat.com Date: Fri Oct 1 19:05:25 2010 +0200
maint: adjust copyright on most files: Red Hat, not FSF
commit 08ea30e37e29169d6b0ab9a1395d54262f3319af Author: Jim Meyering meyering@redhat.com Date: Fri Oct 1 18:51:00 2010 +0200
boiler-plate README files
commit 4b78090d0043367ed7a408aa3f04615c4700f12a Author: Jim Meyering meyering@redhat.com Date: Thu Sep 30 13:58:27 2010 +0200
maint: remove empty/unused ChangeLog file
commit a2bb964aed893e8d4e86fe165244352b2a1746c2 Author: Jim Meyering meyering@redhat.com Date: Wed Sep 29 22:26:22 2010 +0200
tests: add more
commit 8a480375b7d4a48ea3c3d76b6a2b8eb6b202e3ab Author: Jim Meyering meyering@redhat.com Date: Wed Sep 29 15:13:12 2010 +0200
remove unnecessary casts
commit 94932e139d8d58cab65114d340dcf0c201eab125 Author: Jeff Darcy jdarcy@redhat.com Date: Tue Sep 28 21:03:43 2010 -0400
Fix leak when deleting nonexistent file.
commit 1a876712ef22c1b70dc11401884e2ba30c0c90a9 Author: Jeff Darcy jdarcy@redhat.com Date: Tue Sep 28 14:30:00 2010 -0400
Fix ms leaks when object not found, deleted.
commit 10d05a999d53191bc01e82b6a34840ffefef8d95 Author: Jim Meyering meyering@redhat.com Date: Tue Sep 28 21:31:23 2010 +0200
tests: exercise object deletion
commit 2214d5b9c6adb68baabcaffabc73dd02239096b1 Author: Jim Meyering meyering@redhat.com Date: Tue Sep 28 15:12:33 2010 +0200
plug a nasty leak and 3 others like it
* rest.c (proxy_update_prov): Don't leak the state buffer allocated in access_handler. I confirmed that this does plug an actual leak. (proxy_query, proxy_bucket_post, proxy_object_post): These are in the same vein, but were fixed by inspection, since tests don't yet exercise these.
commit 5f1095727aeb9a484c46c3586485e1b89468b06a Author: Jim Meyering meyering@redhat.com Date: Tue Sep 28 14:07:09 2010 +0200
don't leak json_strings on username/password update
* proxy.c (update_provider): Avoid leaks exposed by new test. Valgrind reported this:
78 (72 direct, 6 indirect) bytes in 3 blocks are definitely lost in loss record 246 of 317 at 0x4A0515D: malloc (vg_replace_malloc.c:195) by 0x4C35BD9: json_string_nocheck (in /usr/lib64/libjansson.so.0.2.0) by 0x420DA7: update_provider (proxy.c:1042) by 0x425856: proxy_update_prov (rest.c:1461) by 0x4E3BB38: ??? (in /usr/lib64/libmicrohttpd.so.5.2.1) by 0x4E3CD27: ??? (in /usr/lib64/libmicrohttpd.so.5.2.1) by 0x4E3F9F9: ??? (in /usr/lib64/libmicrohttpd.so.5.2.1) by 0x31BB407760: start_thread (pthread_create.c:301) by 0x31BA8E151C: clone (clone.S:115)
78 (72 direct, 6 indirect) bytes in 3 blocks are definitely lost in loss record 247 of 317 at 0x4A0515D: malloc (vg_replace_malloc.c:195) by 0x4C35BD9: json_string_nocheck (in /usr/lib64/libjansson.so.0.2.0) by 0x420DDA: update_provider (proxy.c:1043) by 0x425856: proxy_update_prov (rest.c:1461) by 0x4E3BB38: ??? (in /usr/lib64/libmicrohttpd.so.5.2.1) by 0x4E3CD27: ??? (in /usr/lib64/libmicrohttpd.so.5.2.1) by 0x4E3F9F9: ??? (in /usr/lib64/libmicrohttpd.so.5.2.1) by 0x31BB407760: start_thread (pthread_create.c:301) by 0x31BA8E151C: clone (clone.S:115)
commit c46547610682271c08d970fb927c83e523491b41 Author: Jim Meyering meyering@redhat.com Date: Tue Sep 28 13:49:32 2010 +0200
tests: exercise basic providers_ functionality
commit bc81e99ff8ea7f910ee48be11c4aca485794ec6f Author: Jim Meyering meyering@redhat.com Date: Tue Sep 28 10:32:45 2010 +0200
don't end "error(..." diagnostic with "\n"
Fix them all by running this command: git grep -l 'error.*\n'|xargs perl -pi -e 's/(\berror ?(.*)\n"/$1"/'
commit fe98d54da3f5f78667d2ca1a766fd9d8a3f31aa1 Author: Jim Meyering meyering@redhat.com Date: Mon Sep 27 18:29:35 2010 +0200
tests: don't let ~/.curlrc settings perturb these tests
Quiet the wait_for use of curl.
commit 32c6ca985e228c7db3968a8bdcd4f33006a6f854 Author: Jim Meyering meyering@redhat.com Date: Mon Sep 27 18:29:35 2010 +0200
tests: check for root xml and json
Adjust test not to "cd FS".
commit ca56bd601ea8e0544c1830ac0ba95c7c76332b05 Author: Jim Meyering meyering@redhat.com Date: Mon Sep 27 18:24:11 2010 +0200
tests: remove unnecessary "kill..." stmt, now it's done via trap
commit 9724d076a990c61f39578f1ff828507e0ba195ad Author: Jim Meyering meyering@redhat.com Date: Mon Sep 27 16:57:57 2010 +0200
don't deref NULL on fdopen failure; plug a FILE-sized leak
* proxy.c (proxy_repl_cons, proxy_repl_prod): Handle fdopen failure and don't leak a FILE buffer.
commit a65eb158f5ade6b5e1dda87ba0495612a13d5f36 Author: Jim Meyering meyering@redhat.com Date: Mon Sep 27 18:24:11 2010 +0200
tests: specify "path", now that it's required
Adjust test, now that buckets are created under ./FS
commit ab3e12cc1a3946af2cc1e0f9bde39d73f01c4c24 Author: Jeff Darcy jdarcy@redhat.com Date: Mon Sep 27 20:35:03 2010 -0400
Just use chdir instead of chroot+chdir, per email convo.
commit 2b2804d90e7837718303b3e119f00d5e00eb9217 Merge: 53982480742f385905cb80eaccd06722d0f202c4 00fb9bc78433a89a3869c274e959d8728c6e1b37 Author: Jeff Darcy jdarcy@redhat.com Date: Mon Sep 27 20:24:23 2010 -0400
Merge branch 'master' of ssh://orcz/srv/git/iwhd
commit 00fb9bc78433a89a3869c274e959d8728c6e1b37 Author: Jim Meyering meyering@redhat.com Date: Mon Sep 27 16:12:27 2010 +0200
rest.c: plug a leak
* rest.c (proxy_create_bucket): Free "ms" here, too, so as not to leak the state buffer allocated and dispatched in access_handler.
496 bytes in 1 blocks are definitely lost in loss record 270 of 288 at 0x4A0515D: malloc (vg_replace_malloc.c:195) by 0x42700C: access_handler (rest.c:1603) by 0x4E3BB38: ??? (in /usr/lib64/libmicrohttpd.so.5.2.1) by 0x4E3D087: ??? (in /usr/lib64/libmicrohttpd.so.5.2.1) by 0x4E3F9F9: ??? (in /usr/lib64/libmicrohttpd.so.5.2.1) by 0x31BB407760: start_thread (pthread_create.c:301) by 0x31BA8E151C: clone (clone.S:115)
commit 53982480742f385905cb80eaccd06722d0f202c4 Author: Jeff Darcy jdarcy@redhat.com Date: Mon Sep 27 11:17:03 2010 -0400
Require a "path" parameter for filesystem back ends.
This includes checking for existence of the parameter, doing a chroot/chdir in fs_init, and disallowing sneaky "../" escapes. The path can be relative (handy for development) but you shouldn't be able to traverse out of it.
commit bba237a9d3d15caf36736a28ec0669329bace040 Author: Jim Meyering meyering@redhat.com Date: Mon Sep 27 15:52:06 2010 +0200
use calloc in place of malloc+memset-0
commit 349f72d5faab412250d83d8c0bca5e7d620c46f3 Author: Jim Meyering meyering@redhat.com Date: Tue Sep 21 20:57:36 2010 +0200
tests: add test framework and first test
commit 94430296b2b7a2c5722e1290fd05e7e494d63baf Author: Jim Meyering meyering@redhat.com Date: Wed Sep 22 23:19:58 2010 +0200
hoist definition of cmd to remove one more hard-coded "dc-register-image"
commit 4e714bbe7007b5bacecec4dca34dde36fe9c73fc Author: Jim Meyering meyering@redhat.com Date: Mon Sep 27 11:28:25 2010 +0200
maint: use new iwhd-devel address as bug-reporting addr
* configure.ac (AC_INIT): Now that we have an email address, use it as the package bug-reporting address.
commit bedf9e129597380eb865de17abe3245d90076158 Author: Jim Meyering meyering@redhat.com Date: Sat Sep 25 09:27:44 2010 +0200
avoid printf format abuse; use -Wformat-security; report errno more
A use like "error(0,errno,cfg_file)" would malfunction for a file name containing a printf %-directive. Using -Wformat-security will help prevent this.
Upon OOM, always use errno in the diagnostic.
commit d40ae99163994b6995a16505ae590399fa416b1e Author: Jeff Darcy jdarcy@redhat.com Date: Fri Sep 24 11:58:56 2010 -0400
Fix string handling in proxy (replication) module.
Mostly sprintf->snprintf, with checks. Also using constants now for buffer lengths.
commit cf6f65ebfac1a6c59aae0251896a067bac1220ef Author: Jeff Darcy jdarcy@redhat.com Date: Fri Sep 24 10:43:54 2010 -0400
Replace fprintf/perror calls with officially mandated error().
commit ba702e788612453e387acd30efedf4ead738eb65 Author: Jim Meyering jim@meyering.net Date: Fri Sep 24 15:53:43 2010 +0200
More const changes.
commit 27c25ba8d9cff693b28a67ecdd3862fef5d4e3b6 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Sep 23 14:02:40 2010 -0400
Add replication for bucket-create requests.
Split replicate_namespace_action from replicate_delete. Modified replicate_delete and (new) replicate_bcreate to use replicate_namespace_action. Added repl_worker_bcreate, REPL_BCREATE, plumbing to hook it up.
Fixed uninitialized-URL bug in repl_worker_del. Fixed memory leak in repl_worker_del. Added meta_got_copy call in proxy_repl_cons.
commit b6702e9012c1f0d74bf09d9479bc2e4d07235017 Author: Jim Meyering meyering@redhat.com Date: Fri Sep 24 10:25:15 2010 +0200
build: m4-quote use of AC_LANG_PROGRAM to avoid warning from new autoconf
Using autoconf-2.68 would evoke many new warnings like this:
configure.ac:78: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from... ../../lib/autoconf/general.m4:2591: _AC_COMPILE_IFELSE is expanded from... ../../lib/autoconf/general.m4:2607: AC_COMPILE_IFELSE is expanded from... ../../lib/m4sugar/m4sh.m4:606: AS_IF is expanded from... ../../lib/autoconf/general.m4:2032: AC_CACHE_VAL is expanded from... ../../lib/autoconf/general.m4:2053: AC_CACHE_CHECK is expanded from... ax/ax_boost_thread.m4:35: AX_BOOST_THREAD is expanded from... configure.ac:78: the top level
Autoconf was unable to detect the existing use of AC_LANG_SOURCE because it was underquoted. Fix that.
* ax/ax_boost_system.m4: Quote use of AC_LANG_PROGRAM. * ax/ax_boost_thread.m4: Likewise.
commit a37a958aa1901ff3cc7d0b79fbe0d8058c4930db Author: Jim Meyering meyering@redhat.com Date: Fri Sep 24 09:38:05 2010 +0200
build: boost support: don't depend on C++-mangled names
The mangled names were missing from rawhide's libraries, so all library existence tests would fail.
* configure.ac: Use AX_BOOST_ macros instead. Don't check for boost's filesystem or program_options libraries. They were not being used. * ax/ax_boost_base.m4: New file. * ax/ax_boost_system.m4: New file. * ax/ax_boost_thread.m4: New file. * Makefile.am (ACLOCAL_AMFLAGS): Point aclocal at the new dir, ax/ (iwhd_LDADD): Adjust substituted names to match those defined by the new AX_ macros.
commit d7ccb4fda632e2707c21198255e08e3369d9bc88 Author: Jim Meyering meyering@redhat.com Date: Thu Sep 23 18:50:22 2010 +0200
configure.ac (AC_INIT): Use iwhd as package name, not image-warehouse.
commit e7293008351aa4018aa565f865d536b133e930e6 Author: Jim Meyering meyering@redhat.com Date: Thu Sep 23 16:24:53 2010 +0200
remove trailing blanks
commit 1ddb0a9455890c6e66e27292d16c8839368018f7 Author: Jim Meyering meyering@redhat.com Date: Thu Sep 23 16:19:13 2010 +0200
Add Copyright comments, and regenerate query.c.diff
commit 713eef0ae9e22c73b02ec33dfd88126f9fe78389 Author: Jim Meyering meyering@redhat.com Date: Wed Sep 22 21:47:06 2010 +0200
FS backend: print better diagnostics
I.e., print program_name: as well as the offending FS object when possible, not just a syscall name and strerror. Before: mkdir: File exists After: iwhd: b4: failed to create directory: File exists
* backend.c (s3_put_child, s3_init_tmpfile, s3_register) (curl_put_child, fs_get_child, fs_put_child, fs_delete) (fs_bcreate): Use error() in place of perror/f?printf.
commit df7d24b7af937f09ae12c315c933f5073c8206a4 Author: Jeff Darcy jdarcy@redhat.com Date: Wed Sep 22 15:47:12 2010 -0400
Added _providers to API-root listing. Fixed bug in form-data handling, which affected calls to attribute-put and query functions. Added debug output when we can't parse a query string.
commit e45376ee92057a8db6cdc364e2981240d6817097 Author: Jim Meyering meyering@redhat.com Date: Wed Sep 22 20:08:00 2010 +0200
don't declare free'd variables/params to be const
commit c50990b6720b80e31ae13461a2959502d5cb2650 Author: Jeff Darcy jdarcy@redhat.com Date: Wed Sep 22 11:58:45 2010 -0400
More changes suggested by Jim, made by me - const pointers, unsigned ints, and so on.
commit 0ee197d7faf98e2bdb038cb3aae51bbced7992ad Author: Jim Meyering meyering@redhat.com Date: Wed Sep 22 08:07:12 2010 +0200
build: drop -Wshadow(for now) and turn off -Wunused
commit 013d172a863ac1d21cd3d48cd5cbf146e0052362 Author: Jeff Darcy jdarcy@redhat.com Date: Tue Sep 21 16:59:56 2010 -0400
More warning suppression, regenerated query.c.diff
commit c2b25713450724aa667de079b3a4ba0ca4c6013c Author: Jeff Darcy jdarcy@redhat.com Date: Tue Sep 21 14:22:44 2010 -0400
The long-promised type cleanup. Eval always returns 0 or 1. String_value always returns a string. Other ints are handled mostly in compare (which is a bit ugly). The unit-test code has been updated to allow testing the link syntax.
commit 53480dba464f315dba68b682948a086a87896d37 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Sep 16 14:39:14 2010 -0400
First piece of link-following syntax. Still needs type clean-up.
commit f66a5492fb79b975a3c48d172fd209e9d972cbfc Author: Jeff Darcy jdarcy@redhat.com Date: Tue Sep 21 12:42:30 2010 -0400
Changed previous API-change patch so that old and new bucket-creation methods use common code, and so that the new (POST to _new) method doesn't kick in for a regular bucket.
commit 7ce5f783e5249c151fc62d073fc081410db4ee0a Author: Pete Zaitcev zaitcev@redhat.com Date: Tue Sep 21 09:53:03 2010 -0600
Cleanups
I make printouts slightly differ, so that the exact place can be found easier.
The in_init is not likely to be dropped, so kill TBD.
The TBD for pipe_cons_signal became incorrect since fs backend reports errors through it (in case volume is full or disc error).
commit 5f1211b28cc8985c4a610269b3a23d3dc57f45c6 Author: Pete Zaitcev zaitcev@redhat.com Date: Tue Sep 21 09:52:56 2010 -0600
Implement documented API for _new
This patch does two things:
1. implements the documented way to create buckets with POST and "name=bucket" in data. The legacy way with PUT and path is kept for now.
2. checks against creating buckets with reserved names, e.g. if someone does POST and name=_default. Letting people do that leads to some fun miscief, so don't.
commit 6826429634d35af3f8c627548edcf5f0152a76e9 Author: Pete Zaitcev zaitcev@redhat.com Date: Tue Sep 21 09:52:44 2010 -0600
cure a hang on S3 error
If tabled throws an error when iwhd tries to store an object, iwhd hangs forever. There was even a "TBD" marker about it.
An easy way to reproduce this is to store the object into a bucket that does not exist, which is wrong but should not hang iwhd, like so: curl -T moo.data http://localhost:9090/nobucket/object2
Fix is to introduce a concept of consumer that failed. The number of failed consumers is accounted as a "floor" in cons_error, so that the producer and remaining consumers continue to function normally.
This, however makes a transfer to succeed even all replicas failed to store the data. So, once transfer is complete, we look not just at the error code, but also at the error count.
That's the core patch. However, if we just use pipe_cons_signal with an error flag, the Microhttpd first returns "100 Continue" response, and then "500 Internal Server Error". The discussion for the 100-continue suggests that it's a bad idea. We should return any kind of error instead of "100 Continue", or otherwise accept the data. To change that, I added one more handshake with pipe_cons_siginit, that allows us to do this.
This was tested with basic bucket creation and object put/get operations with s3 and fs backends.
commit 05e71fc613490c9a6668b4dfd592cc4192cbe015 Author: Jeff Darcy jdarcy@redhat.com Date: Tue Sep 21 10:57:04 2010 -0400
Make the code buildable again after the last salvo.
commit 1768b3e6a8548f3bea07d40db42385eda567e2ee Author: Jim Meyering meyering@redhat.com Date: Tue Sep 21 13:33:19 2010 +0200
remove useless 'if'-tests-before-free
* rest.c (proxy_put_data): Remove useless if-before-free. * query.leg (free_value): Likewise. * proxy.c (replicate): Likewise.
commit ee5487ed4c8a143b673ef0579d6ff19344a13cdf Author: Jim Meyering meyering@redhat.com Date: Tue Sep 21 10:53:03 2010 +0200
more const-correctness; and remove an unused decl
Also, remove unused decl, meta_query, and its associated typedef.
commit 1e4e5edaec284bef93a344c17003eca010164b09 Author: Jim Meyering meyering@redhat.com Date: Tue Sep 21 10:36:34 2010 +0200
more const-correctness changes
commit 2bc1f9a56405a04ccffc1969a720eaa9bf64a102 Author: Jim Meyering meyering@redhat.com Date: Thu Sep 16 14:26:00 2010 +0200
remove vestige of -f option
* rest.c (main): Remove vestigial "f:" from getopt format string.
commit 6b2df0aafbf9ef39a994a82fa0d70a83acff5340 Author: Jeff Darcy jdarcy@redhat.com Date: Mon Sep 20 15:47:40 2010 -0400
More verbose output for debugging.
commit f5f8c524dffc7a8ac60bfba0bce2201db07179c7 Author: Jeff Darcy jdarcy@redhat.com Date: Mon Sep 20 15:04:50 2010 -0400
Added more detailed tracking of status via ami-id, switched result parsing to use regexes, other changes to facilitate those two.
commit ad3a9a12682fed3a8d41775cf3b04889f0513f97 Author: Jeff Darcy jdarcy@redhat.com Date: Fri Sep 17 14:52:32 2010 -0400
Added ami-bkt argument, fixed output-parsing bug.
commit 24742c32a3ba3c84cdeec160d9f8cd7283fd1b98 Author: Jeff Darcy jdarcy@redhat.com Date: Fri Sep 17 10:50:35 2010 -0400
Fix some memory leaks in the new cert/key temp-file code.
commit 425adbf8a6a5a387bd0ed228e6aeb21225cde7cd Author: Jeff Darcy jdarcy@redhat.com Date: Thu Sep 16 17:31:15 2010 -0400
Take registration information from the request, if available.
commit eba666795095a9ba2aa6debfb1ec3b2215c9a240 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Sep 16 15:30:26 2010 -0400
Set "ami-id" property after registration. Also fixed bug with fetching non-existent attributes.
commit 5b9a52cb44d32a602fc8498e4aaa3f25ea9523e9 Author: Jeff Darcy jdarcy@redhat.com Date: Tue Sep 14 12:14:41 2010 -0400
Last bits to do AMI bundling/upload/registration entirely through the warehouse. Now to clean up all those loose ends.
commit 5d6ba6e4dc02acadd6489678e5d273e078edb79b Author: Jeff Darcy jdarcy@redhat.com Date: Tue Sep 14 10:10:47 2010 -0400
Teach replication module ("proxy.c") how to use a filesystem-backed primary store. Needed for EC2 bundling.
commit 7bf3497d15f7452c6dabcfa198f9994583e96051 Author: Jim Meyering jim@meyering.net Date: Mon Sep 13 14:33:07 2010 +0200
split inadvertently joined declarations; remove trailing spaces
commit 1a0c1c3f97edabde186e08658080de27eb7c9df7 Author: Jeff Darcy jdarcy@redhat.com Date: Fri Sep 10 16:43:06 2010 -0400
Added code to pass registration requests through one or more CURL/HTTP proxies to an S3 back end where registration will actually occur. Bucket, key and next provider name are always provided; kernel and ramdisk IDs will be propagated if present.
commit 88509a97337156470dafd636ccfbf14fc8ca44fa Author: Jeff Darcy jdarcy@redhat.com Date: Fri Sep 10 16:14:49 2010 -0400
More AMI-registration plumbing.
commit 8970f95ffa546f184d392239cd7bcde6770c524f Author: Jeff Darcy jdarcy@redhat.com Date: Fri Sep 10 15:08:36 2010 -0400
Specify filesystem mode in config file instead of command line (needed for AMI-registration work flow).
commit 19729bf5e30f0798399f029f54d489f3497eaca9 Merge: 34553ec469d25eb8b7fa647807090ff5513c028c f15f38c4f971a55b092bc17d0f256deabe9194b0 Author: Jeff Darcy jdarcy@redhat.com Date: Fri Sep 10 14:28:26 2010 -0400
Merge branch 'ec2' into ec2-2
commit f15f38c4f971a55b092bc17d0f256deabe9194b0 Author: Jeff Darcy jdarcy@redhat.com Date: Fri Sep 10 13:59:24 2010 -0400
More EC2-registration changes, including back-end register method and auto-includes.
commit 34553ec469d25eb8b7fa647807090ff5513c028c Author: Jim Meyering meyering@redhat.com Date: Fri Sep 10 19:47:34 2010 +0200
.gitignore: ignore a few more
commit a49b143c4b36a2df2fe0b1be90c7aebc2f4d9e84 Author: Jim Meyering meyering@redhat.com Date: Fri Sep 10 19:30:01 2010 +0200
correct a bug: add ":" after "f" in getopt option spec
Change --fsmode to ---fs-mode (note the three leading hyphens). That is consistent with the fact that this option is now internal-only and not documented. Remove LOC_ID from Usage line, now that that is no longer supported. This also corrects a problem (spotted by Jeff Darcy) with my previous change: it had made it so -f FILE no longer worked.
commit aada69bfcb2f56553ac86a43b9e4ba95bd7c8cff Author: Jim Meyering meyering@redhat.com Date: Fri Sep 10 18:21:43 2010 +0200
require --config=FILE as a command line option
This eliminates two more stray uses of "repo".
commit 4e72dc54a4b360bba6ca0b964283a31be84e1d2d Author: Jim Meyering meyering@redhat.com Date: Fri Sep 10 17:58:02 2010 +0200
rename tool: repod->iwhd, header: repo.h->iwh.h
* Makefile.am: Adjust accordingly. * Makefile.old: Remove. * *.c: Change "repo.h" to "iwh.h". * .gitignore: Adjust.
commit 44256e8a87d50435fe8335d9b02072060a193b93 Author: Jeff Darcy jdarcy@redhat.com Date: Fri Sep 10 09:40:24 2010 -0400
Added serialization on MongoDB client. Test is to transfer 50 1MB files simultaneously, would previously fail ~2/3 of the time, can now get through ten successive runs without error.
commit c1b1926543edc78434c3abc89a688b45e34b2cdf Merge: 36b576b15251123c0d10f1137dab2978abff5cc1 83de5edc46744db2188e54685d6cda0d8e60168d Author: Jeff Darcy jdarcy@redhat.com Date: Thu Sep 9 17:02:45 2010 -0400
Merge branch 'master' into ec2
commit 83de5edc46744db2188e54685d6cda0d8e60168d Author: Jim Meyering jim@meyering.net Date: Thu Sep 9 21:48:51 2010 +0200
configure.ac: refer to a better URL for peg
A nit (still on same branch: help-and-name-change):
From f0cfa231cc4333d2141933eede06f3ed2d9e0b1f Mon Sep 17 00:00:00 2001 From: Jim Meyering meyering@redhat.com Date: Thu, 9 Sep 2010 21:47:50 +0200 Subject: [PATCH] configure.ac: refer to a better URL for peg
commit 4e08979356432a68839ede52b75468ba780fbb3e Author: Jim Meyering jim@meyering.net Date: Thu Sep 9 20:08:33 2010 +0200
no more -D... options on command line
There are way too many -D options on each compilation command line, e.g.,
gcc -DPACKAGE_NAME="repod" -DPACKAGE_TARNAME="repod" -DPACKAGE_VERSION="1.0\ " -DPACKAGE_STRING="repod\ 1.0" -DPACKAGE_BUGREPORT="FIXME@example.com" -DPAC KAGE_URL="" -DPACKAGE="repod" -DVERSION="1.0" -DSTDC_HEADERS=1 -DHAVE_SYS_T YPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H= 1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHA VE_FCNTL_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_STRINGS _H=1 -DHAVE_SYS_TIME_H=1 -DHAVE_UNISTD_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHA VE_STDLIB_H=1 -DHAVE_MALLOC=1 -DHAVE_STDLIB_H=1 -DHAVE_REALLOC=1 -DHAVE_GETTIMEOF DAY=1 -DHAVE_MEMMOVE=1 -DHAVE_MEMSET=1 -DHAVE_STRCASECMP=1 -DHAVE_STRDUP=1 -DHAVE _STRNDUP=1 -DHAVE_STRTOUL=1 -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -W -Wall -Wshadow -Wextra -g -O2 -MT repod-template.o -MD -MP -MF .deps/repod-template.Tpo -c -o repod-template.o `test -f 'template.c' || echo '../'`template.c
That makes things hard to read and has a few other problems. Most projects avoid those problems now by using something like this to cause autotools to put definitions in "config.h":
AC_CONFIG_HEADERS([config.h:config.hin])
The only caveat is that now, each and every source file must include config.h first thing. I've done that.
One other required change: I tweaked autogen just to run autoreconf -i, so that it now runs autoheader, too (that's the thing that creates the config.hin template).
Here's the patch. It's also on the help-and-name-change branch. Everything still builds fine and passes make distcheck on F13, of course.
BTW, with that, now I see this when I run "make": [and the leg/patching stuff will soon be hidden just like usual rules]
leg < ./query.leg > query-orig.c-t && mv query-orig.c-t query-orig.c patch --fuzz=0 query-orig.c ./query.c.diff --output=query.c-t patching file query-orig.c mv query.c-t query.c make all-am make[1]: Entering directory `/home/j/w/co/repo' CC repod-query.o CC repod-template.o CC repod-backend.o CC repod-mpipe.o CC repod-proxy.o CXXLD repod make[1]: Leaving directory `/home/j/w/co/repo'
IMHO, the above is a lot more readable and lends it self much more to spotting new warnings than the overblown -D clutter.
If you need to diagnose something and *want* to see the actual compiler/linker invocations, run "make V=1".
From 388c8f8a9df800f2a18ec7f86d28e5e01f5853d7 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyering@redhat.com Date: Thu, 9 Sep 2010 20:04:31 +0200 Subject: [PATCH] build: use config.h; enable some automake features
* autogen.sh: Replace contents: invoke autoreconf -i. * configure.ac: Use AC_CONFIG_HEADER (aka config.h). Require automake-1.11.1, since 1.11 had a CVE. Enable colored test results and parallelized tests. Make silent rules the default. Use "make V=1" to see the build commands again. * backend.c: Include <config.h> first thing. * meta.cpp: Likewise. * mpipe.c: Likewise. * proxy.c: Likewise. * rest.c: Likewise. * template.c: Likewise.
commit b533d5007588fc81e3f4f8eaba5b20e126cbfcc0 Author: Jim Meyering jim@meyering.net Date: Thu Sep 9 19:47:25 2010 +0200
provide --help, --version, bug-reporting address; normalize
Here are two more patches. Jeff, you can use these, or pull from my new help-and-name-change branch.
--help and --version are required for just about any package in Fedora. Exit 0 (not 1) for --help is standard, but diagnosing bogus options requires a non-zero exit status, hence the new signature for the usage function.
The next step is to change file names and the few internal uses of "repod", but obviously best to defer that until you and Pete have no pending changes to the affected files.
From a21d098e2766438c25d67953a43449cc744fb12d Mon Sep 17 00:00:00 2001 From: Jim Meyering meyering@redhat.com Date: Thu, 9 Sep 2010 19:13:39 +0200 Subject: [PATCH 1/2] provide --help, --version, bug-reporting address; normalize
commit 36b576b15251123c0d10f1137dab2978abff5cc1 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Sep 9 15:48:37 2010 -0400
EC2 experiments.
commit e41b1d528f9a717a1238e0ffb6b1585f976f0cc5 Author: Jim Meyering jim@meyering.net Date: Thu Sep 9 17:06:51 2010 +0200
build: make ./configure fail if "leg" is not available
* configure.ac: Ensure that the "leg" program is present. If not, ./configure fails. Suggested by Jeff Darcy.
commit dbbe6ed397f104bd46994a414bbf772482b55e7e Author: Jim Meyering meyering@redhat.com Date: Wed Sep 8 20:12:06 2010 +0200
build: new rules; run leg; apply patch to fix generated code
* Makefile.am (query-orig.c): New rule to run leg. (query.c): Generate this from query-orig.c and an included DIFF. Set automake variables so "make distcheck" still works. * query.c: Remove file, now that we generate it. * query.c.diff: New file. Fix NULL-deref bugs in generated code. * .gitignore: Ignore generated files.
commit ffcdb13d7768ec8e7eea805eedf1ff8a3b7952c0 Author: Jim Meyering meyering@redhat.com Date: Tue Sep 7 23:58:38 2010 +0200
query: avoid NULL-deref-on-OOM bugs
* query.leg: don't deref NULL on strdup failure Include <error.h>. Define new functions: xmalloc, xrealloc, xstrdup, etc. Use these functions in place of offending malloc, realloc, etc. * query.c: Regenerate.
commit dc8f752f2a0221aebf5a34382e54b8b5f678f429 Author: Jeff Darcy jdarcy@redhat.com Date: Wed Sep 8 12:51:15 2010 -0400
Up-to-date API docs.
commit ae2c9069e7ebb88d319f61e9792a146ecf05ff44 Author: Jeff Darcy jdarcy@redhat.com Date: Wed Sep 8 12:14:17 2010 -0400
Replace assert (now undefined) with abort. Actually Jim's fix.
commit e9aa5e61be753e98dba5ae9d7345fee2120598c0 Author: Jim Meyering meyering@redhat.com Date: Tue Sep 7 16:09:16 2010 +0200
Makefile.am: use $(...) rather than @...@
They're technically equivalent, but the latter notation has been deprecated for several years.
commit 08850d117149820216041151d58469d0811d268c Author: Jim Meyering meyering@redhat.com Date: Tue Sep 7 15:38:38 2010 +0200
configure.ac: avoid m4 under-quoting errors
commit 64a2afa08d17ca3eb0a9e77b289be215ac26b82e Author: Jim Meyering meyering@redhat.com Date: Tue Sep 7 15:16:55 2010 +0200
configure.ac: remove obsolete comment
commit 5349f61b1ff3c813cc6990c3a2c855aafefa0ece Author: Jeff Darcy jdarcy@redhat.com Date: Thu Sep 2 11:51:56 2010 -0400
Deleted old (higher level) local-filesystem interface.
commit b23faa4d19347d296e17ca776760b11132a473b4 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Sep 2 11:48:03 2010 -0400
Added low-level filesystem back end.
commit 72de81ed949da99aa7f70465d74d0e0b91a5f570 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Sep 2 10:52:52 2010 -0400
Moved back-end-specific init code into back-end module.
commit e6bd1cdf072fed72454ec8d362ae1719c36560e7 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Sep 2 10:41:21 2010 -0400
Moved bucket-create into backend module, fixed a couple of other bugs I found in the process.
commit 6c96bac27eea4f3e629558853520649a6477db93 Author: Jeff Darcy jdarcy@redhat.com Date: Thu Sep 2 10:11:03 2010 -0400
Moved delete into backend module.
commit c013bf58efaf8b197f7bec89925cfc1ce3aade3b Author: Jeff Darcy jdarcy@redhat.com Date: Wed Sep 1 17:16:35 2010 -0400
First step of making back ends fully modular and interchangeable.
commit 2151274bb62d0dbf8ca706749b353b5803084e3d Author: Jeff Darcy jdarcy@redhat.com Date: Wed Sep 1 15:53:35 2010 -0400
Lost mpipe.* in the last merge.
commit a5de87504edf5ab9114b7e317124eb9734a89ab6 Merge: 252715774eeec18b75738d44f7dbb67d3e023511 87eb13438fd9130aca66c78b431e2cfa3a56364e Author: Jeff Darcy jdarcy@redhat.com Date: Wed Sep 1 15:51:50 2010 -0400
Merge branch 'merge'
Conflicts: Makefile.am repo.h rest.c
commit 252715774eeec18b75738d44f7dbb67d3e023511 Author: Jeff Darcy jdarcy@redhat.com Date: Wed Sep 1 15:39:09 2010 -0400
Jim's latest fixes (DPRINTF/realloc/strtok_r) merged by hand because I forgot to do it before starting on the massive mpipe rewrite and now they don't apply automatically.
commit 22a86eca56dbf242b70ae50bcfe3662b0e9dca3c Author: Jeff Darcy jdarcy@redhat.com Date: Wed Sep 1 14:33:35 2010 -0400
Major rework to make all of the producer/consumer stuff more modular.
commit 87eb13438fd9130aca66c78b431e2cfa3a56364e Author: Jim Meyering meyering@redhat.com Date: Wed Sep 1 10:20:42 2010 +0200
build: make "make distcheck" work
* Makefile.am (repod_SOURCES): Add the 5 .h files.
commit 81a71b33f95f20261804be5f71b922ccdd4c964b Author: Jim Meyering meyering@redhat.com Date: Tue Aug 31 22:19:06 2010 +0200
don't dereference NULL upon OOM
* rest.c (proxy_query): Don't deref NULL upon OOM. Avoid leak-upon-OOM. (proxy_put_attr): Likewise.
commit 408671c995aa5535b7019e67917682dddb09e1a1 Author: Jim Meyering meyering@redhat.com Date: Tue Aug 31 19:18:35 2010 +0200
maint: tweak DPRINTF definition
* repo.h (DPRINTF): Wrap in "do {...} while (0)", not "{...}" so the statement-ending semicolon is required.
commit 09bdfd55576e46cee1e339f742dd5f429af3d9ee Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 20:13:28 2010 +0200
promise gcc -W that we won't abuse strtok_r (rest.c, this time)
commit 0d2dec0a10cce0eb9c0a91ad0aaf4ea52569231e Author: Jeff Darcy jdarcy@redhat.com Date: Tue Aug 31 14:16:03 2010 -0400
Fixed immediate-disconnection issue by adding a size_t cast for the MHD buffer size (found on EC2). Also, rearranged bucket-creation code so it does the necessary metadata things for non-S3 primary stores even though it can't do the data part (which will have to be done by hand in those cases).
commit 32be1e5c390bc6c2998511dd31174779d41e44d7 Author: Jeff Darcy jdarcy@redhat.com Date: Mon Aug 30 15:36:59 2010 -0400
Fixed a bunch of warnings... unused variable computed value not used shadowed declaration missing initializer int/size_t mismatch There are still some left in query.* but this should make real issues elsewhere easier to spot.
commit 1e0d0594953dd70bddd1184a6f8df392de893022 Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 20:25:37 2010 +0200
avoid a "comparison between signed and unsigned..." warning
* template.h (struct tmpl_ctx_t) [index]: Change type from int to "unsigned int". Conceptually, it's unsigned, so the type should reflect that.
commit 688a7fcb2ce67f9959bfeb109315c20af1951727 Author: Jeff Darcy jdarcy@redhat.com Date: Mon Aug 30 14:36:32 2010 -0400
More fixes from Jim.
commit af07e3461cbb1e9a479ddb20be6d06e8ffa467ff Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 15:39:53 2010 +0200
tmpl_get_ctx: return something
* template.c (tmpl_get_ctx): Provide required return statement. Remove unnecessary cast.
commit 9c9c1a144ba87bf0d103b8b1e76099e28122f029 Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 15:31:44 2010 +0200
promise gcc -W that we won't abuse strtok_r
gcc -W is worried that we might call strtok_r(s, delim, &var) with uninitialized "var", because it sees that "S" may be NULL. If that were ever to happen, then strtok_r would write through the arbitrary pointer. This is just stopgap in 2 of the 3 cases. In those, we should handle strdup failure. * proxy.c (proxy_repl_prod): Assert that strtok_r input pointer is non-NULL. * (proxy_repl_cons, repl_worker_del): Likewise.
commit 2d3511e28322970d0d8c6fe74c402db9d02aefdf Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 14:52:03 2010 +0200
maint: placate gcc
* proxy.c (proxy_repl_cons): Initialize local to avoid spurious "may be used uninitialized" warning.
commit 48c15454ed05224133df56a9a40ae53c8c054917 Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 14:39:43 2010 +0200
maint: avoid warnings about implicitly declared functions
* proxy.c: Include "meta.h" for decl of meta_get_value, etc.
commit 9455151cdcac765eb84f037e6830f2a7d1dfe737 Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 14:38:17 2010 +0200
maint: avoid warnings about unused parameters
* proxy.c: Mark unused parameters as such. Use %u, not %lu for unsigned short port number.
commit 8be7a4155657dc35bc2e51c70d1ef0d2aa809827 Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 17:00:55 2010 +0200
maint: define macros used to teach compiler about semantics
* repo.h (__attribute__, ATTRIBUTE_UNUSED): Define.
commit 27b62864cb02331ed7c518228c1385b7312a2d81 Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 14:33:16 2010 +0200
proxy.c: more %llu -> %zu
commit 46ef84beb97bd472fb498b7f506f080a214f5271 Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 14:31:27 2010 +0200
maint: avoid format mismatch warnings
* rest.c (post_find): Cast gpointer to char* in DPRINTF. rest.c (post_foreach): Likewise. (main): Use %u, not %lu, for an argument of type unsigned short.
commit d03db9f49bcd7c84a94f43919a7e086fd0ee6680 Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 14:26:13 2010 +0200
maint: avoid warnings about printf format/type mismatch
* rest.c (main): Use %zu, not %llu for values of type size_t.
commit f9ac4b4b02eacab9d717f55c103a933c2cad3360 Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 14:22:32 2010 +0200
maint: avoid warning about undeclared function
* template.h (tmpl_prov_footer): Declare.
commit ded414a6d00ed4d4937029d1a45ca320a4d75b7d Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 13:56:11 2010 +0200
remove trailing spaces
commit 3976fe654feef45daaef9c7ddf396ea14f5b228f Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 13:55:24 2010 +0200
maint: enable some gcc compiler warnings
* Makefile.am (AM_CFLAGS): Enable some gcc warnings.
commit efc87e6e031d463c7a701a4c51976e39762cda8f Author: Jim Meyering meyering@redhat.com Date: Mon Aug 30 13:53:41 2010 +0200
maint: remove declarations of unused local variables
* rest.c (proxy_query_func): Remove unused local, prov. (proxy_api_root): Remove unused local, host. (proxy_list_provs): Remove unused local, op. (proxy_create_bucket): Remove unused local, policy.
commit 5102b0ed023941ff8a823564a065be77d87d7e0a Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Fri Aug 20 09:13:22 2010 -0400
Library fix from Jim.
commit 560331b18580fdafabece362504b5f9ab08ad128 Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Thu Aug 19 20:12:52 2010 -0400
Added back "fake buckets" (i.e. special REST-API stuff) in top-level list.
commit 771176f86f5a13f17cb3e9ac607dedae4eb2556e Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Thu Aug 19 20:05:23 2010 -0400
Added real bucket listing, reworked request cleanup.
commit 02809d6538a80419fa678d1bb0e2245a3caabbdc Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Thu Aug 19 15:35:57 2010 -0400
Added bucket creation.
commit b44c2b531e6a887a41d0fea2e5d12cb651377d26 Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Thu Aug 19 13:53:47 2010 -0400
Converted object listing to use templates.
commit 077f53fb99bee8213445849b2ff3b023eab6d63a Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Thu Aug 19 12:28:23 2010 -0400
Added Host/Accept handling for templates.
commit b5e0b5cfc2d4192d599a598ae554855f8b9a0057 Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Thu Aug 19 12:05:14 2010 -0400
Added JSON templates.
commit 2e5d5ee1815efcb3ba5b945ac76324e730393730 Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Thu Aug 19 11:49:18 2010 -0400
Added template module.
commit b07a1ceff70b4097ed6844f38732c367154aa188 Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Wed Aug 18 17:00:14 2010 -0400
Added config fetch and credential update.
commit 72a8b98634599eb63f2ae00d8698512406dd8b51 Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Wed Aug 18 16:29:11 2010 -0400
Allow users to fetch provider list.
commit c77b945def349b95d42c0cc14b71187eb6da8381 Author: root root@fserver-1.virtual Date: Tue Aug 17 15:45:01 2010 -0400
Added replication-complete check, tweaked metadata-DB-update code.
commit 0f2d6bfa7cee6bf356af36dbbc81d415e60f85ce Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Tue Aug 17 14:06:32 2010 -0400
Made query code reentrant and stuff.
commit 84c4af8715d0894b4e14d507c52f24234a49a56f Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Tue Aug 10 14:44:22 2010 -0400
Added re-replication, changed original replication to use same code for looking up policy etc.
commit d7592254d29bd09b23c7a585435133108534746c Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Wed Aug 4 13:23:26 2010 -0400
Added manual re-replication trigger.
commit 80a1172da7c31d522098e3a5b5bc195579a49369 Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Tue Aug 3 15:22:39 2010 -0400
Clear locations when file changes at root. Delete local metadata as well as data. Re-replicate when (per-object) policy changes. Get site name from config file.
commit 472404054c244850ddebb7c940ff9ede69aeae3b Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Tue Aug 3 15:20:43 2010 -0400
Clear locations when file changes at root. Delete local metadata as well as data. Re-replicate when (per-object) policy changes. Get site name from config file.
commit 22b9dacf1742d26bed46dfef957d239b48fe685b Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Thu Jul 22 11:19:48 2010 -0400
Added docs.
commit 1f9fb7f90f7d2aaa2c9a27072bd610b447ba79f5 Author: Jeff Darcy jdarcy@jdarcy-dt.usersys.redhat.com Date: Thu Jul 22 10:47:57 2010 -0400
Initial version (code only so far) for internal git server.
iwhd-commit@lists.fedorahosted.org