Kevin Fenzi wrote:
On Thu, Oct 31, 2019 at 02:30:49AM -0400, Todd Zullinger wrote:
> Kevin Fenzi wrote:
>> On Tue, Oct 29, 2019 at 02:19:00PM -0400, Stephen John
>> Smoogen wrote:
>>> I didn't see anything patched on there so I am not sure
>>> what to review.
>> git-send-email always for some reason sends the actual
>> patch as a followup. So, look for the first followup to
>> the orig message in the thread...
> Hmm, that's not behavior I've ever seen from git send-email.
> Is the git format-patch --thread option or format.thread
> config variable set along with the --thread option to git
> send-email? The defaults generally work.
For me, this is from batcave01 (so ancient rhel7 version) and
all I did was commit something, and do:
git send-email --compose --suppress-cc=all
--to=infrastructure(a)lists.fedoraproject.org --from kevin(a)scrye.com
--no-cc --no-bcc HEAD^
Ahh, this is from the `--compose` option. That's probably
better to use only when you're sending a patch series rather
than a single patch. (It's more or less the equivalent of
using the `--cover-letter` option with `git format-patch`.
For a single patch, the `--annotate` option is probably
better suited. That opens an editor with the patch where
you can enter some description of the patch (ideally between
the `---` and the diffstat, which ensures that text isn't
included it the patch is applied with `git am`). That way
you end up with a single message.
I looked at the docs for `git send-email` in EL7 and
`--annotate` is there, so it should work in that version.