Good Morning Everyone,
In order to fix https://pagure.io/releng/fedora-scm-requests/issue/1078 I would like to manually apply the following change to pagure on src.fp.o:
--- a/pagure/forms.py +++ b/pagure/forms.py @@ -31,7 +31,7 @@ import pagure.lib
STRICT_REGEX = '^[a-zA-Z0-9-_]+$' TAGS_REGEX = '^[a-zA-Z0-9-_, .]+$' -PROJECT_NAME_REGEX = '^[a-zA-z0-9_][a-zA-Z0-9-_]*$' +PROJECT_NAME_REGEX = '^[a-zA-z0-9_][a-zA-Z0-9-_.]*$' FALSE_VALUES = ('false', '', False, 'False', 0, '0')
I'll try to find a more elegant/flexible solution for the long term in pagure itself (like a configuration key).
+1s?
Thanks, Pierre
+1
On 12 September 2017 at 10:59, Kevin Fenzi kevin@scrye.com wrote:
+1
kevin
infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-leave@lists.fedoraproject.org
"PC" == Pierre-Yves Chibon pingou@pingoured.fr writes:
PC> In order to fix PC> https://pagure.io/releng/fedora-scm-requests/issue/1078 I would like PC> to manually apply the following change to pagure on src.fp.o:
I note that we're still not able to import packages with names containing dots. I'm not sure if this hotfix wasn't pushed, or if perhaps it wasn't sufficient.
My guess is that there is another tool involved in this and that one also needs to be adjusted.
- J<
On Fri, Sep 22, 2017 at 02:37:26PM -0500, Jason L Tibbitts III wrote:
"PC" == Pierre-Yves Chibon pingou@pingoured.fr writes:
PC> In order to fix PC> https://pagure.io/releng/fedora-scm-requests/issue/1078 I would like PC> to manually apply the following change to pagure on src.fp.o:
I note that we're still not able to import packages with names containing dots. I'm not sure if this hotfix wasn't pushed, or if
I had indeed missed applying it, sorry about that :(
perhaps it wasn't sufficient.
There is apparently also a fix needed in fedrepo_req: https://pagure.io/fedrepo_req/issue/110
Pierre
On Tue, Sep 12, 2017 at 09:40:53AM +0200, Pierre-Yves Chibon wrote:
Good Morning Everyone,
In order to fix https://pagure.io/releng/fedora-scm-requests/issue/1078 I would like to manually apply the following change to pagure on src.fp.o:
--- a/pagure/forms.py +++ b/pagure/forms.py @@ -31,7 +31,7 @@ import pagure.lib
STRICT_REGEX = '^[a-zA-Z0-9-_]+$' TAGS_REGEX = '^[a-zA-Z0-9-_, .]+$' -PROJECT_NAME_REGEX = '^[a-zA-z0-9_][a-zA-Z0-9-_]*$' +PROJECT_NAME_REGEX = '^[a-zA-z0-9_][a-zA-Z0-9-_.]*$' FALSE_VALUES = ('false', '', False, 'False', 0, '0')
Following up on this, it seems we also need to allow '+' (cf [1])
+1 to adjust the regex to: PROJECT_NAME_REGEX = '^[a-zA-z0-9_][a-zA-Z0-9-_.+]*$'
Note: the 3.8 release makes this a configuration variable, so potentially easier to adjust :)
Pierre
infrastructure@lists.fedoraproject.org
-
Jason L Tibbitts III -
Kevin Fenzi -
Pierre-Yves Chibon -
Stephen John Smoogen