On 3/5/19 9:27 AM, Clement Verna wrote:
Hi all,

I would like to know what do you think about using an opinionated code
formatter for our ansible repo ? I think this would help with
enforcing a common style and make our yaml files easier to read and
maintain.

I have been looking at https://prettier.io/ which support yaml and I
ran it on the repo's playbooks directory (see attached patch).  Most
of the changes are indentation but we could enforce more rules using
prettier's configuration options if we wish
(vhttps://prettier.io/docs/en/configuration.html).

Prettier looks quite cool but the only down side is that it is a
Javascript application and it is currently not packaged in Fedora, I
have used a container to run it on my laptop.

Anyway what do you think about  it ? Does anybody knows an alternative
to prettier ?

Hi Clement,

The most standrd solution should be yamlint.

It is also packaged in Fedora:
   yamllint.noarch : A linter for YAML files

It does not autofix the code but it warns you:

-> yamllint stuff.yaml
stuff.yaml
  196:23    error    trailing spaces  (trailing-spaces)
  278:11    warning  too few spaces before comment  (comments)
  279:11    warning  too few spaces before comment  (comments)
  280:11    warning  too few spaces before comment  (comments)

I use it with overcommit (https://github.com/brigade/overcommit), toghether they prevents to commit if there are errors.

It is also configurable, of course.


-- 
Alessandro Lorenzi