On Mon, Oct 29, 2018 at 9:25 PM Dusty Mabe <dusty@dustymabe.com> wrote:


On 10/29/2018 11:16 AM, Sinny Kumari wrote:
>
>
> On Fri, Oct 26, 2018 at 7:07 PM Dusty Mabe <dusty@dustymabe.com <mailto:dusty@dustymabe.com>> wrote:
>
>
>
>     On 10/25/2018 01:25 PM, Sinny Kumari wrote:
>     > Hi,
>     >
>     > Here is a patch (available in email attachment) to include updates-testing repo
>     > as well during Atomic Host ISO creation in bodhi updates-testing run. Specifying
>     > multiple repos to lorax should work fine on Fedora >=29 -
>     > https://github.com/weldr/lorax/issues/368 .
>     >
>     > Can I get +1 for the patch?
>     >
>     > Thanks,
>     > Sinny
>
>
>     Suggested change below. I think we just need to uncomment out the commented out code right
>     above the lines you changed.
>
>
> Thanks Dusty for reviewing it!
>
>     - updates run will run lorax against
>         - Everything
>             - the current updates run
>
> +1
>
>         - https://kojipkgs{{ env_suffix }}.fedoraproject.org/compose/branched/latest-Fedora-[[ <http://fedoraproject.org/compose/branched/latest-Fedora-%5B%5B> release.version_int ]]/compose/Everything/[[arch]]/os/
>             - the release day repo
>
>
> With RC 1.2 being Gold, does it make sense to make this https://kojipkgs{{ env_suffix }}.fedoraproject.org/compose/[[ <http://fedoraproject.org/compose/[[> release.version_int ]]/latest-Fedora-[[ release.version_int ]]/compose/Everything/[[arch]]/os/ ?


I think probably we should just change the "if conditions" to `== 30` in places where it makes sense now that f29 is going to be released, which should achieve the same goal right?

Yeah, I will be doing same code wise

Dusty


--
http://sinny.io/