Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Package Review: ibus-table-extraphrase
https://bugzilla.redhat.com/show_bug.cgi?id=488175
Summary: Package Review: ibus-table-extraphrase Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Keywords: i18n Severity: medium Priority: low Component: Package Review AssignedTo: petersen@redhat.com ReportedBy: cchance@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, petersen@redhat.com, fedora-package-review@redhat.com, cchance@redhat.com, phuang@redhat.com, fedora-i18n-bugs@redhat.com Depends on: 488010 Blocks: 484650 Estimated Hours: 0.0 Classification: Fedora Target Release: --- Clone Of: 488173
A split from ibus-table-chinese, which was sub-package of ibus-table.
Uploading srpm and spec.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|petersen@redhat.com |nobody@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
Bug 488175 depends on bug 488010, which changed state.
Bug 488010 Summary: Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table. https://bugzilla.redhat.com/show_bug.cgi?id=488010
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #1 from Caius "kaio" Chance cchance@redhat.com 2009-03-27 03:06:26 EDT --- Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase-1.1.0.20090... SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase.spec Description: A split from ibus-table-chinese, which was sub-package of ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
--- Comment #2 from Parag AN(पराग) panemade@gmail.com 2009-03-30 04:50:30 EDT ---
Suggestions: 1) Change license to GPLv3+ 2) Good if you preserve timestamp of svg file also. Use make DESTDIR=%{buildroot} install INSTALL="install -p" 3) use macros. replace /usr/share/ with %{_datadir}
why not .db files created and installed in this package?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
Caius "kaio" Chance dejieshi@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dejieshi@gmail.com
--- Comment #3 from Caius "kaio" Chance dejieshi@gmail.com 2009-03-30 13:22:07 EDT --- HI Parag,
Thanks, I will fix 1 - 3 asap.
As in pre 1.1 version, extra_phrase.txt existed without creation. I keep this because of completeness of ibus-table. This will be investigated after all packages have entered rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #4 from Caius "kaio" Chance cchance@redhat.com 2009-03-31 03:52:01 EDT --- Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase-1.1.0.20090... SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #5 from Jens Petersen petersen@redhat.com 2009-03-31 07:24:23 EDT --- Can you add some explanation how to use this package?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #6 from Caius "kaio" Chance dejieshi@gmail.com 2009-03-31 09:53:12 EDT --- ibus-table has 'ibus-table-createdb' which converts tables to sqlite3 .db files.
`ibus-table-createdb --help` will show that two parameters needed. There is one to specify {cangjie3,cangjie5,wubi,erbi,zhengma,etc}.txt table source file, another one is to specify such extra_phrase.txt phrase supplement file.
After the new .db file has been generated, overwrite the original one in /usr/share/ibus-table/tables/
To get end-users rebuild their table db smoothly, I recommend creating shell scripts to call ibus-table-createdb. However, rebuild of table db involves table source file, which needs srpm.
Also should look into whether including extraphrase data by default affects performance and usability or not.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #7 from Caius "kaio" Chance cchance@redhat.com 2009-04-01 20:34:00 EDT --- Hi Jens, what would you think if we could approve that now and work out the way to include this to tables of ibus-table afterwards?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #8 from Caius "kaio" Chance cchance@redhat.com 2009-04-05 21:09:42 EDT --- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #9 from Jens Petersen petersen@redhat.com 2009-04-06 01:47:52 EDT --- (In reply to comment #7)
Hi Jens, what would you think if we could approve that now and work out the way to include this to tables of ibus-table afterwards?
Yes, that should be fine - I think your idea of adding ibus-table-<name-extraphrase subpackages sounds reasonable, if it is useful for people.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #10 from Parag AN(पराग) panemade@gmail.com 2009-04-06 01:56:22 EDT --- Review: + package builds in mock (rawhide i586). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1279006 + rpmlint output for SRPM and for RPM is ibus-table-extraphrase.src:54: W: libdir-macro-in-noarch-package %{_libdir}/pkgconfig/ibus-table-extraphrase.pc ==> is this really needed? + source files match upstream url 2dd3e5cf76c8fa36b17a6ade737e0801 ibus-table-extraphrase-1.1.0.20090327.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlet used. + file permissions are appropriate. + Not a GUI App.
Suggestions: 1) Add Changelog in upstream tarball. When you add it then you can add this Changelog file as %doc
2) can you check if ibus-table-extraphrase.pc is really needed?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #11 from Caius "kaio" Chance cchance@redhat.com 2009-04-06 20:09:50 EDT --- As per enquiry with author acevery on 6 Apr 09, ibus-table-extraphrase.pc is needed for building ibus-table-* with extra_phrase.txt
Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase-1.1.0.20094...
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #12 from Caius "kaio" Chance cchance@redhat.com 2009-04-06 23:53:40 EDT --- http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase-1.1.0.20090...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #13 from Caius "kaio" Chance cchance@redhat.com 2009-04-08 01:12:44 EDT --- Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase-1.1.0.20090...
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #14 from Caius "kaio" Chance cchance@redhat.com 2009-04-08 03:40:07 EDT --- Proposed fix of lib64:
Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase-1.1.0.20090...
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #15 from Jens Petersen petersen@redhat.com 2009-04-08 04:04:31 EDT --- %{_libdir}/pkgconfig/ibus-table-extraphrase.pc
It should be under _datadir like we did for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #16 from Caius "kaio" Chance cchance@redhat.com 2009-04-14 01:37:14 EDT --- Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase-1.1.0.20090...
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #17 from Caius "kaio" Chance cchance@redhat.com 2009-04-14 21:57:02 EDT --- Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase-1.1.0.20090...
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #18 from Caius "kaio" Chance cchance@redhat.com 2009-04-14 22:06:04 EDT --- Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase-1.1.0.20090...
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase.spec
Description: Extra phrase data for tables of ibus-table. This is a split from ibus-table-chinese, which was sub-package of ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #19 from Caius 'kaio' Chance cchance@redhat.com 2009-04-14 22:55:28 EDT --- Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase-1.1.0.20090...
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-extraphrase.spec
Description: Extra phrase data for IBus-Table which is one of the engines of input method framework IBus.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #20 from Parag AN(पराग) panemade@gmail.com 2009-04-15 00:01:59 EDT --- Review: + koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1299534
+ rpmlint gave only ibus-table-extraphrase.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/ibus-table-extraphrase.pc ==> can be ignored.
+ source files match upstream url c2f951fed13d626f4fc29fcdd7ac74ba ibus-table-extraphrase-1.1.0.20090415.tar.gz
+ Package now Provides: pkgconfig(ibus-table-extraphrase) = 1.1.0.20090415
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
Caius 'kaio' Chance cchance@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #21 from Kevin Fenzi kevin@tummy.com 2009-04-16 00:24:43 EDT --- Please use a cvs template here to let us know what you want:
https://fedoraproject.org/wiki/CVS_admin_requests
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #22 from Caius 'kaio' Chance cchance@redhat.com 2009-04-17 01:58:09 EDT --- Package Name: ibus-table-extraphrase Short Description: Extra phrase data for IBus Table Owners: cchance Branches: devel InitialCC: i18n-team
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
Caius 'kaio' Chance cchance@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(kevin@tummy.com)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs?, |fedora-cvs+ |needinfo?(kevin@tummy.com) |
--- Comment #23 from Kevin Fenzi kevin@tummy.com 2009-04-17 12:34:13 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
--- Comment #24 from Parag AN(पराग) panemade@gmail.com 2009-05-05 00:11:46 EDT --- can we close this review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488175
Caius 'kaio' Chance cchance@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #25 from Caius 'kaio' Chance cchance@redhat.com 2009-05-05 00:28:31 EDT --- built: http://koji.fedoraproject.org/koji/buildinfo?buildID=99243
i18n-bugs@lists.fedoraproject.org