Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=664214
Cristian Ciupitu cristian.ciupitu@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cristian.ciupitu@yahoo.com Status Whiteboard| |NotReady Flag| |needinfo?(lakshminaras2002@ | |gmail.com)
--- Comment #1 from Cristian Ciupitu cristian.ciupitu@yahoo.com 2010-12-25 14:36:13 EST --- You need to include the text of the license in its documentation files. This is mandatory.
I would also suggest replacing the pkg_name macro with srcname which is less confusing, but this is entirely your choice.
On the other hand the common_description macro looks useless to me because it's used in a single place. Wouldn't be better if you removed it and used something like this?
%description GConf is a configuration database .... %if %{with shared} This package provides the shared library. %endif
The same goes for common_summary.