[Bug 1115894] Review Request: ghc-hgettext - Bindings to libintl.h (gettext, bindtextdomain)
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1115894
--- Comment #4 from Jens Petersen <petersen(a)redhat.com> ---
(In reply to Philip Withnall from comment #3)
> > There is no License file included in the tarball.
> > Can you please contact the author about adding one upstream?
>
> https://github.com/vasylp/hgettext/issues/5
Thanks!
> > What is /usr/bin/hgettext for? Probably it should live
> > in ghc-hgettext-devel not ghc-hgettext, since it looks like
> > a devel tool not something needed at runtime.
>
> I was treating it the same as /usr/bin/gettext which comes from the gettext
> package, rather than gettext-devel.
I see. /usr/bin/gettext can be used by shell scripts at runtime.
I am not sure about the use case for /usr/bin/hgettext.
Is it used by project maintainers for extracting strings
to be translated or are you saying it could be used at runtime?
If it is the former kind of tool then I think it should really
live in ghc-hgettext-devel, since consumer packages of hgettext
would just use libHShgettext.
> > I think a better package Summary might be "Haskell binding to libintl".
>
> Done.
Thanks
> If you're OK with the hgettext binary remaining in the non-devel package,
> I'll request a git repo and start turning the fedpkg wheel (with the summary
> change and no licence file). Otherwise I can do another iteration of the
> spec file here with more Koji scratch builds.
Given there are few changes it would be nice to see
the final packaging here I feel. I can approve once that is done:
so you probably don't need to do all the scratch builds again.
Thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v1buYNDNtj&a=cc_unsubscribe
9 years, 11 months
[Bug 1097035] Review Request: ghc-HsSyck - Fast lightweight YAML loader and dumper
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1097035
Ben Boeckel <mathstuf(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review?
--- Comment #3 from Ben Boeckel <mathstuf(a)gmail.com> ---
Just have to talk to upstream about the MIT/BSD license mismatch.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/boeckb/misc/code/fedora/1097035-ghc-
HsSyck/licensecheck.txt
The LICENSE file looks like MIT (Modern Style[1]), but is marked as BSD
everywhere else (upstream and in the spec). Should contact upstream about this
discrepency.
[1]https://fedoraproject.org/wiki/Licensing:MIT#Modern_Style_with_sublicense
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 215040 bytes in 18 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: ghc-HsSyck-0.52-2.fc20.x86_64.rpm
ghc-HsSyck-devel-0.52-2.fc20.x86_64.rpm
ghc-HsSyck-0.52-2.fc20.src.rpm
ghc-HsSyck.x86_64: W: spelling-error %description -l en_US syck -> suck, sick,
sack
ghc-HsSyck.x86_64: W: spelling-error %description -l en_US versa -> avers,
verse, verso
ghc-HsSyck.src: W: spelling-error %description -l en_US syck -> suck, sick,
sack
ghc-HsSyck.src: W: spelling-error %description -l en_US versa -> avers, verse,
verso
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint ghc-HsSyck ghc-HsSyck-devel
ghc-HsSyck.x86_64: W: spelling-error %description -l en_US syck -> suck, sick,
sack
ghc-HsSyck.x86_64: W: spelling-error %description -l en_US versa -> avers,
verse, verso
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'
Requires
--------
ghc-HsSyck (rpmlib, GLIBC filtered):
ghc(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57)
ghc(bytestring-0.10.0.2-4f93248f75667c2c3321a7a6761b576f)
ghc(hashtables-1.0.1.8-5c2e4e88deafeef23cb7e760fce1f340)
ghc(syb-0.4.0-c48d52f3188b986ddaa9dd9ae40072f8)
ghc(utf8-string-0.3.7-26a8ed8ca48fe809983bde6faca943a9)
libHSarray-0.4.0.1-ghc7.6.3.so()(64bit)
libHSbase-4.6.0.1-ghc7.6.3.so()(64bit)
libHSbytestring-0.10.0.2-ghc7.6.3.so()(64bit)
libHSdeepseq-1.3.0.1-ghc7.6.3.so()(64bit)
libHSghc-prim-0.3.0.0-ghc7.6.3.so()(64bit)
libHShashable-1.1.2.5-ghc7.6.3.so()(64bit)
libHShashtables-1.0.1.8-ghc7.6.3.so()(64bit)
libHSinteger-gmp-0.5.0.0-ghc7.6.3.so()(64bit)
libHSprimitive-0.5.0.1-ghc7.6.3.so()(64bit)
libHSsyb-0.4.0-ghc7.6.3.so()(64bit)
libHStext-0.11.3.1-ghc7.6.3.so()(64bit)
libHSutf8-string-0.3.7-ghc7.6.3.so()(64bit)
libHSvector-0.10.0.1-ghc7.6.3.so()(64bit)
libc.so.6()(64bit)
libgmp.so.10()(64bit)
libsyck.so.0()(64bit)
rtld(GNU_HASH)
ghc-HsSyck-devel (rpmlib, GLIBC filtered):
/bin/sh
ghc(HsSyck-0.52-8183c6608a32ebe14c37919d0962ec72)
ghc-HsSyck(x86-64)
ghc-compiler
ghc-devel(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57)
ghc-devel(bytestring-0.10.0.2-4f93248f75667c2c3321a7a6761b576f)
ghc-devel(hashtables-1.0.1.8-5c2e4e88deafeef23cb7e760fce1f340)
ghc-devel(syb-0.4.0-c48d52f3188b986ddaa9dd9ae40072f8)
ghc-devel(utf8-string-0.3.7-26a8ed8ca48fe809983bde6faca943a9)
syck-devel(x86-64)
Provides
--------
ghc-HsSyck:
ghc(HsSyck-0.52-8183c6608a32ebe14c37919d0962ec72)
ghc-HsSyck
ghc-HsSyck(x86-64)
libHSHsSyck-0.52-ghc7.6.3.so()(64bit)
ghc-HsSyck-devel:
ghc-HsSyck-devel
ghc-HsSyck-devel(x86-64)
ghc-HsSyck-static
ghc-devel(HsSyck-0.52-8183c6608a32ebe14c37919d0962ec72)
Unversioned so-files
--------------------
ghc-HsSyck: /usr/lib64/ghc-7.6.3/HsSyck-0.52/libHSHsSyck-0.52-ghc7.6.3.so
Source checksums
----------------
http://hackage.haskell.org/package/HsSyck-0.52/HsSyck-0.52.tar.gz :
CHECKSUM(SHA256) this package :
6c73bcbf8dee55e8a76a8dc9835201a2f995fe1c5c67f255f3f55f60ea9aacc1
CHECKSUM(SHA256) upstream package :
6c73bcbf8dee55e8a76a8dc9835201a2f995fe1c5c67f255f3f55f60ea9aacc1
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1097035
Buildroot used: fedora-20-x86_64
Active plugins: Generic, Haskell, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vIGQ0ZHDnx&a=cc_unsubscribe
9 years, 11 months
[Bug 1098854] Review Request: pandoc-citeproc - Citeproc support for pandoc
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1098854
Ben Boeckel <mathstuf(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review+
--- Comment #3 from Ben Boeckel <mathstuf(a)gmail.com> ---
LGTM. The diff between the srpm and the spec looks fine to me.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
or number of files.
Note: Documentation size is 2949120 bytes in 106 files.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 28 files have unknown license. Detailed output of
licensecheck in /home/boeckb/misc/code/fedora/1098854-pandoc-
citeproc/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc-pandoc-
citeproc
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see attached
diff).
Diff looks fine though (new cabal2rpm run?).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Note: Arch-ed rpms have a total of 4249600 bytes in /usr/share
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: pandoc-citeproc-0.3.1-1.fc20.x86_64.rpm
ghc-pandoc-citeproc-0.3.1-1.fc20.x86_64.rpm
ghc-pandoc-citeproc-devel-0.3.1-1.fc20.x86_64.rpm
pandoc-citeproc-0.3.1-1.fc20.src.rpm
pandoc-citeproc.x86_64: W: manpage-not-compressed gz
/usr/share/pandoc-citeproc-0.3.1/man/man1/pandoc-citeproc.1
pandoc-citeproc.x86_64: W: spelling-error %description -l en_US hs -> HS, sh,
gs
pandoc-citeproc.x86_64: W: spelling-error %description -l en_US http -> HTTP
pandoc-citeproc.x86_64: W: spelling-error %description -l en_US citationstyles
-> citation styles, citation-styles, solicitations
pandoc-citeproc.x86_64: W: spelling-error %description -l en_US metadata ->
meta data, meta-data, metatarsal
pandoc-citeproc.src: W: spelling-error %description -l en_US hs -> HS, sh, gs
pandoc-citeproc.src: W: spelling-error %description -l en_US http -> HTTP
pandoc-citeproc.src: W: spelling-error %description -l en_US citationstyles ->
citation styles, citation-styles, solicitations
pandoc-citeproc.src: W: spelling-error %description -l en_US metadata -> meta
data, meta-data, metatarsal
4 packages and 0 specfiles checked; 0 errors, 9 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint pandoc-citeproc ghc-pandoc-citeproc ghc-pandoc-citeproc-devel
pandoc-citeproc.x86_64: W: manpage-not-compressed gz
/usr/share/pandoc-citeproc-0.3.1/man/man1/pandoc-citeproc.1
pandoc-citeproc.x86_64: W: spelling-error %description -l en_US hs -> HS, sh,
gs
pandoc-citeproc.x86_64: W: spelling-error %description -l en_US http -> HTTP
pandoc-citeproc.x86_64: W: spelling-error %description -l en_US citationstyles
-> citation styles, citation-styles, solicitations
pandoc-citeproc.x86_64: W: spelling-error %description -l en_US metadata ->
meta data, meta-data, metatarsal
3 packages and 0 specfiles checked; 0 errors, 5 warnings.
# echo 'rpmlint-done:'
Diff spec file in url and in SRPM
---------------------------------
---
/home/boeckb/misc/code/fedora/1098854-pandoc-citeproc/srpm/pandoc-citeproc.spec
2014-07-14 16:05:45.691858923 -0400
+++
/home/boeckb/misc/code/fedora/1098854-pandoc-citeproc/srpm-unpacked/pandoc-citeproc.spec
2014-05-18 22:38:31.000000000 -0400
@@ -3,6 +3,4 @@
%global pkg_name pandoc-citeproc
-%bcond_without tests
-
# no useful debuginfo for Haskell packages without C sources
%global debug_package %{nil}
@@ -104,10 +102,4 @@
-%check
-%if %{with tests}
-%cabal test
-%endif
-
-
%post -n ghc-%{name}-devel
%ghc_pkg_recache
@@ -138,5 +130,4 @@
- update to 0.3.1
- build with -O1 to avoid exhausting memory in koji
-- enable tests
* Thu May 1 2014 Jens Petersen <petersen(a)redhat.com> - 0.3.0.1-1
Requires
--------
pandoc-citeproc (rpmlib, GLIBC filtered):
ghc(HTTP-4000.2.8-6786975a51443bdb5cd8dd2ea9496185)
ghc(aeson-0.6.2.1-92173c75149e34c3bea9cafc379c1c76)
ghc(aeson-pretty-0.7.1-4459ea64e4a693fc11195c5ba687d7de)
ghc(array-0.4.0.1-3b78425c10ff2dad7acf7e8c8ae014c3)
ghc(attoparsec-0.10.4.0-d9fd97cfc1a1748b3cde35adf7fd233b)
ghc(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57)
ghc(base-unicode-symbols-0.2.2.4-ec1c787160bf91bc92b0b4f99c4199a9)
ghc(base64-bytestring-1.0.0.1-d8518e3d0a93ad469732bf212a97fcd8)
ghc(binary-0.5.1.1-72ed744c57c32286a49da6dda4f660b7)
ghc(blaze-builder-0.3.1.1-71a2ae53eb5daf9e6673db8b47b3b6b5)
ghc(blaze-html-0.6.1.1-74b89d78fdb27cee6a6592a1caa310c1)
ghc(blaze-markup-0.5.1.5-23936e9ed5688b66870d9ddf1c77a4f0)
ghc(bytestring-0.10.0.2-4f93248f75667c2c3321a7a6761b576f)
ghc(conduit-1.0.13.1-b3f9c14f28c136c48f69574996d03157)
ghc(containers-0.5.0.0-ab1dae9a94cd3cc84e7b2805636ebfa2)
ghc(data-default-0.5.1-3dcf8b1e18d6ff182bcfe57129991c1d)
ghc(deepseq-1.3.0.1-5cc4cd89bdc2e8f6db1833d95ec36926)
ghc(digest-0.0.1.2-aaf8ba94bbd1ce71a9d54ef32fa169bc)
ghc(directory-1.2.0.1-91a788fd88acd7f149f0f10f5f1e23f2)
ghc(dlist-0.5-6480552fbf191185cc86167748682e90)
ghc(extensible-exceptions-0.1.1.4-255a395b3b026cb94b23754e1c372785)
ghc(filepath-1.3.0.1-b12cbe18566fe1532a1fda4c85e31cbe)
ghc(ghc-prim-0.3.0.0-d5221a8c8a269b66ab9a07bdc23317dd)
ghc(hashable-1.1.2.5-e0f2541518f84d3123a819112b4ffe20)
ghc(highlighting-kate-0.5.6-076d91d5a887413f5704dcb2705bdf9b)
ghc(hs-bibutils-5.0-2d57374c0dc5496a2a5dbe978967e4cd)
ghc(hslua-0.3.10-0155b2f906fcabd820ffa0f460d18969)
ghc(integer-gmp-0.5.0.0-2f15426f5b53fe4c6490832f9b20d8d7)
ghc(lifted-base-0.2.2.1-aca5da5eb93485ba1c42e13fb9830634)
ghc(mmorph-1.0.0-20a6abb10acd5d213e6c72450f873a5d)
ghc(monad-control-0.3.2.1-ae94ebee0db8b67fe098e79cdb997ef6)
ghc(mtl-2.1.2-82086cac9073862cbe01e44b81ec8b9b)
ghc(network-2.4.1.2-ceff6721a9d15c92aeb91b7ff1b8e52b)
ghc(old-locale-1.0.0.5-6729cb9d9cc62d150655de8fc5401b91)
ghc(old-time-1.1.0.1-2f8ea093d0c7014780a8a5772f948883)
ghc(pandoc-1.12.3.3-51ab7910ba3b060a4a564e63ee89da10)
ghc(pandoc-citeproc-0.3.1-73e4e05d19d055553f98f636c4bf361f)
ghc(pandoc-types-1.12.3.3-c3d468d8d6c73c79c7d9e27e420ee842)
ghc(parsec-3.1.3-441f1388bc13de47c52a9ba8a23194f4)
ghc(pcre-light-0.4-eaabcdb497bfcb5e33efe5bfc7a9aa33)
ghc(pretty-1.1.1.0-66181c695e6a2e173ba2088cf55cc396)
ghc(primitive-0.5.0.1-8e5f40b409f7bb31ae1acfb125279700)
ghc(process-1.1.0.2-76e05340eb66705981411022731ca84a)
ghc(random-1.0.1.1-43fdc5da991685d8a0ec8cb553880cf8)
ghc(resourcet-0.4.10.2-8693cff92f1f1f2799f068c36d9c1700)
ghc(rfc5051-0.1.0.3-07d34a8cf91684504850cc8dd9e04b8e)
ghc(scientific-0.2.0.2-9e8a50a267891dabb0076bcebdc0afad)
ghc(semigroups-0.8.5-fd3e2881d0d0f0cbf8299b7f75ba9253)
ghc(split-0.2.2-7a3d16e611eda8c6cc8850aa57490f5e)
ghc(syb-0.4.0-c48d52f3188b986ddaa9dd9ae40072f8)
ghc(tagsoup-0.13.1-c3d6820b1044eb7d471a34a2a3d1cee4)
ghc(template-haskell-2.8.0.0-a3012803fde1dc362e555b35a1a78e6d)
ghc(temporary-1.1.2.4-f833a0c58981acb5d56cefc539e0a50f)
ghc(texmath-0.6.6.1-1019bfdc5f8c6f96cceb9aa6d87bd2f9)
ghc(text-0.11.3.1-e38859e86485c167fa7c9441789e7607)
ghc(time-1.4.0.1-10dc4804a19dc0000fab79908f1a9f50)
ghc(transformers-0.3.0.0-387c76a892254b0b8fe4d66f4780ad17)
ghc(transformers-base-0.4.1-c94ebf0095acdcb87db8d034e3e92265)
ghc(unix-2.6.0.1-4f219f792083f70ec440ce406f12ce57)
ghc(unordered-containers-0.2.3.0-c7952fe8bed178bdf8ed4d090730c9da)
ghc(utf8-string-0.3.7-26a8ed8ca48fe809983bde6faca943a9)
ghc(vector-0.10.0.1-869166d5d49db46ce6c328ea5f8defbf)
ghc(void-0.5.11-c2cab62da55a73b75201be81623f8abc)
ghc(xml-1.3.13-88316a3aedcb192026a5065eac016ac8)
ghc(yaml-0.8.8.2-1676b7b777ec167f29831138d4d11e26)
ghc(zip-archive-0.1.3.4-ce8983bca0ed42e285c3a17a70b6c696)
ghc(zlib-0.5.4.1-13ba81ac0d7e6f3bdf1ee5ddce4e9aab)
libHSHTTP-4000.2.8-ghc7.6.3.so()(64bit)
libHSaeson-0.6.2.1-ghc7.6.3.so()(64bit)
libHSaeson-pretty-0.7.1-ghc7.6.3.so()(64bit)
libHSarray-0.4.0.1-ghc7.6.3.so()(64bit)
libHSattoparsec-0.10.4.0-ghc7.6.3.so()(64bit)
libHSbase-4.6.0.1-ghc7.6.3.so()(64bit)
libHSbase-unicode-symbols-0.2.2.4-ghc7.6.3.so()(64bit)
libHSbase64-bytestring-1.0.0.1-ghc7.6.3.so()(64bit)
libHSbinary-0.5.1.1-ghc7.6.3.so()(64bit)
libHSblaze-builder-0.3.1.1-ghc7.6.3.so()(64bit)
libHSblaze-html-0.6.1.1-ghc7.6.3.so()(64bit)
libHSblaze-markup-0.5.1.5-ghc7.6.3.so()(64bit)
libHSbytestring-0.10.0.2-ghc7.6.3.so()(64bit)
libHSconduit-1.0.13.1-ghc7.6.3.so()(64bit)
libHScontainers-0.5.0.0-ghc7.6.3.so()(64bit)
libHSdata-default-0.5.1-ghc7.6.3.so()(64bit)
libHSdeepseq-1.3.0.1-ghc7.6.3.so()(64bit)
libHSdigest-0.0.1.2-ghc7.6.3.so()(64bit)
libHSdirectory-1.2.0.1-ghc7.6.3.so()(64bit)
libHSdlist-0.5-ghc7.6.3.so()(64bit)
libHSextensible-exceptions-0.1.1.4-ghc7.6.3.so()(64bit)
libHSfilepath-1.3.0.1-ghc7.6.3.so()(64bit)
libHSghc-prim-0.3.0.0-ghc7.6.3.so()(64bit)
libHShashable-1.1.2.5-ghc7.6.3.so()(64bit)
libHShighlighting-kate-0.5.6-ghc7.6.3.so()(64bit)
libHShs-bibutils-5.0-ghc7.6.3.so()(64bit)
libHShslua-0.3.10-ghc7.6.3.so()(64bit)
libHSinteger-gmp-0.5.0.0-ghc7.6.3.so()(64bit)
libHSlifted-base-0.2.2.1-ghc7.6.3.so()(64bit)
libHSmmorph-1.0.0-ghc7.6.3.so()(64bit)
libHSmonad-control-0.3.2.1-ghc7.6.3.so()(64bit)
libHSmtl-2.1.2-ghc7.6.3.so()(64bit)
libHSnetwork-2.4.1.2-ghc7.6.3.so()(64bit)
libHSold-locale-1.0.0.5-ghc7.6.3.so()(64bit)
libHSold-time-1.1.0.1-ghc7.6.3.so()(64bit)
libHSpandoc-1.12.3.3-ghc7.6.3.so()(64bit)
libHSpandoc-citeproc-0.3.1-ghc7.6.3.so()(64bit)
libHSpandoc-types-1.12.3.3-ghc7.6.3.so()(64bit)
libHSparsec-3.1.3-ghc7.6.3.so()(64bit)
libHSpcre-light-0.4-ghc7.6.3.so()(64bit)
libHSpretty-1.1.1.0-ghc7.6.3.so()(64bit)
libHSprimitive-0.5.0.1-ghc7.6.3.so()(64bit)
libHSprocess-1.1.0.2-ghc7.6.3.so()(64bit)
libHSrandom-1.0.1.1-ghc7.6.3.so()(64bit)
libHSresourcet-0.4.10.2-ghc7.6.3.so()(64bit)
libHSrfc5051-0.1.0.3-ghc7.6.3.so()(64bit)
libHSrts-ghc7.6.3.so()(64bit)
libHSscientific-0.2.0.2-ghc7.6.3.so()(64bit)
libHSsemigroups-0.8.5-ghc7.6.3.so()(64bit)
libHSsplit-0.2.2-ghc7.6.3.so()(64bit)
libHSsyb-0.4.0-ghc7.6.3.so()(64bit)
libHStagsoup-0.13.1-ghc7.6.3.so()(64bit)
libHStemplate-haskell-2.8.0.0-ghc7.6.3.so()(64bit)
libHStemporary-1.1.2.4-ghc7.6.3.so()(64bit)
libHStexmath-0.6.6.1-ghc7.6.3.so()(64bit)
libHStext-0.11.3.1-ghc7.6.3.so()(64bit)
libHStime-1.4.0.1-ghc7.6.3.so()(64bit)
libHStransformers-0.3.0.0-ghc7.6.3.so()(64bit)
libHStransformers-base-0.4.1-ghc7.6.3.so()(64bit)
libHSunix-2.6.0.1-ghc7.6.3.so()(64bit)
libHSunordered-containers-0.2.3.0-ghc7.6.3.so()(64bit)
libHSutf8-string-0.3.7-ghc7.6.3.so()(64bit)
libHSvector-0.10.0.1-ghc7.6.3.so()(64bit)
libHSvoid-0.5.11-ghc7.6.3.so()(64bit)
libHSxml-1.3.13-ghc7.6.3.so()(64bit)
libHSyaml-0.8.8.2-ghc7.6.3.so()(64bit)
libHSzip-archive-0.1.3.4-ghc7.6.3.so()(64bit)
libHSzlib-0.5.4.1-ghc7.6.3.so()(64bit)
libbibutils.so.5()(64bit)
libc.so.6()(64bit)
libdl.so.2()(64bit)
libffi.so.6()(64bit)
libgmp.so.10()(64bit)
liblua-5.1.so()(64bit)
libm.so.6()(64bit)
libpcre.so.1()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
libutil.so.1()(64bit)
libyaml-0.so.2()(64bit)
libz.so.1()(64bit)
rtld(GNU_HASH)
ghc-pandoc-citeproc (rpmlib, GLIBC filtered):
ghc(HTTP-4000.2.8-6786975a51443bdb5cd8dd2ea9496185)
ghc(aeson-0.6.2.1-92173c75149e34c3bea9cafc379c1c76)
ghc(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57)
ghc(bytestring-0.10.0.2-4f93248f75667c2c3321a7a6761b576f)
ghc(containers-0.5.0.0-ab1dae9a94cd3cc84e7b2805636ebfa2)
ghc(directory-1.2.0.1-91a788fd88acd7f149f0f10f5f1e23f2)
ghc(filepath-1.3.0.1-b12cbe18566fe1532a1fda4c85e31cbe)
ghc(hs-bibutils-5.0-2d57374c0dc5496a2a5dbe978967e4cd)
ghc(mtl-2.1.2-82086cac9073862cbe01e44b81ec8b9b)
ghc(network-2.4.1.2-ceff6721a9d15c92aeb91b7ff1b8e52b)
ghc(old-locale-1.0.0.5-6729cb9d9cc62d150655de8fc5401b91)
ghc(pandoc-1.12.3.3-51ab7910ba3b060a4a564e63ee89da10)
ghc(pandoc-types-1.12.3.3-c3d468d8d6c73c79c7d9e27e420ee842)
ghc(parsec-3.1.3-441f1388bc13de47c52a9ba8a23194f4)
ghc(rfc5051-0.1.0.3-07d34a8cf91684504850cc8dd9e04b8e)
ghc(split-0.2.2-7a3d16e611eda8c6cc8850aa57490f5e)
ghc(syb-0.4.0-c48d52f3188b986ddaa9dd9ae40072f8)
ghc(tagsoup-0.13.1-c3d6820b1044eb7d471a34a2a3d1cee4)
ghc(texmath-0.6.6.1-1019bfdc5f8c6f96cceb9aa6d87bd2f9)
ghc(text-0.11.3.1-e38859e86485c167fa7c9441789e7607)
ghc(time-1.4.0.1-10dc4804a19dc0000fab79908f1a9f50)
ghc(vector-0.10.0.1-869166d5d49db46ce6c328ea5f8defbf)
ghc(xml-1.3.13-88316a3aedcb192026a5065eac016ac8)
ghc(yaml-0.8.8.2-1676b7b777ec167f29831138d4d11e26)
libHSHTTP-4000.2.8-ghc7.6.3.so()(64bit)
libHSaeson-0.6.2.1-ghc7.6.3.so()(64bit)
libHSarray-0.4.0.1-ghc7.6.3.so()(64bit)
libHSattoparsec-0.10.4.0-ghc7.6.3.so()(64bit)
libHSbase-4.6.0.1-ghc7.6.3.so()(64bit)
libHSbase-unicode-symbols-0.2.2.4-ghc7.6.3.so()(64bit)
libHSbase64-bytestring-1.0.0.1-ghc7.6.3.so()(64bit)
libHSbinary-0.5.1.1-ghc7.6.3.so()(64bit)
libHSblaze-builder-0.3.1.1-ghc7.6.3.so()(64bit)
libHSblaze-html-0.6.1.1-ghc7.6.3.so()(64bit)
libHSblaze-markup-0.5.1.5-ghc7.6.3.so()(64bit)
libHSbytestring-0.10.0.2-ghc7.6.3.so()(64bit)
libHSconduit-1.0.13.1-ghc7.6.3.so()(64bit)
libHScontainers-0.5.0.0-ghc7.6.3.so()(64bit)
libHSdata-default-0.5.1-ghc7.6.3.so()(64bit)
libHSdeepseq-1.3.0.1-ghc7.6.3.so()(64bit)
libHSdigest-0.0.1.2-ghc7.6.3.so()(64bit)
libHSdirectory-1.2.0.1-ghc7.6.3.so()(64bit)
libHSdlist-0.5-ghc7.6.3.so()(64bit)
libHSextensible-exceptions-0.1.1.4-ghc7.6.3.so()(64bit)
libHSfilepath-1.3.0.1-ghc7.6.3.so()(64bit)
libHSghc-prim-0.3.0.0-ghc7.6.3.so()(64bit)
libHShashable-1.1.2.5-ghc7.6.3.so()(64bit)
libHShighlighting-kate-0.5.6-ghc7.6.3.so()(64bit)
libHShs-bibutils-5.0-ghc7.6.3.so()(64bit)
libHShslua-0.3.10-ghc7.6.3.so()(64bit)
libHSinteger-gmp-0.5.0.0-ghc7.6.3.so()(64bit)
libHSlifted-base-0.2.2.1-ghc7.6.3.so()(64bit)
libHSmmorph-1.0.0-ghc7.6.3.so()(64bit)
libHSmonad-control-0.3.2.1-ghc7.6.3.so()(64bit)
libHSmtl-2.1.2-ghc7.6.3.so()(64bit)
libHSnetwork-2.4.1.2-ghc7.6.3.so()(64bit)
libHSold-locale-1.0.0.5-ghc7.6.3.so()(64bit)
libHSold-time-1.1.0.1-ghc7.6.3.so()(64bit)
libHSpandoc-1.12.3.3-ghc7.6.3.so()(64bit)
libHSpandoc-types-1.12.3.3-ghc7.6.3.so()(64bit)
libHSparsec-3.1.3-ghc7.6.3.so()(64bit)
libHSpcre-light-0.4-ghc7.6.3.so()(64bit)
libHSpretty-1.1.1.0-ghc7.6.3.so()(64bit)
libHSprimitive-0.5.0.1-ghc7.6.3.so()(64bit)
libHSprocess-1.1.0.2-ghc7.6.3.so()(64bit)
libHSrandom-1.0.1.1-ghc7.6.3.so()(64bit)
libHSresourcet-0.4.10.2-ghc7.6.3.so()(64bit)
libHSrfc5051-0.1.0.3-ghc7.6.3.so()(64bit)
libHSscientific-0.2.0.2-ghc7.6.3.so()(64bit)
libHSsemigroups-0.8.5-ghc7.6.3.so()(64bit)
libHSsplit-0.2.2-ghc7.6.3.so()(64bit)
libHSsyb-0.4.0-ghc7.6.3.so()(64bit)
libHStagsoup-0.13.1-ghc7.6.3.so()(64bit)
libHStemplate-haskell-2.8.0.0-ghc7.6.3.so()(64bit)
libHStemporary-1.1.2.4-ghc7.6.3.so()(64bit)
libHStexmath-0.6.6.1-ghc7.6.3.so()(64bit)
libHStext-0.11.3.1-ghc7.6.3.so()(64bit)
libHStime-1.4.0.1-ghc7.6.3.so()(64bit)
libHStransformers-0.3.0.0-ghc7.6.3.so()(64bit)
libHStransformers-base-0.4.1-ghc7.6.3.so()(64bit)
libHSunix-2.6.0.1-ghc7.6.3.so()(64bit)
libHSunordered-containers-0.2.3.0-ghc7.6.3.so()(64bit)
libHSutf8-string-0.3.7-ghc7.6.3.so()(64bit)
libHSvector-0.10.0.1-ghc7.6.3.so()(64bit)
libHSvoid-0.5.11-ghc7.6.3.so()(64bit)
libHSxml-1.3.13-ghc7.6.3.so()(64bit)
libHSyaml-0.8.8.2-ghc7.6.3.so()(64bit)
libHSzip-archive-0.1.3.4-ghc7.6.3.so()(64bit)
libHSzlib-0.5.4.1-ghc7.6.3.so()(64bit)
libbibutils.so.5()(64bit)
libc.so.6()(64bit)
libdl.so.2()(64bit)
libgmp.so.10()(64bit)
liblua-5.1.so()(64bit)
libm.so.6()(64bit)
libpcre.so.1()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
libutil.so.1()(64bit)
libyaml-0.so.2()(64bit)
libz.so.1()(64bit)
rtld(GNU_HASH)
ghc-pandoc-citeproc-devel (rpmlib, GLIBC filtered):
/bin/sh
ghc(pandoc-citeproc-0.3.1-73e4e05d19d055553f98f636c4bf361f)
ghc-compiler
ghc-devel(HTTP-4000.2.8-6786975a51443bdb5cd8dd2ea9496185)
ghc-devel(aeson-0.6.2.1-92173c75149e34c3bea9cafc379c1c76)
ghc-devel(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57)
ghc-devel(bytestring-0.10.0.2-4f93248f75667c2c3321a7a6761b576f)
ghc-devel(containers-0.5.0.0-ab1dae9a94cd3cc84e7b2805636ebfa2)
ghc-devel(directory-1.2.0.1-91a788fd88acd7f149f0f10f5f1e23f2)
ghc-devel(filepath-1.3.0.1-b12cbe18566fe1532a1fda4c85e31cbe)
ghc-devel(hs-bibutils-5.0-2d57374c0dc5496a2a5dbe978967e4cd)
ghc-devel(mtl-2.1.2-82086cac9073862cbe01e44b81ec8b9b)
ghc-devel(network-2.4.1.2-ceff6721a9d15c92aeb91b7ff1b8e52b)
ghc-devel(old-locale-1.0.0.5-6729cb9d9cc62d150655de8fc5401b91)
ghc-devel(pandoc-1.12.3.3-51ab7910ba3b060a4a564e63ee89da10)
ghc-devel(pandoc-types-1.12.3.3-c3d468d8d6c73c79c7d9e27e420ee842)
ghc-devel(parsec-3.1.3-441f1388bc13de47c52a9ba8a23194f4)
ghc-devel(rfc5051-0.1.0.3-07d34a8cf91684504850cc8dd9e04b8e)
ghc-devel(split-0.2.2-7a3d16e611eda8c6cc8850aa57490f5e)
ghc-devel(syb-0.4.0-c48d52f3188b986ddaa9dd9ae40072f8)
ghc-devel(tagsoup-0.13.1-c3d6820b1044eb7d471a34a2a3d1cee4)
ghc-devel(texmath-0.6.6.1-1019bfdc5f8c6f96cceb9aa6d87bd2f9)
ghc-devel(text-0.11.3.1-e38859e86485c167fa7c9441789e7607)
ghc-devel(time-1.4.0.1-10dc4804a19dc0000fab79908f1a9f50)
ghc-devel(vector-0.10.0.1-869166d5d49db46ce6c328ea5f8defbf)
ghc-devel(xml-1.3.13-88316a3aedcb192026a5065eac016ac8)
ghc-devel(yaml-0.8.8.2-1676b7b777ec167f29831138d4d11e26)
ghc-pandoc-citeproc(x86-64)
Provides
--------
pandoc-citeproc:
pandoc-citeproc
pandoc-citeproc(x86-64)
ghc-pandoc-citeproc:
ghc(pandoc-citeproc-0.3.1-73e4e05d19d055553f98f636c4bf361f)
ghc-pandoc-citeproc
ghc-pandoc-citeproc(x86-64)
libHSpandoc-citeproc-0.3.1-ghc7.6.3.so()(64bit)
ghc-pandoc-citeproc-devel:
ghc-devel(pandoc-citeproc-0.3.1-73e4e05d19d055553f98f636c4bf361f)
ghc-pandoc-citeproc-devel
ghc-pandoc-citeproc-devel(x86-64)
ghc-pandoc-citeproc-static
Unversioned so-files
--------------------
ghc-pandoc-citeproc:
/usr/lib64/ghc-7.6.3/pandoc-citeproc-0.3.1/libHSpandoc-citeproc-0.3.1-ghc7.6.3.so
Source checksums
----------------
http://hackage.haskell.org/package/pandoc-citeproc-0.3.1/pandoc-citeproc-...
:
CHECKSUM(SHA256) this package :
46bc453ccaa6c9534970cb6ba7b78bb9f76655419acd8d59d58d7fa91c2e9319
CHECKSUM(SHA256) upstream package :
46bc453ccaa6c9534970cb6ba7b78bb9f76655419acd8d59d58d7fa91c2e9319
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1098854
Buildroot used: fedora-20-x86_64
Active plugins: Generic, Haskell, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TUmyWrsmxb&a=cc_unsubscribe
9 years, 11 months
[Bug 1115894] Review Request: ghc-hgettext - Bindings to libintl.h (gettext, bindtextdomain)
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1115894
--- Comment #2 from Jens Petersen <petersen(a)redhat.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 4 files have unknown license. Detailed output of
licensecheck in /home/petersen/pkgreview/1115894-ghc-
hgettext/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 174080 bytes in 19 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Haskell:
[x]: This should never happen
===== SHOULD items =====
Generic:
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
http://koji.fedoraproject.org/koji/taskinfo?taskID=7135654
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: ghc-hgettext-0.1.30-1.fc21.x86_64.rpm
ghc-hgettext-devel-0.1.30-1.fc21.x86_64.rpm
ghc-hgettext-0.1.30-1.fc21.src.rpm
ghc-hgettext.x86_64: W: spelling-error Summary(en_US) libintl -> libidinal
ghc-hgettext.x86_64: W: spelling-error Summary(en_US) gettext -> get text,
get-text, Georgette
ghc-hgettext.x86_64: W: spelling-error Summary(en_US) bindtextdomain
ghc-hgettext.x86_64: W: spelling-error %description -l en_US libintl ->
libidinal
ghc-hgettext.x86_64: W: spelling-error %description -l en_US gettext -> get
text, get-text, Georgette
ghc-hgettext.x86_64: W: spelling-error %description -l en_US bindtextdomain
ghc-hgettext.x86_64: W: no-documentation
ghc-hgettext.x86_64: W: no-manual-page-for-binary hgettext
ghc-hgettext.src: W: spelling-error Summary(en_US) libintl -> libidinal
ghc-hgettext.src: W: spelling-error Summary(en_US) gettext -> get text,
get-text, Georgette
ghc-hgettext.src: W: spelling-error Summary(en_US) bindtextdomain
ghc-hgettext.src: W: spelling-error %description -l en_US libintl -> libidinal
ghc-hgettext.src: W: spelling-error %description -l en_US gettext -> get text,
get-text, Georgette
ghc-hgettext.src: W: spelling-error %description -l en_US bindtextdomain
3 packages and 0 specfiles checked; 0 errors, 14 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint ghc-hgettext ghc-hgettext-devel
ghc-hgettext.x86_64: W: spelling-error Summary(en_US) libintl -> libidinal
ghc-hgettext.x86_64: W: spelling-error Summary(en_US) gettext -> get text,
get-text, Georgette
ghc-hgettext.x86_64: W: spelling-error Summary(en_US) bindtextdomain
ghc-hgettext.x86_64: W: spelling-error %description -l en_US libintl ->
libidinal
ghc-hgettext.x86_64: W: spelling-error %description -l en_US gettext -> get
text, get-text, Georgette
ghc-hgettext.x86_64: W: spelling-error %description -l en_US bindtextdomain
ghc-hgettext.x86_64: W: no-documentation
ghc-hgettext.x86_64: W: no-manual-page-for-binary hgettext
2 packages and 0 specfiles checked; 0 errors, 8 warnings.
# echo 'rpmlint-done:'
Requires
--------
ghc-hgettext (rpmlib, GLIBC filtered):
ghc(Cabal-1.16.0-eb3c12450ebbf2810048acb780cbe706)
ghc(array-0.4.0.1-3b78425c10ff2dad7acf7e8c8ae014c3)
ghc(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57)
ghc(bytestring-0.10.0.2-4f93248f75667c2c3321a7a6761b576f)
ghc(containers-0.5.0.0-ab1dae9a94cd3cc84e7b2805636ebfa2)
ghc(cpphs-1.16-15d27b0080912629e5fe51cce6f4d42a)
ghc(deepseq-1.3.0.1-5cc4cd89bdc2e8f6db1833d95ec36926)
ghc(directory-1.2.0.1-91a788fd88acd7f149f0f10f5f1e23f2)
ghc(filepath-1.3.0.1-b12cbe18566fe1532a1fda4c85e31cbe)
ghc(ghc-prim-0.3.0.0-d5221a8c8a269b66ab9a07bdc23317dd)
ghc(hashable-1.1.2.5-e0f2541518f84d3123a819112b4ffe20)
ghc(haskell-src-exts-1.13.5-09569c34818db80ed3a90a5faa4f069a)
ghc(integer-gmp-0.5.0.0-2f15426f5b53fe4c6490832f9b20d8d7)
ghc(old-locale-1.0.0.5-6729cb9d9cc62d150655de8fc5401b91)
ghc(old-time-1.1.0.1-2f8ea093d0c7014780a8a5772f948883)
ghc(pretty-1.1.1.0-66181c695e6a2e173ba2088cf55cc396)
ghc(process-1.1.0.2-76e05340eb66705981411022731ca84a)
ghc(setlocale-0.0.3-c8efec773e4e398af4aea9dcac6b942b)
ghc(syb-0.4.0-c48d52f3188b986ddaa9dd9ae40072f8)
ghc(text-0.11.3.1-e38859e86485c167fa7c9441789e7607)
ghc(time-1.4.0.1-10dc4804a19dc0000fab79908f1a9f50)
ghc(uniplate-1.6.10-9c77af54b48e9237bd9b5b633a0939df)
ghc(unix-2.6.0.1-4f219f792083f70ec440ce406f12ce57)
ghc(unordered-containers-0.2.3.0-c7952fe8bed178bdf8ed4d090730c9da)
libHSCabal-1.16.0-ghc7.6.3.so()(64bit)
libHSarray-0.4.0.1-ghc7.6.3.so()(64bit)
libHSbase-4.6.0.1-ghc7.6.3.so()(64bit)
libHSbytestring-0.10.0.2-ghc7.6.3.so()(64bit)
libHScontainers-0.5.0.0-ghc7.6.3.so()(64bit)
libHScpphs-1.16-ghc7.6.3.so()(64bit)
libHSdeepseq-1.3.0.1-ghc7.6.3.so()(64bit)
libHSdirectory-1.2.0.1-ghc7.6.3.so()(64bit)
libHSfilepath-1.3.0.1-ghc7.6.3.so()(64bit)
libHSghc-prim-0.3.0.0-ghc7.6.3.so()(64bit)
libHShashable-1.1.2.5-ghc7.6.3.so()(64bit)
libHShaskell-src-exts-1.13.5-ghc7.6.3.so()(64bit)
libHSinteger-gmp-0.5.0.0-ghc7.6.3.so()(64bit)
libHSold-locale-1.0.0.5-ghc7.6.3.so()(64bit)
libHSold-time-1.1.0.1-ghc7.6.3.so()(64bit)
libHSpretty-1.1.1.0-ghc7.6.3.so()(64bit)
libHSprocess-1.1.0.2-ghc7.6.3.so()(64bit)
libHSrts-ghc7.6.3.so()(64bit)
libHSsetlocale-0.0.3-ghc7.6.3.so()(64bit)
libHSsyb-0.4.0-ghc7.6.3.so()(64bit)
libHStext-0.11.3.1-ghc7.6.3.so()(64bit)
libHStime-1.4.0.1-ghc7.6.3.so()(64bit)
libHSuniplate-1.6.10-ghc7.6.3.so()(64bit)
libHSunix-2.6.0.1-ghc7.6.3.so()(64bit)
libHSunordered-containers-0.2.3.0-ghc7.6.3.so()(64bit)
libc.so.6()(64bit)
libdl.so.2()(64bit)
libffi.so.6()(64bit)
libgmp.so.10()(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
libutil.so.1()(64bit)
rtld(GNU_HASH)
ghc-hgettext-devel (rpmlib, GLIBC filtered):
/bin/sh
ghc(hgettext-0.1.30-9ff0f41d6b6cbff04b47edcba0be8fd2)
ghc-compiler
ghc-devel(Cabal-1.16.0-eb3c12450ebbf2810048acb780cbe706)
ghc-devel(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57)
ghc-devel(containers-0.5.0.0-ab1dae9a94cd3cc84e7b2805636ebfa2)
ghc-devel(directory-1.2.0.1-91a788fd88acd7f149f0f10f5f1e23f2)
ghc-devel(filepath-1.3.0.1-b12cbe18566fe1532a1fda4c85e31cbe)
ghc-devel(haskell-src-exts-1.13.5-09569c34818db80ed3a90a5faa4f069a)
ghc-devel(process-1.1.0.2-76e05340eb66705981411022731ca84a)
ghc-devel(setlocale-0.0.3-c8efec773e4e398af4aea9dcac6b942b)
ghc-devel(uniplate-1.6.10-9c77af54b48e9237bd9b5b633a0939df)
ghc-hgettext(x86-64)
Provides
--------
ghc-hgettext:
ghc(hgettext-0.1.30-9ff0f41d6b6cbff04b47edcba0be8fd2)
ghc-hgettext
ghc-hgettext(x86-64)
libHShgettext-0.1.30-ghc7.6.3.so()(64bit)
ghc-hgettext-devel:
ghc-devel(hgettext-0.1.30-9ff0f41d6b6cbff04b47edcba0be8fd2)
ghc-hgettext-devel
ghc-hgettext-devel(x86-64)
ghc-hgettext-static
Unversioned so-files
--------------------
ghc-hgettext:
/usr/lib64/ghc-7.6.3/hgettext-0.1.30/libHShgettext-0.1.30-ghc7.6.3.so
Source checksums
----------------
http://hackage.haskell.org/package/hgettext-0.1.30/hgettext-0.1.30.tar.gz :
CHECKSUM(SHA256) this package :
26453a4d359c99c41d462db9f8c9144d172523b3fa7076117a877e6c43f3ffdd
CHECKSUM(SHA256) upstream package :
26453a4d359c99c41d462db9f8c9144d172523b3fa7076117a877e6c43f3ffdd
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1115894
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Haskell, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
There is no License file included in the tarball.
Can you please contact the author about adding one upstream?
What is /usr/bin/hgettext for? Probably it should live
in ghc-hgettext-devel not ghc-hgettext, since it looks like
a devel tool not something needed at runtime.
I think a better package Summary might be "Haskell binding to libintl".
Otherwise the package looks okay to me.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rWkojBl9jh&a=cc_unsubscribe
9 years, 11 months