This is an automated email from the git hooks/post-receive script.

rharwood pushed a commit to branch master in repository gssproxy.

The following commit(s) were added to refs/heads/master by this push: new eafa3c9 Avoid uninitialized free when allocating buffers eafa3c9 is described below

commit eafa3c9272c95646400123f8e4d6fb50cf36d36c Author: Robbie Harwood rharwood@redhat.com AuthorDate: Wed May 1 11:27:13 2019 -0400

Avoid uninitialized free when allocating buffers

Signed-off-by: Robbie Harwood rharwood@redhat.com Reviewed-by: Simo Sorce simo@redhat.com Resolves: #248 --- src/gp_export.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/gp_export.c b/src/gp_export.c index dbfddeb..a5681c0 100644 --- a/src/gp_export.c +++ b/src/gp_export.c @@ -300,6 +300,7 @@ static int gp_encrypt_buffer(krb5_context context, krb5_keyblock *key, &data_in, &enc_handle); if (ret) { + free(enc_handle.ciphertext.data); ret = EINVAL; goto done; } @@ -308,12 +309,12 @@ static int gp_encrypt_buffer(krb5_context context, krb5_keyblock *key, enc_handle.ciphertext.data, out); if (ret) { + free(enc_handle.ciphertext.data); goto done; }

done: free(padded); - free(enc_handle.ciphertext.data); return ret; }