This is an automated email from the git hooks/post-receive script.
rharwood pushed a change to branch master in repository gssproxy.
from adb74c0 Style fixes new 068f417 Fix potential free of non-heap address new 8ba0f42 Prevent uninitialized read in error path of XDR contexts
The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference.
Summary of changes: proxy/src/client/gpm_common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
This is an automated email from the git hooks/post-receive script.
rharwood pushed a commit to branch master in repository gssproxy.
commit 068f4174001c3ea4ae7913fb37210fec84abf1df Author: Robbie Harwood rharwood@redhat.com Date: Mon Sep 11 10:52:03 2017 -0400
Fix potential free of non-heap address
Signed-off-by: Robbie Harwood rharwood@redhat.com Reviewed-by: Simo Sorce simo@redhat.com Merges: #211 --- proxy/src/client/gpm_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxy/src/client/gpm_common.c b/proxy/src/client/gpm_common.c index b50127a..4f31c0c 100644 --- a/proxy/src/client/gpm_common.c +++ b/proxy/src/client/gpm_common.c @@ -562,8 +562,8 @@ static int gpm_send_recv_loop(struct gpm_ctx *gpmctx, char *send_buffer, ret = gpm_retry_socket(gpmctx);
/* Free buffer and set it to NULL to prevent free(xdr_reply_ctx) */ - free(recv_buffer); - recv_buffer = NULL; + free(*recv_buffer); + *recv_buffer = NULL;
if (ret != 0) return ret;
This is an automated email from the git hooks/post-receive script.
rharwood pushed a commit to branch master in repository gssproxy.
commit 8ba0f42f06bc7d0ed68cb2eb3ef2794fc860ac2d Author: Robbie Harwood rharwood@redhat.com Date: Tue Sep 12 12:40:27 2017 -0400
Prevent uninitialized read in error path of XDR contexts
Signed-off-by: Robbie Harwood rharwood@redhat.com Reviewed-by: Simo Sorce simo@redhat.com Merges: #211 --- proxy/src/client/gpm_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxy/src/client/gpm_common.c b/proxy/src/client/gpm_common.c index 4f31c0c..6103d71 100644 --- a/proxy/src/client/gpm_common.c +++ b/proxy/src/client/gpm_common.c @@ -665,8 +665,8 @@ int gpm_make_call(int proc, union gp_rpc_arg *arg, union gp_rpc_res *res) { struct gpm_ctx *gpmctx; gp_rpc_msg msg; - XDR xdr_call_ctx; - XDR xdr_reply_ctx; + XDR xdr_call_ctx = {0}; + XDR xdr_reply_ctx = {0}; char *send_buffer = NULL; char *recv_buffer = NULL; uint32_t send_length;
gss-proxy@lists.fedorahosted.org
-
git repository hosting