----- Original Message -----
From: "Simo Sorce" <simo(a)redhat.com>
To: gss-proxy(a)lists.fedorahosted.org
Sent: Monday, April 13, 2015 3:21:57 PM
Subject: Re: [gssproxy] [patch] Patch for bug #139 ("Remove support for iniparse
library") ...
On Mon, 2015-04-13 at 08:10 -0400, Roland Mainz wrote:
> Attached (as "0001-bug-139-Remove-support-for-iniparse-library.patch")
> is the patch for bug #139
> (
https://fedorahosted.org/gss-proxy/ticket/139 - "Remove support for
> iniparse library").
>
> BTW: I took the liberty to add some comments about the package
> dependencies for $ make tests # to BUILD.txt
Thanks, patch looks good however we shouldn't mix in separate changes.
Also the bug number shouldn't go in the patch subject, but should be a
line on its own right before the sign-off like this:
Fixes:
https://fedorahosted.org/gss-proxy/ticket/139
OK... the new patch is attached as
"0000-remove-support-for-iniparse-library.patch"
Please fix the comment and split the changes to BUILD.txt in a
standalone patch with the subject: "Update BUILD.txt"
OK...
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) rmainz(a)redhat.com
\__\/\/__/ IPA/Kerberos5 team
/O /==\ O\
(;O/ \/ \O;)