>From 191c90bdc17be12bfb4c0c430edcdc975179f6c6 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 28 Mar 2015 17:17:37 +0100 Subject: [PATCH 5/5] Remove dead code The variable behavior is initialized to GPP_UNINITIALIZED therefore the condition ("behavior == GPP_LOCAL_ONLY") on line 114 was every time false. It is a side effect of patch "Properly handle security contexts on error" ab69b71fcf9187269058b4e1ff7b394cc37f19da src/mechglue/gpp_init_sec_context.c:85: assignment: Assigning: "behavior" = "GPP_UNINITIALIZED". src/mechglue/gpp_init_sec_context.c:113: const: At condition "behavior == GPP_LOCAL_ONLY", the value of "behavior" must be equal to 0. src/mechglue/gpp_init_sec_context.c:113: dead_error_condition: The condition "behavior == GPP_LOCAL_ONLY" cannot be true. src/mechglue/gpp_init_sec_context.c:114: dead_error_begin: Execution cannot reach this statement: "maj = 655360U;". --- proxy/src/mechglue/gpp_init_sec_context.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/proxy/src/mechglue/gpp_init_sec_context.c b/proxy/src/mechglue/gpp_init_sec_context.c index c80937c6f2355900f3da3a69c9c30f81a62518d0..dbe9db46efdbe5a08c4e822fb1aebfe03b196f96 100644 --- a/proxy/src/mechglue/gpp_init_sec_context.c +++ b/proxy/src/mechglue/gpp_init_sec_context.c @@ -110,10 +110,6 @@ OM_uint32 gssi_init_sec_context(OM_uint32 *minor_status, /* ok this means a previous call decided to use the local mech, * so let's just re-enter the mechglue here and keep at it */ behavior = GPP_LOCAL_ONLY; - } else if (behavior == GPP_LOCAL_ONLY) { - maj = GSS_S_DEFECTIVE_CREDENTIAL; - min = 0; - goto done; } } else { ctx_handle = calloc(1, sizeof(struct gpp_context_handle)); -- 2.3.4