https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Bug ID: 1056185 Summary: go test code.google.com/p/go.net/ipv6 test fails Product: Fedora EPEL Version: el6 Component: golang-googlecode-net Assignee: lsm5@redhat.com Reporter: tis@foobar.fi QA Contact: extras-qa@fedoraproject.org CC: golang@lists.fedoraproject.org, lsm5@redhat.com, mattdm@redhat.com, vbatts@redhat.com
Description of problem:
%check fails if machine you build this package on has ipv6 connectivity.
+ go test code.google.com/p/go.net/ipv6 --- FAIL: TestConnInitiatorPathMTU (0.00 seconds) sockopt_test.go:58: ipv6.Conn.PathMTU failed: getsockopt: protocol not available --- FAIL: TestConnResponderPathMTU (0.00 seconds) sockopt_test.go:91: ipv6.Conn.PathMTU failed: getsockopt: protocol not available --- FAIL: TestPacketConnReadWriteUnicastUDP (0.00 seconds) unicast_test.go:120: ipv6.PacketConn.SetControlMessage failed: setsockopt: protocol not available FAIL FAIL code.google.com/p/go.net/ipv6 0.041s RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.DbihRB (%check)
I guess package is broken for ipv6.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #1 from Tuomo Soini tis@foobar.fi --- Forgot to tell the version: 0-0.13.hg84a4013f96e0.el6
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #2 from Lokesh Mandvekar lsm5@redhat.com --- yup, I see this now, I'll disable ipv6 check for el6.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #3 from Lokesh Mandvekar lsm5@redhat.com --- I don't think it hurts to have %{import_path}/ipv6 installed for el6 (but not 'go test'ed) though.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #4 from Vincent Batts vbatts@redhat.com --- since that source tarball, there have been a little bit of work done upstream on the ipv6 package.
Before patching out tests, perhaps we should test on a newer snapshot of the repo?
changeset: 106:f720bab54225 user: Mikio Hara mikioh.mikioh@gmail.com date: Wed Jan 01 18:06:29 2014 +0900 summary: go.net/ipv6: better readability in test
changeset: 105:7aeb0fe2819e user: Mikio Hara mikioh.mikioh@gmail.com date: Tue Dec 31 23:24:59 2013 +0900 summary: go.net/ipv6: add missing API tests
changeset: 104:e0d7bfced6e2 user: Mikio Hara mikioh.mikioh@gmail.com date: Tue Dec 31 23:21:39 2013 +0900 summary: go.net/ipv6: remove unused test code
changeset: 103:45528560020f user: Mikio Hara mikioh.mikioh@gmail.com date: Tue Dec 31 23:20:52 2013 +0900 summary: go.net/ipv6: simplfy control message marshaling
changeset: 94:75017ecb835f user: Mikio Hara mikioh.mikioh@gmail.com date: Wed Nov 06 21:33:49 2013 +0900 summary: go.net/ipv6: make it work with Go 1.1
changeset: 93:6aba239cf27b user: Mikio Hara mikioh.mikioh@gmail.com date: Tue Nov 05 10:09:42 2013 +0900 summary: go.net/ipv6: implement getsockopt, setsockopt syscalls
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #5 from Lokesh Mandvekar lsm5@redhat.com --- sure thing
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #6 from Lokesh Mandvekar lsm5@redhat.com --- so the latest revision seems to use %{import_path}/html/charset as well, and a check for them yields this: http://fpaste.org/70381/32344213/ ...we might need to package another code.google.com/p/go.text, not sure if something provides this already
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1056285
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1056285 [Bug 1056285] Review Request: golang-googlecode-text - Supplementary Go text libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #7 from Tuomo Soini tis@foobar.fi --- Same issue with epel7.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #8 from Tuomo Soini tis@foobar.fi --- Another minor issue on epel7:
%if 0%{?fedora} >= 19 BuildArch: noarch %else
Shouldn't this be:
%if 0%{?fedora} >= 19 || 0%{?rhel} >= 7 BuildArch: noarch %else
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #9 from Tuomo Soini tis@foobar.fi --- Tuomo Soini from comment #8)
Another minor issue on epel7:
%if 0%{?fedora} >= 19 BuildArch: noarch %else
Shouldn't this be:
%if 0%{?fedora} >= 19 || 0%{?rhel} >= 7 BuildArch: noarch %else
Actually there is a reason for being arch dependant on epel7 so ignore this.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #10 from Lokesh Mandvekar lsm5@redhat.com --- (In reply to Tuomo Soini from comment #9)
Tuomo Soini from comment #8)
Another minor issue on epel7:
%if 0%{?fedora} >= 19 BuildArch: noarch %else
Shouldn't this be:
%if 0%{?fedora} >= 19 || 0%{?rhel} >= 7 BuildArch: noarch %else
Actually there is a reason for being arch dependant on epel7 so ignore this.
Hi Tuomo,
So past few days I've observed that "go test ..../ipv6" passes without exception for dist-6E-epel, no matter how many times I try.
Moreover, BuildArch: noarch seems to work for all branches, dist-6E-epel and epel7 included.
Anybody got a clue if something magically changed in koji or golang?
I'd appreciate more eyes and more feedback on this, but for now I feel having BuildArch: noarch for all branches and having ipv6 test enabled should be the way to go.
Comments?
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #11 from Lokesh Mandvekar lsm5@redhat.com --- dist-6E-epel: http://koji.fedoraproject.org/koji/taskinfo?taskID=6456130
epel7: http://koji.fedoraproject.org/koji/taskinfo?taskID=6456128
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #12 from Tuomo Soini tis@foobar.fi --- Afaik builders don't have ipv6 connectivity so ipv6 tests are not actually doing real tests. Poblem only happens if you build on a machine with ipv6 connectivity where ipv6 tests can really happen.
Work-aound fo the poblem for now is adding || : at the end of ipv6 test line so failure which happens 100% of build times on a machine with ipv6 connectivity doesn't prevent building package and you could add a comment about ipv6 tests being completely broken on linux.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #13 from Vincent Batts vbatts@redhat.com --- (In reply to Tuomo Soini from comment #12)
Afaik builders don't have ipv6 connectivity so ipv6 tests are not actually doing real tests. Poblem only happens if you build on a machine with ipv6 connectivity where ipv6 tests can really happen.
the test failure is not around ipv6 connectivity. it is failing on particular syscalls on rhel6
Work-aound fo the poblem for now is adding || : at the end of ipv6 test line so failure which happens 100% of build times on a machine with ipv6 connectivity doesn't prevent building package and you could add a comment about ipv6 tests being completely broken on linux.
||: would be a total hack in this situation. that would ignore all tests, for the sake of a single failed case.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #14 from Tuomo Soini tis@foobar.fi --- My suggestion was to ignore ipv6 tests, not all tests.
-GOPATH=%{buildroot}/%{gopath} go test %{import_path}/ipv6 +GOPATH=%{buildroot}/%{gopath} go test %{import_path}/ipv6 || :
When I checked the test cases I saw they skipped all testing if ipv6 is not supported so this wouldn't change anything from current situation.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
John Skeoch jskeoch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|lsm5@redhat.com |jkeck@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Lokesh Mandvekar lsm5@switzerlandmail.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lsm5@switzerlandmail.ch Assignee|jkeck@redhat.com |lsm5@switzerlandmail.ch
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #16 from Tuomo Soini tis@foobar.fi --- How about fixing this issue?
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-net-0-0.15.hg84a4013f96e0.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.15.hg84a40...
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-net-0-0.15.hg84a4013f96e0.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.15.hg84a40...
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-net-0-0.15.hg84a4013f96e0.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.15.hg84a40...
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- Package golang-googlecode-net-0-0.15.hg84a4013f96e0.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing golang-googlecode-net-0-0.15.hg84a4013f96e0.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-1890/golang-googlec... then log in and leave karma (feedback).
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |golang-googlecode-net-0-0.1 | |5.hg84a4013f96e0.el6 Resolution|--- |ERRATA Last Closed| |2014-08-01 12:42:39
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-net-0-0.15.hg84a4013f96e0.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-googlecode-net-0-0.1 |golang-googlecode-net-0-0.1 |5.hg84a4013f96e0.el6 |5.hg84a4013f96e0.fc20
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-net-0-0.15.hg84a4013f96e0.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-googlecode-net-0-0.1 |golang-googlecode-net-0-0.1 |5.hg84a4013f96e0.fc20 |5.hg84a4013f96e0.fc19
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-net-0-0.15.hg84a4013f96e0.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Lokesh Mandvekar lsm5@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|1056285 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1056285 [Bug 1056285] Review Request: golang-googlecode-text - Supplementary Go text libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Tuomo Soini tis@foobar.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Keywords| |Reopened
--- Comment #24 from Tuomo Soini tis@foobar.fi --- 0-0.16.hg90e232e2462d.el6 has this ipv6 issue again.
Lokesh: when you updated you removed ipv6 test work-around.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #25 from Lokesh Mandvekar lsm5@fedoraproject.org --- argh, sorry, I'll check and revert.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Lokesh Mandvekar lsm5@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|lsm5@fedoraproject.org | Assignee|lsm5@fedoraproject.org |lsm5@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #26 from Tuomo Soini tis@foobar.fi --- 0-0.17.hg90e232e2462d.el6 has still ipv6 issue again.
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
--- Comment #27 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-net-0-0.19.hg937a34c9de13.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.19.hg937a3...
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #28 from Fedora Update System updates@fedoraproject.org --- Package golang-googlecode-net-0-0.19.hg937a34c9de13.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing golang-googlecode-net-0-0.19.hg937a34c9de13.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-4796/golang-googlec... then log in and leave karma (feedback).
https://bugzilla.redhat.com/show_bug.cgi?id=1056185
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version|golang-googlecode-net-0-0.1 |golang-googlecode-net-0-0.1 |5.hg84a4013f96e0.fc19 |9.hg937a34c9de13.el6 Resolution|--- |ERRATA Last Closed|2014-08-01 12:42:39 |2015-01-26 15:12:40
--- Comment #29 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-net-0-0.19.hg937a34c9de13.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
golang@lists.fedoraproject.org