On Tue, Dec 19, 2023 at 4:14 PM Brad Smith bradley.g.smith@gmail.com wrote:
At a minimum, I recommend that the patch include the original values for GOPROXY, GOSUMDB, and GOTOOLCHAIN as comments. This makes it easier to change back to default values. At the moment, one has to visit the relevant web pages.
I lean towards providing upstream defaults in this case with updated content on the developer portal (and elsewhere?) with information on why changing these values would be useful. I agree that the comments in the thread are persuasive (for me).
I agree with this. I'd rather keep the patch than revert to upstream defaults.
I would personally go with the 2 and get closer to the upstream. I agree with the npm analogy that was made in the conversation. Furthermore, I don't think that most users, working on Go projects on Fedora, would even know that we provide different Go envars to the upstream ones. IMO, they would change them to upstream values for the benefit of cloning speed, if they knew about them.
Solution 3 and 4 are far too complex for the given value they provide.
If you decide to keep the envars as they are now, I would also agree with having the original values commented.
On Tue, Dec 19, 2023 at 11:11 PM Neal Gompa ngompa13@gmail.com wrote:
On Tue, Dec 19, 2023 at 4:14 PM Brad Smith bradley.g.smith@gmail.com wrote:
At a minimum, I recommend that the patch include the original values for GOPROXY, GOSUMDB, and GOTOOLCHAIN as comments. This makes it easier to change back to default values. At the moment, one has to visit the relevant web pages.
I lean towards providing upstream defaults in this case with updated content on the developer portal (and elsewhere?) with information on why changing these values would be useful. I agree that the comments in the thread are persuasive (for me).
I agree with this. I'd rather keep the patch than revert to upstream defaults.
-- 真実はいつも一つ！/ Always, there's only one truth! -- _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
On Wed Dec 20, 2023 at 12:14 +0100, Ondrej Pohorelsky wrote:
On Tue, Dec 19, 2023 at 11:11 PM Neal Gompa ngompa13@gmail.com wrote:
On Tue, Dec 19, 2023 at 4:14 PM Brad Smith bradley.g.smith@gmail.com wrote:
At a minimum, I recommend that the patch include the original values for GOPROXY, GOSUMDB, and GOTOOLCHAIN as comments. This makes it easier to change back to default values. At the moment, one has to visit the relevant web pages.
I lean towards providing upstream defaults in this case with updated content on the developer portal (and elsewhere?) with information on why changing these values would be useful. I agree that the comments in the thread are persuasive (for me).
I agree with this. I'd rather keep the patch than revert to upstream defaults.
<snip>
If you decide to keep the envars as they are now, I would also agree with having the original values commented.
Can someone clarify what they mean by this? The patch itself [1] makes it pretty clear what the original values are. I think the main thing is improving the user-facing documentation about why we do this and how to restore the original behavior. The Fedora Developer Portal (which really needs to be promoted more; it's a great resource!) documents [2] that we change GOPROXY and GOTOOLCHAIN, but it doesn't mention GOSUMDB, and it's lacking clear instructions about how to change the values back to defaults.
[1]: https://src.fedoraproject.org/rpms/golang/blob/rawhide/f/0001-Modify-go.env.... [2]: https://developer.fedoraproject.org/tech/languages/go/go-installation.html#f...
Greetings -
On Wed, Dec 20, 2023 at 7:35 AM Maxwell G maxwell@gtmx.me wrote:
Can someone clarify what they mean by this? The patch itself [1] makes it pretty clear what the original values are.
When I look at /usr/lib/golang/go.env I see:
---- [bgsmith@pico newversionprep (main *%)]$ more /usr/lib/golang/go.env # This file contains the initial defaults for go command configuration. # Values set by 'go env -w' and written to the user's go/env file override these. # The environment overrides everything else.
# Use the Go module mirror and checksum database by default. # See https://proxy.golang.org for details. GOPROXY=proxy.golang.org,direct GOSUMDB=sum.golang.org
# Automatically download newer toolchains as directed by go.mod files. # See https://go.dev/doc/toolchain for details. GOTOOLCHAIN=auto ------
The go.env file does not, as far as I can tell, contain the original values from upstream. Just the modified values. Unless I modified the file and cannot recall doing so! My suggestion was to include the original upstream settings as comments.
improving the user-facing documentation about why we do this and how to restore the original behavior. The Fedora Developer Portal (which really needs to be promoted more; it's a great resource!) documents [2] that we change GOPROXY and GOTOOLCHAIN, but it doesn't mention GOSUMDB, and it's lacking clear instructions about how to change the values back to defaults.
The updates to this developer portal page with gosumdb were made last month but there has been a delay in publishing to production. Should show up any day.
best regards
On Wed Dec 20, 2023 at 07:57 -0800, Brad Smith wrote:
The go.env file does not, as far as I can tell, contain the original values from upstream. Just the modified values. Unless I modified the file and cannot recall doing so! My suggestion was to include the original upstream settings as comments.
Ah, now I see what you mean. Yes, we should definitely update those comments.
golang@lists.fedoraproject.org
-
Brad Smith -
Maxwell G -
Neal Gompa -
Ondrej Pohorelsky