https://bugzilla.redhat.com/show_bug.cgi?id=1360388
Bug ID: 1360388 Summary: tests fail in currency_test.go:155 Product: Fedora Version: rawhide Component: golang-googlecode-text Assignee: fpokorny@redhat.com Reporter: dan@danny.cz QA Contact: extras-qa@fedoraproject.org CC: fpokorny@redhat.com, golang-updates@lists.fedoraproject.org, jchaloup@redhat.com, lsm5@redhat.com, vbatts@redhat.com Blocks: 467765 (ZedoraTracker)
The build of golang-googlecode-text package fails in the test phase with
... Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.vjXA3A + umask 022 + cd /builddir/build/BUILD + cd text-6fc2e00a0d64b1f7fc1212dae5b0c939cf6d9ac4 + export GOPATH=/builddir/build/BUILDROOT/golang-googlecode-text-0-0.12.git6fc2e00.fc25.s390x//usr/share/gocode:/usr/share/gocode + GOPATH=/builddir/build/BUILDROOT/golang-googlecode-text-0-0.12.git6fc2e00.fc25.s390x//usr/share/gocode:/usr/share/gocode + go test -compiler gc -ldflags '' golang.org/x/text/collate ok golang.org/x/text/collate 0.012s + go test -compiler gc -ldflags '' golang.org/x/text/collate/build ok golang.org/x/text/collate/build 0.004s + go test -compiler gc -ldflags '' golang.org/x/text/collate/colltab ok golang.org/x/text/collate/colltab 1.260s + go test -compiler gc -ldflags '' golang.org/x/text/currency --- FAIL: TestLinking (1.48s) currency_test.go:155: size(symbols)-size(base) was 902; want > 2K FAIL FAIL golang.org/x/text/currency 1.482s error: Bad exit status from /var/tmp/rpm-tmp.vjXA3A (%check) Bad exit status from /var/tmp/rpm-tmp.vjXA3A (%check)
for full logs please see http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2298382
This build is using golang.
Version-Release number of selected component (if applicable): golang-googlecode-text-0-0.12.git6fc2e00.fc25
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=467765 [Bug 467765] Fedora for System z (s390): Bug Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1360388
--- Comment #1 from Jan Chaloupka jchaloup@redhat.com --- Unless, it is a blocker, it does not get fixed. There are other go projects with its own set of failing tests. It would be more beneficial to fix more failing tests at once.
Keeping this bug opened but not guarantee any progress on it.
https://bugzilla.redhat.com/show_bug.cgi?id=1360388
--- Comment #2 from Jan Chaloupka jchaloup@redhat.com --- Meaning, it is better to comment out the test rather than fix it.
https://bugzilla.redhat.com/show_bug.cgi?id=1360388
--- Comment #3 from Dan Horák dan@danny.cz --- I mean the question should be what is more likely wrong - golang-googlecode-text itself, the test case or even the compiler?
https://bugzilla.redhat.com/show_bug.cgi?id=1360388
--- Comment #4 from Jan Chaloupka jchaloup@redhat.com --- The TestLinking compares size of two compiled binaries. First binary comes from this source code (e.g. as main1.go):
package main import ( "fmt" "golang.org/x/text/currency" ) func main() { fmt.Print(currency.CLDRVersion) }
The second one from (e.g. as main2.go):
package main import ( "fmt" "golang.org/x/text/currency" ) func main() { fmt.Print(currency.Symbol(currency.USD)) }
Compiling the code on x86_64 with golang-1.6.2-1.fc25.x86_64 I have: main1: 2971752 main2: 2992416
Evaluated condition from currency_test.go:154 that must hold: size(main2) - size(main1) >= 2*1024
For x86_64 case: 2992416 - 2971752 = 20664 > 2048
https://bugzilla.redhat.com/show_bug.cgi?id=1360388
--- Comment #5 from Jan Chaloupka jchaloup@redhat.com --- Compiling the code on s390x with golang-1.7-0.rc1.fc25.s390x I have: main1: 2391609 main2: 2392511
The difference: 2392511 - 2391609 = 902 < 2048
Answering your question, the test case is not applicable on s390x.
https://bugzilla.redhat.com/show_bug.cgi?id=1360388
--- Comment #6 from Jan Chaloupka jchaloup@redhat.com --- rawhide build: http://koji.fedoraproject.org/koji/buildinfo?buildID=785820 f25 build: http://koji.fedoraproject.org/koji/buildinfo?buildID=785821
https://bugzilla.redhat.com/show_bug.cgi?id=1360388
--- Comment #7 from Dan Horák dan@danny.cz --- s390 f25 build = http://s390.koji.fedoraproject.org/koji/buildinfo?buildID=420823
https://bugzilla.redhat.com/show_bug.cgi?id=1360388
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-07-27 11:33:07
golang-updates@lists.fedoraproject.org