[Bug 197734] Review Request: xmoto - Challenging 2D Motocross Platform Game
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto - Challenging 2D Motocross Platform Game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197734
j.w.r.degoede(a)hhs.nl changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|bugzilla-sink(a)leemhuis.info |j.w.r.degoede(a)hhs.nl
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2006-07-19 05:42 EST -------
MUST:
=====
* rpmlint output is clean
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-x86_64
* BR: ok (see below)
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* .desktop file as required and properly installed
Should fix:
===========
*Redundant BR: SDL-devel (already required through SDL_mixer-devel)requires and
and zlib-devel (through libpng-devel), please remove those from the BR-s
No blockers -> approved!
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
17 years, 9 months
[Bug 199310] Review Request: sturmbahnfahrer - Simulated obstacle course for automobiles
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: sturmbahnfahrer - Simulated obstacle course for automobiles
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199310
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2006-07-19 03:30 EST -------
I'm sure, I'm the packager of plib and for some reason the plib docs advice
linking against -lXi and -lXmu, while both are not used ANYWHERE in plib. Now
X11 is used, but the game does not call any X11 functions itself directly. Thus
it should not link against it, if oneday the libs it uses start support direct
GL rendering with xgl or something like that then X11 will no longer be needed.
So removing those flags from the LIBS line is exactly what I've done in the new
package linked to above. Having a package drag in unused libs through yum etc,
is not what I would call a feature.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
17 years, 9 months
[Bug 199310] Review Request: sturmbahnfahrer - Simulated obstacle course for automobiles
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: sturmbahnfahrer - Simulated obstacle course for automobiles
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199310
------- Additional Comments From panemade(a)gmail.com 2006-07-19 02:02 EST -------
== Not an official review as I'm not yet sponsored ==
Mock build for rawhide i386 is failed. I added some BR's
alsa-lib-devel,libX11-devel,libXmu-devel,libXi-devel. I did it and again did
mock build and its successfull.
* MUST Items:
- rpmlint shows no errors
- dist tag is present.
- The package is named according to the Package Naming Guidelines.
- The spec file name matching the base package Sturmbahnfahrer, in the
format Sturmbahnfahrer.spec.
- This package meets the Packaging Guidelines.
- The spec file for the package MUST be legible.
- The package is licensed with an open-source compatible license GPL.
- This package includes License file COPYING.
- This source package includes the text of the license in its own file,and
that file, containing the text of the license for the package is included in %doc.
- The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct (25d8907b234c9ebaa91c590c6fcbf9ba)
- This package successfully compiled and built into binary rpms for i386
architecture.
- This package did not containd any ExcludeArch.
- This package owns all directories that it creates.
- This package did not contain any duplicate files in the %files
listing.
- This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- This package used macros.
- Document files are included like JOYSTICKS LICENCE README TODO.
- Package did NOT contained any .la libtool archives.
- Desktop file installed correctly and its icon is also visible.
Also,
* Source URL is present and working.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Package worked fine on i386.
You need to add BRs as mentioned above.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
17 years, 9 months