URL: https://github.com/freeipa/freeipa/pull/802 Author: stlaz Title: #802: Improve cert messages some more + do that for KDC certs as well Action: opened
PR body: """ Some of the previous error message handling would not work in a locale different from English so we just output the error message we get from `certutil`.
Also, since this was previously done, there is now kdc cert validation that is different from the others so make the error messages more verbose there.
OpenSSL prints quite verbose messages so you may want to grab only a part of it, let me know what your opinion is. """
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/802/head:pr802 git checkout pr802
URL: https://github.com/freeipa/freeipa/pull/802 Author: stlaz Title: #802: Improve cert messages some more + do that for KDC certs as well Action: synchronized
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/802/head:pr802 git checkout pr802
URL: https://github.com/freeipa/freeipa/pull/802 Title: #802: Improve cert messages some more + do that for KDC certs as well
martbab commented: """ I would personally prefer to let the output as is (be it verbose) rather than spending time on trying to devise some fancy-pants output parsing code that would pull in additional bugs and inconsistencies. """
See the full comment at https://github.com/freeipa/freeipa/pull/802#issuecomment-304261563
URL: https://github.com/freeipa/freeipa/pull/802 Title: #802: Improve cert messages some more + do that for KDC certs as well
stlaz commented: """ I myself don't like having messages like `The server certificate in http.p12 is not valid: certutil: the certificate is invalid: <ERR>` as it sounds like `This office will not tolerate redundancy in this office here.` plus it mentions `certutil` which may other be good or bad, don't know how. But I suppose it's safer to just put it over there and have users see what they can do, so alright. """
See the full comment at https://github.com/freeipa/freeipa/pull/802#issuecomment-304265514
URL: https://github.com/freeipa/freeipa/pull/802 Title: #802: Improve cert messages some more + do that for KDC certs as well
stlaz commented: """ I myself don't like having messages like `The server certificate in http.p12 is not valid: certutil: the certificate is invalid: <ERR>` as it sounds like `This office will not tolerate redundancy in this office here.` plus it mentions `certutil` which may other be good or bad, don't know how. But I suppose it's safer to just put it over there and have users see what they can do, so alright. """
See the full comment at https://github.com/freeipa/freeipa/pull/802#issuecomment-304265514
URL: https://github.com/freeipa/freeipa/pull/802 Title: #802: Improve cert messages some more + do that for KDC certs as well
stlaz commented: """ I myself don't like having messages like `The server certificate in http.p12 is not valid: certutil: the certificate is invalid: <ERR>` as it sounds like `This office will not tolerate redundancy in this office here.` plus it mentions `certutil` which may other be good or bad, don't know. But I suppose it's safer to just put it over there and have users see what they can do, so alright. """
See the full comment at https://github.com/freeipa/freeipa/pull/802#issuecomment-304265514
URL: https://github.com/freeipa/freeipa/pull/802 Author: stlaz Title: #802: Improve cert messages some more + do that for KDC certs as well Action: synchronized
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/802/head:pr802 git checkout pr802
URL: https://github.com/freeipa/freeipa/pull/802 Title: #802: Improve cert messages some more + do that for KDC certs as well
Label: +ack
URL: https://github.com/freeipa/freeipa/pull/802 Title: #802: Improve cert messages some more + do that for KDC certs as well
Label: +pushed
URL: https://github.com/freeipa/freeipa/pull/802 Title: #802: Improve cert messages some more + do that for KDC certs as well
martbab commented: """ master:
* f827fe0f19596d29f9354368077fb43be2e16e8e cert-validate: keep all messages in cert validation * bee3c1eccd44f7671a1455d12235bcbb910494b3 More verbose error message on kdc cert validation
"""
See the full comment at https://github.com/freeipa/freeipa/pull/802#issuecomment-309035747
URL: https://github.com/freeipa/freeipa/pull/802 Author: stlaz Title: #802: Improve cert messages some more + do that for KDC certs as well Action: closed
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/802/head:pr802 git checkout pr802
freeipa-devel@lists.fedorahosted.org