[freeipa PR#2389][opened] Fix translation of 'add' dialog's title for association_table widget
by stanislavlevin
URL: https://github.com/freeipa/freeipa/pull/2389
Author: stanislavlevin
Title: #2389: Fix translation of 'add' dialog's title for association_table widget
Action: opened
PR body:
"""
As for now the default title of add dialogs, which are initialized from 'association_table' widget, is set to something like:
```python
'Add ${other_entity} into ${entity} ${primary_key}'
```
where 'other_entity' and 'entity' are also translatable texts. This construction is used via 'create_add_dialog' method of 'association_table' widget for the all 'Add' actions within
the details of entities.
Such concatenation leads to a bad quality translation and should be replaced with an entire sentence.
From now a mentioned title is taken from a spec and should be specified explicitly.
Fixes: https://pagure.io/freeipa/issue/7714
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2389/head:pr2389
git checkout pr2389
5 years, 6 months
[freeipa PR#2385][opened] Fix translation of 'Add dialog for 'association' facet
by stanislavlevin
URL: https://github.com/freeipa/freeipa/pull/2385
Author: stanislavlevin
Title: #2385: Fix translation of 'Add dialog for 'association' facet
Action: opened
PR body:
"""
As for now the 'Add' dialog title, which is initialized within the details of the entity, contains translatable concatenated texts, like:
```
'Add ${other_entity} into ${entity} ${primary_key}'
```
where 'other_entity' and 'entity' are also translatable texts.
This construction is used via method 'show_add_dialog' of association_facet for the all 'Add' actions within the details of entities.
The concatenation leads to a bad quality translation and should be changed to an entire sentence.
From now a mentioned title is taken from a spec and should be specified explicitly.
Fixes: https://pagure.io/freeipa/issue/7712
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2385/head:pr2385
git checkout pr2385
5 years, 6 months