[freeipa PR#1945][opened] [backport 4.6] pylint3: workaround false positives reported for W1662
by abbra
URL: https://github.com/freeipa/freeipa/pull/1945
Author: abbra
Title: #1945: [backport 4.6] pylint3: workaround false positives reported for W1662
Action: opened
PR body:
"""
Pylint3 falsely reports warning W1662: using a variable that was bound
inside a comprehension for the cases where the same name is reused for a
loop after the comprehension in question.
Rename the variable in a loop to avoid it.
If the code looks like the following:
arr = [f for f in filters if callable(f)]
for f in arr:
result = result + f()
pylint3 would consider 'f' used outside of comprehension. Clearly, this
is a false-positive warning as the second 'f' use is completely
independent of the comprehension's use of 'f'.
Reviewed-By: Aleksei Slaikovskii <aslaikov(a)redhat.com>
(cherry picked from commit c61151f6aa0c033834aed70561fc762c06176555)
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1945/head:pr1945
git checkout pr1945
5 years
[freeipa PR#1922][opened] Radius proxy multiservers fix
by slaykovsky
URL: https://github.com/freeipa/freeipa/pull/1922
Author: slaykovsky
Title: #1922: Radius proxy multiservers fix
Action: opened
PR body:
"""
Now radius proxy plugin allows to add more then one radius server
into radius proxy but the first one from ldap response is being
parsed (you can see ./daemons/ipa-optd/parse.c).
So this kind of behaviour is a bug, as it was determined on IRC.
This patch removes possibility to add more then one radius server
into radius proxy.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1922/head:pr1922
git checkout pr1922
5 years
[freeipa PR#1937][opened] pylint3: workaround false positives reported for W1662
by abbra
URL: https://github.com/freeipa/freeipa/pull/1937
Author: abbra
Title: #1937: pylint3: workaround false positives reported for W1662
Action: opened
PR body:
"""
Pylint3 falsely reports warning W1662: using a variable that was bound
inside a comprehension for the cases where the same name is reused for a
loop after the comprehension in question.
Rename the variable in a loop to avoid it.
If the code looks like the following:
arr = [f for f in filters if callable(f)]
for f in arr:
result = result + f()
pylint3 would consider 'f' used outside of comprehension. Clearly, this
is a false-positive warning as the second 'f' use is completely
independent of the comprehension's use of 'f'.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1937/head:pr1937
git checkout pr1937
5 years
broken freeipa client-only builds
by Rob Crittenden
I can't submit new builds to Fedora from master because a change was
made to the provider of /usr/share/ipa in freeipa-common.
This sub-package is also built for client-only installs but nothing is
creating /usr/share/ipa so packaging fails (and/or freeipa.template will
be missing)
I tried to work around it by excluding it from the client-only build but
then the package is different by architectures:
BuildError: The following noarch package built differently on different
architectures: freeipa-client-common-4.6.90.pre2-2.fc29.noarch.rpm
rpmdiff output was:
error: cannot open Packages index using db5 - Permission denied (13)
error: cannot open Packages database in /var/lib/rpm
error: cannot open Packages database in /var/lib/rpm
removed /usr/share/ipa/freeipa.template
The commit that moved this is ce3819c3b7fdb511b7e4c38a365629a187d65f75
I think this might require more careful thought than me just moving
stuff around until it builds.
rob
5 years
Zanata translation .pot updated for 4.7 release
by Alexander Bokovoy
Hi Translators,
we have updated a translation template for FreeIPA master branch in
Zanata. Previous update was in September 2017, so there are some changes
accumulated.
FreeIPA 4.6.90.pre2 was released today and we are expecting to have
4.7.0 released in upcoming weeks. It would be good to improve
translations with a 4.7.0 release.
Thank you for your effort in advance!
--
/ Alexander Bokovoy
Sr. Principal Software Engineer
Security / Identity Management Engineering
Red Hat Limited, Finland
5 years