[freeipa PR#1640][opened] Return a value if exceptions are raised in server uninstall
by rcritten
URL: https://github.com/freeipa/freeipa/pull/1640
Author: rcritten
Title: #1640: Return a value if exceptions are raised in server uninstall
Action: opened
PR body:
"""
The server uninstall relies on the Continuous class which will
not re-raise exceptions, only log them.
The AdminTool class purports to "call sys.exit() with the return
value" but most of the run implementations returned no value, or
the methods they called returned nothing so there was nothing to
return, so this was a no-op.
The fix is to capture and bubble up the return values and to
return 1 if any exceptions are caught in Continuous, the exception
being SystemExit which is what is raised when sys.exit() is called.
This potentially affects other users in that when executing the
steps of an installer or uninstaller the highest return code
will be the exit value of that installer.
https://pagure.io/freeipa/issue/7330
Signed-off-by: Rob Crittenden <rcritten(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1640/head:pr1640
git checkout pr1640
6 years
IP addresses in Subject Alt Name
by Ian Pilcher
I have an older NETGEAR switch that has annoying habit of using its IP
address in URLs that it sends back to the browser. The result can be
seen here:
https://www.penurio.us/oops.png
I would like to add the switch's IP address to the Subject Alt Name
extension of its TLS certificate, which is not currently supported by
FreeIPA.
I'm interested in trying to add this capability, if there's a chance
that my work will be accepted. My initial thought is that an IP address
should only be accepted if all of the following are true:
1. One of the hostnames in the Subject Alt Name (or possibly the Common
Name) ultimately resolves to that IP address, possibly via one or
more CNAMEs.
2. All of the DNS records (A, AAAA, CNAME) involved in #1 are managed by
this IPA instance.
3. The reverse DNS record for the IP address is managed by this IPA
instance, and it points to an A or AAAA record that is managed by
this IPA instance (and contains the correct IP address).
Does this make sense?
--
========================================================================
Ian Pilcher arequipeno(a)gmail.com
-------- "I grew up before Mark Zuckerberg invented friendship" --------
========================================================================
6 years