[freeipa PR#1372][opened] Test self-signed > external CA > self-signed test case.
by Rezney
URL: https://github.com/freeipa/freeipa/pull/1372
Author: Rezney
Title: #1372: Test self-signed > external CA > self-signed test case.
Action: opened
PR body:
"""
Various changes are being done in this PR:
1. In order to avoid boilerplate code we add a function for signing a CA.
2. We add self-signed > external CA > self-signed test case itself + introduce two new constants.
3. We move create_caless_pki.py and create_external_ca.py modules to pytest_plugins. Details:
Till now both create_caless_pki.py and create_external_ca.py were
stored in test_integration folder. However when trying to import
e.g. "from create_external_ca import ExternalCA" from tasks.py
where all other integration test`s support functions lives we get
"AttributeError: module 'pytest' has no attribute 'config' as pytest
was not completely initialized at the moment of the import.
Backtrace from the issue:
`
File "/usr/lib/python3.6/site-packages/_pytest/config.py", line 421, in consider_module
self._import_plugin_specs(getattr(mod, 'pytest_plugins', []))
File "/usr/lib/python3.6/site-packages/_pytest/config.py", line 426, in _import_plugin_specs
self.import_plugin(import_spec)
File "/usr/lib/python3.6/site-packages/_pytest/config.py", line 443, in import_plugin
__import__(importspec)
File "/usr/lib/python3.6/site-packages/ipatests/pytest_plugins/integration/__init__.py", line 37, in <module>
from . import tasks
File "<frozen importlib._bootstrap>", line 961, in _find_and_load
File "<frozen importlib._bootstrap>", line 950, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 646, in _load_unlocked
File "<frozen importlib._bootstrap>", line 616, in _load_backward_compatible
File "/usr/lib/python3.6/site-packages/_pytest/assertion/rewrite.py", line 212, in load_module
py.builtin.exec_(co, mod.__dict__)
File "/usr/lib/python3.6/site-packages/ipatests/pytest_plugins/integration/tasks.py", line 47, in <module>
from ipatests.test_integration.create_external_ca import ExternalCA
File "/usr/lib/python3.6/site-packages/ipatests/test_integration/__init__.py", line 22, in <module>
ipatests.util.check_ipaclient_unittests()
File "/usr/lib/python3.6/site-packages/ipatests/util.py", line 71, in check_ipaclient_unittests
if pytest.config.getoption('ipaclient_unittests', False):
AttributeError: module 'pytest' has no attribute 'config'
`
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1372/head:pr1372
git checkout pr1372
6 years, 3 months
[freeipa PR#1431][opened] Fixing test_testconfig with proper asserts
by felipevolpone
URL: https://github.com/freeipa/freeipa/pull/1431
Author: felipevolpone
Title: #1431: Fixing test_testconfig with proper asserts
Action: opened
PR body:
"""
When the `cls` in env_config.py is a WinHost, the `__init__` receives different
parameters. Now, it's adapted to all different kinds of hosts.
Also, it's necessary to add the host_type field to most of the domains created in the
test classes, because the field is returned by `pytest_multihost.Config`
in `pytest_plugins/integration/config.py::Config::to_dict`
Fixes: [#7346](https://pagure.io/freeipa/issue/7346)
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1431/head:pr1431
git checkout pr1431
6 years, 3 months
[freeipa PR#1437][opened] Idviews: fix objectclass violation on idview-add
by flo-renaud
URL: https://github.com/freeipa/freeipa/pull/1437
Author: flo-renaud
Title: #1437: Idviews: fix objectclass violation on idview-add
Action: opened
PR body:
"""
When the option --domain-resolution-order is used with the command
ipa idview-add, the resulting LDAP object stores the value in
ipadomainresolutionorder attribute.
The issue is that the add command does not add the needed object
class (ipaNameResolutionData) because it is part of
possible_objectclasses but not of object_class.
The fix makes sure to add the objectclass when the option
--domain-resolution-order is used, and adds a non-regression test.
Note that idview-mod does not have any issue as it correctly handles
the addition of missing possible objectclasses.
Fixes:
https://pagure.io/freeipa/issue/7350
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1437/head:pr1437
git checkout pr1437
6 years, 3 months