https://bugzilla.redhat.com/show_bug.cgi?id=1805743
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com --- Review:
This package follows new fonts packaging guidelines.
Rpmlint ------- Checking: impallari-dancing-script-fonts-2.000-1.20191208gitf7f54bc.fc33.noarch.rpm
impallari-dancing-script-fonts-2.000-1.20191208gitf7f54bc.fc33.src.rpm impallari-dancing-script-fonts.noarch: W: spurious-executable-perm /usr/share/doc/impallari-dancing-script-fonts/FONTLOG.txt impallari-dancing-script-fonts.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/impallari-dancing-script-fonts/FONTLOG.txt 2 packages and 0 specfiles checked; 1 errors, 1 warnings.
Source checksums ---------------- https://github.com/impallari/DancingScript/archive/f7f54bc1b8836601dae869666... : CHECKSUM(SHA256) this package : f9e396da5f5ead7073d6106c39d4bc849fb193afd0dd4cece2fae7549401bedd CHECKSUM(SHA256) upstream package : f9e396da5f5ead7073d6106c39d4bc849fb193afd0dd4cece2fae7549401bedd
Requires -------- impallari-dancing-script-fonts (rpmlib, GLIBC filtered): config(impallari-dancing-script-fonts) fontpackages-filesystem
Provides -------- impallari-dancing-script-fonts: config(impallari-dancing-script-fonts) font(dancingscript) impallari-dancing-script-fonts metainfo() metainfo(org.fedoraproject.impallari-dancing-script-fonts.metainfo.xml)
All other things like license, config, metainfo files looks good.
Issues: 1) Fix the rpmlint warnings/errors before import of this package 2) I looked for %license in this package spec but cannot find it. Shouldn't we need to mark some file say OFL.txt as %license? I see in other packages when you create -doc subpackage %license gets marked automatically.
APPROVED.
fonts-bugs@lists.fedoraproject.org