Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #10 from fujiwara tfujiwar@redhat.com 2010-03-29 05:38:32 EDT --- Created an attachment (id=403248) --> (https://bugzilla.redhat.com/attachment.cgi?id=403248) Patch for gnome-themes Clearlooks/metacity-theme-1.xml
If my suggestion is ok, I'll file an upstream bug later.
fill_env() assigns title_height and top_height in metacity ui/theme.c
fill_env () { env->top_height = info->fgeom->top_height; env->title_height = info->title_layout_height; }
meta_frame_style_draw_with_style() calculates the font height and assigns the value in title_height.
meta_frame_style_draw_with_style () { pango_layout_get_pixel_extents (title_layout, NULL, &extents);
draw_info.title_layout_height = title_layout ? extents.height : 0; }
But meta_frame_layout_get_borders() calculates top_height with text_height + title_border.top + title_border.bottom so I think using top_height makes sense for the title vertical line.
meta_frame_layout_get_borders () { buttons_height = layout->button_height + layout->button_border.top + layout->button_border.bottom; title_height = text_height + layout->title_vertical_pad + layout->title_border.top + layout->title_border.bottom;
if (top_height) { *top_height = MAX (buttons_height, title_height); } }
fill_env() doesn't use info->fgeom->bottom_titlebar_edge so my suggestion is to use "top_height - 3".