[Bug 424881] Review Request: fontmatrix - Font manager
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: fontmatrix - Font manager
https://bugzilla.redhat.com/show_bug.cgi?id=424881
pnemade(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs?
------- Additional Comments From pnemade(a)redhat.com 2007-12-20 22:53 EST -------
New Package CVS Request
=======================
Package Name: fontmatrix
Short Description: Font manager
Owners: pnemade
Branches: F-8
InitialCC:
Cvsextras Commits: no
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
16 years, 4 months
[Bug 424881] Review Request: fontmatrix - Font manager
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: fontmatrix - Font manager
https://bugzilla.redhat.com/show_bug.cgi?id=424881
wolfy(a)nobugconsulting.ro changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From wolfy(a)nobugconsulting.ro 2007-12-20 12:27 EST -------
There is a suggestion that I would like to make before the formal review: use
"svn export" instead of checkout, because otherwise all files will have
incorrect timestamps (they get the time of the checkout instead of their
original timestamp)
Please also note that the command listed in the spec ( cmake ../fontmatrix &&
make package_source ) did not work for me because cmake fails with
-- Building Fontmatrix 0.3.0svn
CMake Error: Qt qmake not found!
-- Configuring done
qt4-x11 does not provide qmake.
Package Review
==============
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format %{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: x86_64
[x] Rpmlint output:
fontmatrix.x86_64: W: incoherent-version-in-changelog 0.3.0-2.r253.fc8
0.3.0-2.r253.fc9
--> I suggest dropping the ".fc8" from the changelog entries (or using %dist),
otherwise all rpms but the fc8 one will exhibit this message
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[!] License field in the package spec file matches the actual license.
License type:GPLv2
Actual license: GPLv2+
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
Verified by using
svn co -r 253 http://svn.gna.org/svn/undertype/trunk/tools/typotek
tar xzf fontmatrix-0.3.0-Source.tar.gz
diff -r typotek fontmatrix-0.3.0-Source/
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[x] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: devel/x86_64 by me and in koji by the original submitter
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on:ppc,ppc64,i386,x86_64
[x] Package functions as described.
[x] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files are correct.
[-] File based requires are sane.
=== Issues ===
1. timestamps from svn are not preserved
2. according to the .h/.ccp files which are included, license should be GPLv2+
3. there is a duplicate BuildRequires: qt4-x11 is already brought in by qt4-devel
As I don't see any major problems, the package is APPROVED but please correct
the above issues and especially the license tag before uploading to cvs.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
16 years, 4 months
[Bug 426178] New: gtkdoc-scan fails on pango
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=426178
Summary: gtkdoc-scan fails on pango
Product: Fedora
Version: rawhide
Platform: ia64
OS/Version: Linux
Status: NEW
Severity: high
Priority: high
Component: pango
AssignedTo: besfahbo(a)redhat.com
ReportedBy: dchapman(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: fedora-fonts-bugs-list(a)redhat.com
Description of problem:
This is seen on ia64 where it causes the generated pango-scan binary to
segfault, not sure why we get away with it on other platforms but the root
problem exists everywhere.
When building pango these warnings are seen:
pango-scan.c:44: warning: implicit declaration of function 'pango_ot_info_get_type'
pango-scan.c:45: warning: implicit declaration of function
'pango_ot_ruleset_get_type'
Then pango-scan later fails.
The undeclared functions are defined in pango-ot-private.h but only pango-ot.h
is included in docs/pango.types.
I moved the 2 declarations from pango-ot-private.h to pango-ot.h and it fixes my
build issue. I will attach a patch.
Version-Release number of selected component (if applicable):
pango-1.19.1-1.fc9
How reproducible:
Steps to Reproduce:
1.
2.
3.
Actual results:
Expected results:
Additional info:
------- Additional Comments From dchapman(a)redhat.com 2007-12-18 19:55 EST -------
Created an attachment (id=289968)
--> (https://bugzilla.redhat.com/attachment.cgi?id=289968&action=view)
patch to move needed declarations to pango-ot.h
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
16 years, 4 months
[Bug 317641] xorg-x11 fonts with bad licenses need to be fixed or removed
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: xorg-x11 fonts with bad licenses need to be fixed or removed
https://bugzilla.redhat.com/show_bug.cgi?id=317641
mtasaka(a)ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtasaka(a)ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-12-18 22:43 EST -------
Hi!
I tried to "locate luxi" and this seems to also affect
/usr/lib/python2.5/site-packages/reportlab/fonts/luxiserif.ttf
/usr/lib/python2.5/site-packages/reportlab/fonts/luxiserif_license.txt
in python-reportlab-2.1-1.fc8 (license text seems the same) ?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
16 years, 4 months
[Bug 317641] xorg-x11 fonts with bad licenses need to be fixed or removed
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: xorg-x11 fonts with bad licenses need to be fixed or removed
https://bugzilla.redhat.com/show_bug.cgi?id=317641
bugzilla(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|devel |rawhide
tcallawa(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Luxi fonts need to be |xorg-x11 fonts with bad
|removed |licenses need to be fixed or
| |removed
------- Additional Comments From tcallawa(a)redhat.com 2007-12-18 17:51 EST -------
The Luxi fonts are removed from xorg-x11-fonts in rawhide (7.2-5).
While I was in there, I audited the licenses for the rest of the fonts, and
caught a few more that probably should not be there:
- ibm-type1 (Courier) does not have permission to modify. Working with Josh
Boyer to try to get IBM to fix the license, otherwise, I'll pull that font
before F-9.
- misc-meltho (Meltho Syrian) has the same problem as the Luxi fonts, contacted
the copyright holder to try to get a license change, otherwise, I'll have to
pull it before F-9.
I'm just going to use this issue to track fonts that may need to be removed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
16 years, 4 months
[Bug 424881] Review Request: fontmatrix - Font manager
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: fontmatrix - Font manager
https://bugzilla.redhat.com/show_bug.cgi?id=424881
------- Additional Comments From panemade(a)gmail.com 2007-12-17 20:47 EST -------
(In reply to comment #4)
> The name seems correct to me.
> However there are a few errros
> - cosmetic:
> - removed work soon from description
> - remove redundand BR: gcc-c++
> should be
> - removed _word_ "soon" from description
> - remove _redundant_ BR
> But anyway, I would just rephrase everything to "spec cleanup".
Will do above changes. Some reviewer/packagers want to write more explicit
some want to write only spec cleanup. I like to write spec cleanup but after
seeing many peoples requesting or writing even simple change in changelog I
decided to follow them. But anyway I changed that to "spec cleanup"
>
> - serious: there is a missing BR for cmake
Fixed in new version.
>
> - %build should follow the steps described at
> http://fedoraproject.org/wiki/Packaging/cmake and I mean here "%cmake ." instead
> of "cmake .". Your version leads to build errors in mock
>
Fixed in new version. Though I added ctest but there is no tests currently. So
should I remove it or I should let it be as per cmake guidelines.
> - could you please let me how to verify the sources (or better said, where to
> get qmake from) ? I have done a svn checkout, but I was stopped by the following
> error:
> [wolfy@wolfy fontmatrix]$ cmake ../fontmatrix
> -- Building Fontmatrix 0.3.0svn
> CMake Error: Qt qmake not found!
> -- Configuring done
> I have tried to locate qmake using:
> [wolfy@wolfy2 ~]$ sudo yum -c /tmp/fedora-devel-x86_64.cfg search \*qmake\*
> Setting up repositories
> Reading repository metadata in from local files
> No Matches found
> but failed, as one can see above. Google suggest kdevelop, but it does not seem
> to be provided by it, either.
>
>
You need qt4-x11 package.
Spec URL: http://paragn.fedorapeople.org/fontmatrix/fontmatrix.spec
SRPM URL:
http://paragn.fedorapeople.org/fontmatrix/fontmatrix-0.3.0-2.r253.fc8.src...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
16 years, 4 months