Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: [or_IN] - Editor's Title appearing with Underline for smc-meera-font
https://bugzilla.redhat.com/show_bug.cgi?id=530085
Summary: [or_IN] - Editor's Title appearing with Underline for smc-meera-font Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Keywords: i18n Severity: medium Priority: low Component: fontconfig AssignedTo: besfahbo@redhat.com ReportedBy: aalam@redhat.com QAContact: extras-qa@fedoraproject.org CC: petersen@redhat.com, besfahbo@redhat.com, fedora-fonts-bugs-list@redhat.com, psatpute@redhat.com, fedora-i18n-bugs@redhat.com Classification: Fedora Target Release: --- Clone Of: 526396
Created an attachment (id=365513) --> (https://bugzilla.redhat.com/attachment.cgi?id=365513) or_IN Screenshot with gedit, kwrite, and gnome-terminal,
Bug is clone because of Nature for Bug is same, Actually Bug for Ref is Bz #523454
+++ This bug was initially created as a clone of Bug #526396 +++
Created an attachment (id=363117) --> (https://bugzilla.redhat.com/attachment.cgi?id=363117) The affected theme snapshot with meera font
Description of problem: For any editor e.g. oowriter, gedit, when smc-meera-font is selected, its showing underline below the Title, making the editor look ugly. Seems a clearlooks-compact-gnome-theme bug.
Version-Release number of selected component (if applicable): metacity-2.26.0-1.fc11.i586
How reproducible: Always.
Steps to Reproduce: 1. Login system with malayalam locale. (ml_IN) 2. Go to System --> Preferences --> Appearance 3. Select Theme as "Clearlooks" 4. Open and Observe any editor or the theme window title itself.
Actual results: The Underline appears on the Title Window with meera font and clearlooks combination.
Expected results: Underline should not appear.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #1 from A S Alam aalam@redhat.com 2009-10-21 10:02:10 EDT --- Detail
Language: Oriya (or_IN) Font: lohit-oriya-fonts-2.4.3-2.fc12.noarch fontconfig-2.7.3-1.fc12.x86_64 Fedora: Rawhide (20Oct2009) Installation: Fresh installation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
A S Alam aalam@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|[or_IN] - Editor's Title |[or_IN] - Editor's Title |appearing with Underline |appearing with Underline |for smc-meera-font |for Oriya Lohit Fonts | |(Default Fonts)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
Pravin Satpute psatpute@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mclasen@redhat.com Component|fontconfig |gnome-themes AssignedTo|besfahbo@redhat.com |mclasen@redhat.com
--- Comment #2 from Pravin Satpute psatpute@redhat.com 2009-10-23 07:29:28 EDT --- here we dont have a scaling rules, like we have for meera fonts so dont looks like fontconfig bug,
i guess there is some problem in fedora default theme only reassigning to gnome-theme
while testing this bug, after login in or_IN locale, bug appears with Kwrite and firefox application
if we set window title font Lohit-Hindi, then everything works fine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|[or_IN] - Editor's Title |[or_IN] - window titles |appearing with Underline |appearing with Underline |for Oriya Lohit Fonts |for default Oriya Lohit |(Default Fonts) |Font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|[or_IN] - window titles |[or_IN] window titlebar has |appearing with Underline |horizontal line |for default Oriya Lohit | |Font |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
Pravin Satpute psatpute@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|[or_IN] window titlebar has |[or_IN] [mr_IN] [hi_IN] |horizontal line |window titlebar has | |horizontal line
--- Comment #4 from Pravin Satpute psatpute@redhat.com 2009-12-10 04:16:40 EDT --- while testing same for other locale i found problem there as well
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
Manoj Kumar Giri mgiri@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mgiri@redhat.com
--- Comment #5 from Manoj Kumar Giri mgiri@redhat.com 2009-12-21 06:58:34 EDT --- I faced the same problem while testing for Oriya interface (or_IN) in most of the applications in Rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
A S Alam aalam@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |574354
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #6 from Pravin Satpute psatpute@redhat.com 2010-03-22 03:37:03 EDT --- i tested with changing 'hhea' true type fonts table in lohit fonts. but this is different problem
whenever we login in any indic locale or sinhala says, things work well as far windows title bar text is in local script.
but as soon as we open any application having titlebar in ascii, title bar border gets displaced and its make appearances bad.
just border line placements keeps on varying as per default local script fonts and ascii script fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #7 from Pravin Satpute psatpute@redhat.com 2010-03-22 04:10:19 EDT --- Created an attachment (id=401665) --> (https://bugzilla.redhat.com/attachment.cgi?id=401665) taken evince screenshot in kannada locale
if we open any other application having titlebar test in current locale script, it show titlebar proper without any problem of border misplacement
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #8 from Pravin Satpute psatpute@redhat.com 2010-03-24 05:24:13 EDT --- filed upstream bug against GTK+
https://bugzilla.gnome.org/show_bug.cgi?id=613778
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
fujiwara tfujiwar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tfujiwar@redhat.com
--- Comment #9 from fujiwara tfujiwar@redhat.com 2010-03-26 05:55:34 EDT --- I guess bug 574354 is duplicated.
Fedora theme is ClearLooks and some other themes work fine. Probably I think downing the line position is better than narrowing the title height. The following is the workaround but still needs the better fix.
--- /usr/share/themes/Clearlooks/metacity-1/metacity-theme-1.xml.orig 2010-03-25 22:15:04.000000000 +0900 +++ /usr/share/themes/Clearlooks/metacity-1/metacity-theme-1.xml 2010-03-26 18:39:30.000000000 +0900 @@ -223,7 +223,7 @@ <color value="shade/gtk:bg[SELECTED]/1.02"/> </gradient>
- <line color="shade/gtk:bg[SELECTED]/0.7" x1="1" y1="title_height + 6" x2="width - 2" y2="title_height + 6"/> + <line color="shade/gtk:bg[SELECTED]/0.7" x1="1" y1="title_height + 10" x2="width - 2" y2="title_height + 10"/>
<!-- ** border outline ** --> <line color="shade/gtk:bg[NORMAL]/0.45" x1="0" y1="title_height + 6" x2="0" y2="height"/> @@ -290,7 +290,7 @@ <color value="shade/gtk:bg[NORMAL]/0.95"/> </gradient>
- <line color="shade/gtk:bg[NORMAL]/0.65" x1="1" y1="title_height + 6" x2="width - 2" y2="title_height + 6"/> + <line color="shade/gtk:bg[NORMAL]/0.65" x1="1" y1="title_height + 10" x2="width - 2" y2="title_height + 10"/> <rectangle color="shade/gtk:bg[NORMAL]/0.55" filled="false" x="0" y="0" width="width - 1" height="height - 1"/> </draw_ops>
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #10 from fujiwara tfujiwar@redhat.com 2010-03-29 05:38:32 EDT --- Created an attachment (id=403248) --> (https://bugzilla.redhat.com/attachment.cgi?id=403248) Patch for gnome-themes Clearlooks/metacity-theme-1.xml
If my suggestion is ok, I'll file an upstream bug later.
fill_env() assigns title_height and top_height in metacity ui/theme.c
fill_env () { env->top_height = info->fgeom->top_height; env->title_height = info->title_layout_height; }
meta_frame_style_draw_with_style() calculates the font height and assigns the value in title_height.
meta_frame_style_draw_with_style () { pango_layout_get_pixel_extents (title_layout, NULL, &extents);
draw_info.title_layout_height = title_layout ? extents.height : 0; }
But meta_frame_layout_get_borders() calculates top_height with text_height + title_border.top + title_border.bottom so I think using top_height makes sense for the title vertical line.
meta_frame_layout_get_borders () { buttons_height = layout->button_height + layout->button_border.top + layout->button_border.bottom; title_height = text_height + layout->title_vertical_pad + layout->title_border.top + layout->title_border.bottom;
if (top_height) { *top_height = MAX (buttons_height, title_height); } }
fill_env() doesn't use info->fgeom->bottom_titlebar_edge so my suggestion is to use "top_height - 3".
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #11 from fujiwara tfujiwar@redhat.com 2010-03-29 05:42:05 EDT --- (In reply to comment #10)
But meta_frame_layout_get_borders() calculates top_height with text_height + title_border.top + title_border.bottom so I think using top_height makes sense for the title vertical line.
s/vertical line/horizontal line/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #12 from Pravin Satpute psatpute@redhat.com 2010-03-29 06:10:43 EDT --- hi i tried patch in comment #10 in fedora 13 but still no positive result
i followed following stpes:
1) apply patch to /usr/share/themes/Clearlooks/metacity-1/metacity-theme-1.xml 2) logoff and login in kn_IN (Kannada) locale 3) open any application having titlebar in latin/ascii 4) open gnome-terminal or evince 5) Maximize windows you can see underline again in titlebar
looks like we need some fix from GTK or metacity itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #13 from fujiwara tfujiwar@redhat.com 2010-03-29 06:37:27 EDT --- Thanks for the quick test.
(In reply to comment #12)
- Maximize windows you can see underline again in titlebar
Ah, I forgot to modify the maximize property. The value is also saved in the same metacity-theme-1.xml
I'll update it tomorrow.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
fujiwara tfujiwar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #403248|0 |1 is obsolete| |
--- Comment #14 from fujiwara tfujiwar@redhat.com 2010-03-29 07:19:25 EDT --- Created an attachment (id=403267) --> (https://bugzilla.redhat.com/attachment.cgi?id=403267) Patch for gnome-themes Clearlooks/metacity-theme-1.xml
(In reply to comment #13)
I'll update it tomorrow.
Revised the patch.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
Pravin Satpute psatpute@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(mclasen@redhat.co | |m)
--- Comment #15 from Pravin Satpute psatpute@redhat.com 2010-03-29 08:06:29 EDT --- fujiwara thats great!! It works fine now, i also tested for other locale things look fine so it is not creating any regression as well
it is also fixing long standing https://bugzilla.redhat.com/show_bug.cgi?id=523454
Matthias can you take a look at it?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
fujiwara tfujiwar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #403267|0 |1 is obsolete| |
--- Comment #16 from fujiwara tfujiwar@redhat.com 2010-03-30 04:12:14 EDT --- Created an attachment (id=403428) --> (https://bugzilla.redhat.com/attachment.cgi?id=403428) Patch for gnome-themes Clearlooks/metacity-theme-1.xml
Also applied the similar fix to ClearlooksClassic, Glossy and Inverted metacity themes.
It seems today gnome-themes was updated in rawhide. I'll check it later.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #17 from fujiwara tfujiwar@redhat.com 2010-03-30 06:54:52 EDT --- https://bugzilla.gnome.org/show_bug.cgi?id=614343
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #18 from A S Alam aalam@redhat.com 2010-04-02 22:39:43 EDT --- Fedora 13, with gnome-2-30 (gnome-themes-2.30.0-2.fc13.noarch), Punjabi (pa_IN) locale is effected.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #19 from Fedora Update System updates@fedoraproject.org 2010-04-07 07:15:40 EDT --- gnome-themes-2.28.1-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/gnome-themes-2.28.1-3.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ON_QA
--- Comment #20 from Fedora Update System updates@fedoraproject.org 2010-04-08 21:38:17 EDT --- gnome-themes-2.28.1-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gnome-themes'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/gnome-themes-2.28.1-3.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #21 from Pravin Satpute psatpute@redhat.com 2010-04-09 00:34:49 EDT --- did we missed pushing this update for F13? i have tested same for F13 and its working fine, so i can quickly add 1 karma for it :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
--- Comment #22 from Fedora Update System updates@fedoraproject.org 2010-04-10 06:30:09 EDT --- gnome-themes-2.28.1-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(mclasen@redhat.co | |m) | Status|ON_QA |CLOSED Fixed In Version| |gnome-themes-2.28.1-3.fc12 Resolution| |ERRATA
fonts-bugs@lists.fedoraproject.org