Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526633
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psatpute@redhat.com AssignedTo|nobody@fedoraproject.org |nicolas.mailhot@laposte.net Flag| |fedora-review?, | |needinfo?(sanjay.ankur@gmai | |l.com)
--- Comment #3 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-10-01 18:21:57 EDT --- Anyway, thanks a lot for adding a new font package in the review pipe
Appart from the CSS classification I can't really help you with, here is some review:
1. non LGC font ⇒ please use a priority ≥ 65 as per fontconfig-priorities.txt
2. please ask the lohit people what they think about this font. IMHO it is highly likely one of the lohit fonts shares a common ancestry with gargi (and in that case they should at least cross-alias each other)
3. Licensing should be GPLv2+
4. (non blocking) please ask upstream to add the standard FSF GPL font exception to their licensing
5. (non blocking) description could use some meat
Anyway, this package is mostly fine, except for the classification problem.
NEEDINFO till this is resolved