Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=3512
Jonathan Kew jfkthame@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #558206|review?(jfkthame@gmail.com) |review+ Flags| |
--- Comment #79 from Jonathan Kew jfkthame@gmail.com 2011-09-05 00:37:30 PDT --- Comment on attachment 558206 --> https://bugzilla.mozilla.org/attachment.cgi?id=558206 patch, reftests for font-stretch with a variety of font families
Review of attachment 558206: --> (https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=3512&atta...) -----------------------------------------------------------------
Thanks for putting these together - looks good. I was thinking we could "misuse" weights of mplus to stand in for different widths, rather than trying to find (or create) a family that really has them all; the only downside is that it makes visual review of the test cases a bit confusing, I think, but we can live with that for now.
::: layout/reftests/font-matching/stretchmapping-all-ref.html @@ +206,5 @@
- src: url(../fonts/csstest-widths-wd9.ttf);
- font-stretch: ultra-expanded;
+}
+.fstest-3-5-mixed-weights tr { font-family: fstest-3-5-mixed-weights; }
A small nit - this "mixed-weights" class (and hence the following @font-face rules) in both the reference and testcase files is redundant, AFAICS; it doesn't seem to be used in the test at all. Clean up before landing (or were you intending to have additional content in the test that would use this?)