Applied, thanks!
(I actually applied earlier but our whole testsuite was broken due to
shellshock - yay!)
On Fri 26 Sep 2014 09:25:27 PM CEST Jerry James wrote:
I have attached a trivial patch that improves the English text in
the
test for whether a package with a given name already exists. HTH.
Regards,
--
Jerry James
http://www.jamezone.org/
From 97aa4b0b0d9ed0f497c4e4ce540d860cabeb0a38 Mon Sep 17 00:00:00 2001
From: Jerry James <loganjerry(a)gmail.com>
Date: Fri, 26 Sep 2014 13:17:26 -0600
Subject: [PATCH] Improve English in the duplicate package name test.
Improve English grammar in the duplicate package name test.
---
plugins/generic.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/plugins/generic.py b/plugins/generic.py
index dfbf0b6..4b09393 100644
--- a/plugins/generic.py
+++ b/plugins/generic.py
@@ -1479,7 +1479,7 @@ class CheckNoNameConflict(GenericCheckBase):
GenericCheckBase.__init__(self, base)
self.url = "https://fedoraproject.org/wiki/Packaging/" \
"NamingGuidelines#Conflicting_Package_Names"
- self.text = 'Package do not use a name that already exist'
+ self.text = 'Package does not use a name that already exists.'
self.automatic = True
self.type = 'MUST'
@@ -1501,7 +1501,7 @@ class CheckNoNameConflict(GenericCheckBase):
if already_exist(name.lower()) or already_exist(name):
self.set_passed(
self.FAIL,
- 'A package already exist with this name, please check'
+ 'A package with this name already exists. Please check'
'
https://admin.fedoraproject.org/pkgdb/acls/name/'
+ name)
else:
--
1.9.3
_______________________________________________
fedorareview mailing list
fedorareview(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/fedorareview
--
Stanislav Ochotnicky <sochotnicky(a)redhat.com>
Business System Analyst, Hosted and Shared Services
PGP: 7B087241
Red Hat Inc.