#150: timezone field bug for all day meetings ---------------------+------------------------- Reporter: mattdm | Owner: Type: defect | Status: new Priority: minor | Milestone: Future Component: fedocal | Version: development Keywords: | ---------------------+------------------------- When selecting "all day meeting", Fedocal grays out the timezone. but then when you go to submit, it complains that the choice is invalid (but does at least ungray the field).
Probably the right thing is to just require a timezone, because otherwise, when does the day start and end?
#150: timezone field bug for all day meetings ----------------------+------------------------- Reporter: mattdm | Owner: pingou Type: defect | Status: assigned Priority: minor | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: ----------------------+------------------------- Changes (by pingou):
* owner: => pingou * status: new => assigned
Comment:
Nice catch, I had seen it but somehow got past it and then forgot about, sorry :(
Anyway, it's fixed in: https://github.com/fedora- infra/fedocal/commit/a67cb581d8493012045224a0143bd5681c89e49b which also explains the root of the issue.
Thanks for the report!
#150: timezone field bug for all day meetings ----------------------+------------------------- Reporter: mattdm | Owner: pingou Type: defect | Status: assigned Priority: minor | Milestone: Future Component: fedocal | Version: development Resolution: | Keywords: ----------------------+-------------------------
Comment (by pingou):
Up for review at https://github.com/fedora-infra/fedocal/pull/165
#150: timezone field bug for all day meetings ----------------------+------------------------- Reporter: mattdm | Owner: pingou Type: defect | Status: closed Priority: minor | Milestone: 0.13 Component: fedocal | Version: development Resolution: fixed | Keywords: ----------------------+------------------------- Changes (by pingou):
* status: assigned => closed * milestone: Future => 0.13 * resolution: => fixed
Comment:
And merged!
Thanks again for the report
fedocal-devel@lists.fedorahosted.org