Hi, This app recently updated and I've noticed that it stomped on my /etc/sysconfig/postrgey file isn't this wrong? Looking at the spec file, in the %files section it has:
%{_sysconfdir}/sysconfig/postgrey
Shouldn't this be:
%config(noreplace) %{_sysconfdir}/sysconfig/postgrey
Regards,
Nick
On Thursday, 13 May 2021 at 10:21, Nick Howitt wrote:
Hi, This app recently updated and I've noticed that it stomped on my /etc/sysconfig/postrgey file isn't this wrong? Looking at the spec file, in the %files section it has:
%{_sysconfdir}/sysconfig/postgrey
Shouldn't this be:
%config(noreplace) %{_sysconfdir}/sysconfig/postgrey
It most probably should. This looks like a packaging bug and I'd suggest opening a bug report, with a patch or even a pull request against the spec file.
Regards, Dominik
On 13/05/2021 09:55, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 13 May 2021 at 10:21, Nick Howitt wrote:
Hi, This app recently updated and I've noticed that it stomped on my /etc/sysconfig/postrgey file isn't this wrong? Looking at the spec file, in the %files section it has:
%{_sysconfdir}/sysconfig/postgrey
Shouldn't this be:
%config(noreplace) %{_sysconfdir}/sysconfig/postgrey
It most probably should. This looks like a packaging bug and I'd suggest opening a bug report, with a patch or even a pull request against the spec file.
Regards, Dominik
I've found the bug tracker and filed https://bugzilla.redhat.com/show_bug.cgi?id=1960184. I'm lousy at creating patch files so I've ducked it.
On 13/05/2021 10:21, Nick Howitt wrote:
On 13/05/2021 09:55, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 13 May 2021 at 10:21, Nick Howitt wrote:
Hi, This app recently updated and I've noticed that it stomped on my /etc/sysconfig/postrgey file isn't this wrong? Looking at the spec file, in the %files section it has:
%{_sysconfdir}/sysconfig/postgrey
Shouldn't this be:
%config(noreplace) %{_sysconfdir}/sysconfig/postgrey
It most probably should. This looks like a packaging bug and I'd suggest opening a bug report, with a patch or even a pull request against the spec file.
Regards, Dominik
I've found the bug tracker and filed https://bugzilla.redhat.com/show_bug.cgi?id=1960184. I'm lousy at creating patch files so I've ducked it. _______________________________________________ epel-devel mailing list -- epel-devel@lists.fedoraproject.org To unsubscribe send an email to epel-devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject...
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Ugh not an easy bug. The unit file has changed (or the requirements for startup options have) so the sysconfig file needs more options in it. It is a pity there was not a "%config noreplace" but with a smart %post to add the extra parameters needed.
I think I'll mark the bug as invalid.
On Thu, 13 May 2021, Nick Howitt wrote:
On 13/05/2021 10:21, Nick Howitt wrote:
On 13/05/2021 09:55, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 13 May 2021 at 10:21, Nick Howitt wrote:
Hi, This app recently updated and I've noticed that it stomped on my /etc/sysconfig/postrgey file isn't this wrong? Looking at the spec file, in the %files section it has:
%{_sysconfdir}/sysconfig/postgrey
Shouldn't this be:
%config(noreplace) %{_sysconfdir}/sysconfig/postgrey
It most probably should. This looks like a packaging bug and I'd suggest opening a bug report, with a patch or even a pull request against the spec file.
Regards, Dominik
I've found the bug tracker and filed https://bugzilla.redhat.com/show_bug.cgi?id=1960184. I'm lousy at creating patch files so I've ducked it.
Ugh not an easy bug. The unit file has changed (or the requirements for startup options have) so the sysconfig file needs more options in it. It is a pity there was not a "%config noreplace" but with a smart %post to add the extra parameters needed.
I think I'll mark the bug as invalid.
In that case, shouldn't we change the line to %config %{_sysconfdir}/sysconfig/postgrey so that the old file is saved at %{_sysconfdir}/sysconfig/postgrey.rpmsave ?
epel-devel@lists.fedoraproject.org
-
Andrew C Aitchison -
Dominik 'Rathann' Mierzejewski -
Nick Howitt