Hi,
while working on the previous patches, I noticed a number of generated files are not part of .gitignore, so git shows them in the status output.
Attached there is a patch for it to ignore most of them.
Thanks,
On Tue, 2015-06-30 at 08:46 +0200, Pino Toscano wrote:
while working on the previous patches, I noticed a number of generated files are not part of .gitignore, so git shows them in the status output.
Attached there is a patch for it to ignore most of them.
These are all files generated in the builddir aren't they? Since they don't show up when doing a srcdir != builddir build I prefer not to add them since they aren't really generated (source) files.
But this has come up before, so maybe I am wrong?
Thanks,
Mark
On 06/30/2015 03:48 AM, Mark Wielaard wrote:
On Tue, 2015-06-30 at 08:46 +0200, Pino Toscano wrote:
while working on the previous patches, I noticed a number of generated files are not part of .gitignore, so git shows them in the status output.
Attached there is a patch for it to ignore most of them.
These are all files generated in the builddir aren't they? Since they don't show up when doing a srcdir != builddir build I prefer not to add them since they aren't really generated (source) files.
But this has come up before, so maybe I am wrong?
IMO, if srcdir==builddir is a supported way to build, then .gitignore ought to include those things. Besides, it already does include some build artifacts like "*.o".
However, I would suggest that specific ignores should be anchored to their path. e.g. "version.h" ignores that name in any path, whereas "/version.h" would only ignore that in the directory with .gitignore.
Git does that anchoring for any pattern containing "/", so things like "tests/hash" are matched relative to .gitignore too. You could instead create a "tests/.gitignore" containing "/hash" to keep it localized.
On 30 Jun 2015 12:48, Mark Wielaard wrote:
On Tue, 2015-06-30 at 08:46 +0200, Pino Toscano wrote:
while working on the previous patches, I noticed a number of generated files are not part of .gitignore, so git shows them in the status output.
Attached there is a patch for it to ignore most of them.
These are all files generated in the builddir aren't they? Since they don't show up when doing a srcdir != builddir build I prefer not to add them since they aren't really generated (source) files.
But this has come up before, so maybe I am wrong?
yes, and the previous patches were placed on hold while someone would rebase. can we just merge these already please ? -mike
On Mon, 2015-07-06 at 05:52 -0400, Mike Frysinger wrote:
On 30 Jun 2015 12:48, Mark Wielaard wrote:
On Tue, 2015-06-30 at 08:46 +0200, Pino Toscano wrote:
while working on the previous patches, I noticed a number of generated files are not part of .gitignore, so git shows them in the status output.
Attached there is a patch for it to ignore most of them.
These are all files generated in the builddir aren't they? Since they don't show up when doing a srcdir != builddir build I prefer not to add them since they aren't really generated (source) files.
But this has come up before, so maybe I am wrong?
yes
:) I am clearly outnumbered.
and the previous patches were placed on hold while someone would rebase. can we just merge these already please ?
Josh had some concerns about the proposed patch, in particular that they weren't anchored. So lets fix that first.
Cheers,
Mark
Hi,
In data martedì 30 giugno 2015 08:46:27, Pino Toscano ha scritto:
while working on the previous patches, I noticed a number of generated files are not part of .gitignore, so git shows them in the status output.
Attached there is a patch for it to ignore most of them.
Thanks Mark and Josh for the feedback provided!
Attached there is a new version of the patch, which also anchors some of the existing filenames to their locations.
Thanks,
On Sat, Jul 11, 2015 at 10:04:59AM +0200, Pino Toscano wrote:
Attached there is a new version of the patch, which also anchors some of the existing filenames to their locations.
Thanks, pushed. But it will need to be kept up to date by people actually do srcdir == builddir builds.
Fill the .gitignore with more generated files, such as:
- test executables
BTW. Why only the test executables? Why not the src executables?
Cheers,
Mark
elfutils-devel@lists.fedorahosted.org