Hi there,
I'd like to make -wline output more regular and useful. Currently lines describing opcodes are formatted inconsistently either with or without initial space. That's probably an aesthetic nit, I don't think that there is a pattern to it.
Second, more important change is that I'd like to prefix opcode lines with their offset. This should aid debugging and reviewing dwarflint citations.
Both changes are on the branch pmachata/readelf.
PM
I haven't looked at the changes but they sound entirely reasonable to me. Just keep the style of output format consistent with the other output that shows offsets and so forth, which I presume you did.
Thanks, Roland
On Thu, 2011-03-24 at 14:37 +0100, Petr Machata wrote:
I'd like to make -wline output more regular and useful. Currently lines describing opcodes are formatted inconsistently either with or without initial space. That's probably an aesthetic nit, I don't think that there is a pattern to it.
Second, more important change is that I'd like to prefix opcode lines with their offset. This should aid debugging and reviewing dwarflint citations.
Changes look good to me. Indeed more consistent and more useful. But it would be even more consistent if the offsets were printed as in the .debug_info section. So using "%6zx" to make them all the same width.
Both changes are on the branch pmachata/readelf.
BTW. I still prefer seeing patches on the list whenever possible.
Thanks,
Mark
Mark Wielaard mjw@redhat.com writes:
On Thu, 2011-03-24 at 14:37 +0100, Petr Machata wrote:
I'd like to make -wline output more regular and useful.
Changes look good to me. Indeed more consistent and more useful. But it would be even more consistent if the offsets were printed as in the .debug_info section. So using "%6zx" to make them all the same width.
I made the change and merged.
Thanks, PM
elfutils-devel@lists.fedorahosted.org