On Sun, 27 Jul 2014 22:53:58 +0200, Mark Wielaard wrote:
Just one nitpick with the following comment:
>
> - GElf_Addr l_addr = addrs[0];
> + // unused:
> + // GElf_Addr l_addr = addrs[0];
> GElf_Addr l_name = addrs[1];
> GElf_Addr l_ld = addrs[2];
Could you expand that comment a little to say why it is unused and why we
need to recalculate it? Maybe "Unused: l_addr is the difference between
the address in memory and the ELF file when the core was created. We need
to recalculate the difference below because the ELF file we use might be
differently pre-linked." Or something similar.
Done.
Checked in:
475849fdb25265706772905b856cd7028c566a71
Thanks,
Jan